From: akpm@linux-foundation.org
To: fabf@skynet.be, viro@zeniv.linux.org.uk, mm-commits@vger.kernel.org
Subject: + fs-affs-bugfix-write-files-greater-than-page-size-on-ofs.patch added to -mm tree
Date: Tue, 25 Apr 2017 13:51:51 -0700 [thread overview]
Message-ID: <58ffb6e7.FE6ZRQtj9vz5cUqa%akpm@linux-foundation.org> (raw)
The patch titled
Subject: fs/affs: bugfix: write files greater than page size on OFS
has been added to the -mm tree. Its filename is
fs-affs-bugfix-write-files-greater-than-page-size-on-ofs.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/fs-affs-bugfix-write-files-greater-than-page-size-on-ofs.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/fs-affs-bugfix-write-files-greater-than-page-size-on-ofs.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Fabian Frederick <fabf@skynet.be>
Subject: fs/affs: bugfix: write files greater than page size on OFS
Previous AFFS patch fixed OFS write operations but unveiled another bug:
files greater than 4KB are being created with a wrong size resulting in
errors like the following:
dd if=/dev/zero of=file bs=4097 count=1
cp file /mnt/affs/
cp: error writing '/mnt/affs/file': Bad address
Link: http://lkml.kernel.org/r/20170424201310.1796-1-fabf@skynet.be
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/affs/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN fs/affs/file.c~fs-affs-bugfix-write-files-greater-than-page-size-on-ofs fs/affs/file.c
--- a/fs/affs/file.c~fs-affs-bugfix-write-files-greater-than-page-size-on-ofs
+++ a/fs/affs/file.c
@@ -679,7 +679,7 @@ static int affs_write_end_ofs(struct fil
int written;
from = pos & (PAGE_SIZE - 1);
- to = pos + len;
+ to = from + len;
/*
* XXX: not sure if this can handle short copies (len < copied), but
* we don't have to, because the page should always be uptodate here,
_
Patches currently in -mm which might be from fabf@skynet.be are
fs-affs-bugfix-make-symbolic-links-work-again.patch
fs-affs-bugfix-enable-writes-on-ofs-disks.patch
fs-affs-bugfix-write-files-greater-than-page-size-on-ofs.patch
reply other threads:[~2017-04-25 20:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58ffb6e7.FE6ZRQtj9vz5cUqa%akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.