All of lore.kernel.org
 help / color / mirror / Atom feed
* + fs-affs-bugfix-write-files-greater-than-page-size-on-ofs.patch added to -mm tree
@ 2017-04-25 20:51 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2017-04-25 20:51 UTC (permalink / raw)
  To: fabf, viro, mm-commits


The patch titled
     Subject: fs/affs: bugfix: write files greater than page size on OFS
has been added to the -mm tree.  Its filename is
     fs-affs-bugfix-write-files-greater-than-page-size-on-ofs.patch

This patch should soon appear at
    http://ozlabs.org/~akpm/mmots/broken-out/fs-affs-bugfix-write-files-greater-than-page-size-on-ofs.patch
and later at
    http://ozlabs.org/~akpm/mmotm/broken-out/fs-affs-bugfix-write-files-greater-than-page-size-on-ofs.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Fabian Frederick <fabf@skynet.be>
Subject: fs/affs: bugfix: write files greater than page size on OFS

Previous AFFS patch fixed OFS write operations but unveiled another bug:
files greater than 4KB are being created with a wrong size resulting in
errors like the following:

dd if=/dev/zero of=file bs=4097 count=1
cp file /mnt/affs/
cp: error writing '/mnt/affs/file': Bad address

Link: http://lkml.kernel.org/r/20170424201310.1796-1-fabf@skynet.be
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/affs/file.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN fs/affs/file.c~fs-affs-bugfix-write-files-greater-than-page-size-on-ofs fs/affs/file.c
--- a/fs/affs/file.c~fs-affs-bugfix-write-files-greater-than-page-size-on-ofs
+++ a/fs/affs/file.c
@@ -679,7 +679,7 @@ static int affs_write_end_ofs(struct fil
 	int written;
 
 	from = pos & (PAGE_SIZE - 1);
-	to = pos + len;
+	to = from + len;
 	/*
 	 * XXX: not sure if this can handle short copies (len < copied), but
 	 * we don't have to, because the page should always be uptodate here,
_

Patches currently in -mm which might be from fabf@skynet.be are

fs-affs-bugfix-make-symbolic-links-work-again.patch
fs-affs-bugfix-enable-writes-on-ofs-disks.patch
fs-affs-bugfix-write-files-greater-than-page-size-on-ofs.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-04-25 20:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-25 20:51 + fs-affs-bugfix-write-files-greater-than-page-size-on-ofs.patch added to -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.