* [PATCH] drm/rockchip: fix typo in Kconfig 's/HDMI/dsi/'
@ 2020-11-16 14:16 Dafna Hirschfeld
2020-11-16 14:16 ` [PATCH] drm/rockchip: for error print, use the correct device pointer Dafna Hirschfeld
2020-11-29 16:52 ` [PATCH] drm/rockchip: fix typo in Kconfig 's/HDMI/dsi/' Heiko Stübner
0 siblings, 2 replies; 3+ messages in thread
From: Dafna Hirschfeld @ 2020-11-16 14:16 UTC (permalink / raw)
To: hjc, heiko
Cc: enric.balletbo, linux-rockchip, dafna3, kernel, dafna.hirschfeld
In the help of ROCKCHIP_DW_MIPI_DSI it said
it is a HDMI driver instead of a dsi driver.
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
drivers/gpu/drm/rockchip/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
index 310aa1546893..cb25c0e8fc9b 100644
--- a/drivers/gpu/drm/rockchip/Kconfig
+++ b/drivers/gpu/drm/rockchip/Kconfig
@@ -49,7 +49,7 @@ config ROCKCHIP_DW_MIPI_DSI
select GENERIC_PHY_MIPI_DPHY
help
This selects support for Rockchip SoC specific extensions
- for the Synopsys DesignWare HDMI driver. If you want to
+ for the Synopsys DesignWare dsi driver. If you want to
enable MIPI DSI on RK3288 or RK3399 based SoC, you should
select this option.
--
2.17.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] drm/rockchip: for error print, use the correct device pointer
2020-11-16 14:16 [PATCH] drm/rockchip: fix typo in Kconfig 's/HDMI/dsi/' Dafna Hirschfeld
@ 2020-11-16 14:16 ` Dafna Hirschfeld
2020-11-29 16:52 ` [PATCH] drm/rockchip: fix typo in Kconfig 's/HDMI/dsi/' Heiko Stübner
1 sibling, 0 replies; 3+ messages in thread
From: Dafna Hirschfeld @ 2020-11-16 14:16 UTC (permalink / raw)
To: hjc, heiko
Cc: enric.balletbo, linux-rockchip, dafna3, kernel, dafna.hirschfeld
There is a use of DRM_DEV_ERROR(dsi->dev,..)
which should be replaced with DRM_DEV_ERROR(dev, ..)
since dsi->dev is set later
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
index 542dcf7eddd6..a610335eaa6e 100644
--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
@@ -1089,7 +1089,7 @@ static int dw_mipi_dsi_rockchip_probe(struct platform_device *pdev)
dsi->grf_regmap = syscon_regmap_lookup_by_phandle(np, "rockchip,grf");
if (IS_ERR(dsi->grf_regmap)) {
- DRM_DEV_ERROR(dsi->dev, "Unable to get rockchip,grf\n");
+ DRM_DEV_ERROR(dev, "Unable to get rockchip,grf\n");
return PTR_ERR(dsi->grf_regmap);
}
--
2.17.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/rockchip: fix typo in Kconfig 's/HDMI/dsi/'
2020-11-16 14:16 [PATCH] drm/rockchip: fix typo in Kconfig 's/HDMI/dsi/' Dafna Hirschfeld
2020-11-16 14:16 ` [PATCH] drm/rockchip: for error print, use the correct device pointer Dafna Hirschfeld
@ 2020-11-29 16:52 ` Heiko Stübner
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2020-11-29 16:52 UTC (permalink / raw)
To: hjc, Dafna Hirschfeld
Cc: enric.balletbo, linux-rockchip, dafna3, kernel, dafna.hirschfeld
Hi Dafna,
Am Montag, 16. November 2020, 15:16:08 CET schrieb Dafna Hirschfeld:
> In the help of ROCKCHIP_DW_MIPI_DSI it said
> it is a HDMI driver instead of a dsi driver.
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
applied both patches to drm-misc-next.
Just a small wish for the future, threading together unrelated patches
makes b4 hickup, so ideally either submit them separately or give them
a numbering (1/2 + 2/2).
Thanks
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-29 16:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 14:16 [PATCH] drm/rockchip: fix typo in Kconfig 's/HDMI/dsi/' Dafna Hirschfeld
2020-11-16 14:16 ` [PATCH] drm/rockchip: for error print, use the correct device pointer Dafna Hirschfeld
2020-11-29 16:52 ` [PATCH] drm/rockchip: fix typo in Kconfig 's/HDMI/dsi/' Heiko Stübner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.