Re: [PATCH 5/7] x86/traps: Lift all non-entrypoint logic in entry_int82() up into C

["Jan Beulich" <JBeulich@suse.com>]

>>> On 02.05.17 at 20:05, <andrew.cooper3@citrix.com> wrote:
> --- /dev/null
> +++ b/xen/arch/x86/pv/traps.c
> @@ -0,0 +1,44 @@
> +/******************************************************************************
> + * arch/x86/pv/traps.c
> + *
> + * PV low level entry points.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; If not, see <http://www.gnu.org/licenses/>.
> + *
> + * Copyright (c) 2017 Citrix Systems Ltd.
> + */
> +
> +#include <xen/hypercall.h>
> +
> +#include <asm/apic.h>
> +
> +#ifdef CONFIG_COMPAT

As expressed before, I disagree to the re-introduction of such
conditionals in x86 code.

> +void do_entry_int82(struct cpu_user_regs *regs)

Ah, so here we go. If this and patch 4 get committed together, I
withdraw my declaration specific change request on that other
patch.

> --- a/xen/include/asm-x86/hypercall.h
> +++ b/xen/include/asm-x86/hypercall.h
> @@ -25,6 +25,10 @@ typedef struct {
>  
>  extern const hypercall_args_t hypercall_args_table[NR_hypercalls];
>  
> +#ifdef CONFIG_PV
> +void pv_hypercall(struct cpu_user_regs *regs);
> +#endif

Are such #ifdef-s really useful? Having the declaration does no harm,
linking would fail if the config setting is off.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel