* [V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI
@ 2019-01-07 14:58 m.balaji
0 siblings, 0 replies; 5+ messages in thread
From: m.balaji @ 2019-01-07 14:58 UTC (permalink / raw)
To: Hans de Goede, linux-usb; +Cc: mathias.nyman, heikki.krogerus
> -----Original Message-----
> From: linux-usb-owner@vger.kernel.org [mailto:linux-usb-
> owner@vger.kernel.org] On Behalf Of Hans de Goede
> Sent: Monday, January 7, 2019 4:20 PM
> To: Balaji, M <m.balaji@intel.com>; linux-usb@vger.kernel.org
> Cc: mathias.nyman@linux.intel.com; heikki.krogerus@linux.intel.com
> Subject: Re: [PATCH V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on
> INTEL_SUNRISEPOINT_LP_XHCI
>
> Hi,
>
> On 08-01-19 11:04, m.balaji@intel.com wrote:
> > From: M, Balaji <m.balaji@intel.com>
> >
> > This fix enables USB role feature on intel commercial nuc
> > platform which is based on Kabylake chipset.
> >
> > Signed-off-by: M, Balaji <m.balaji@intel.com>
> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> > ---
> > Changes from v1: Added Reviewed-by
>
> There is no need to send out a v2 just to add a Reviewed-by,
> the subsys-maintainer will pick the Reviewed-by up when merging.
>
> If you need to do a v2 to add some other minor change adding the
> Reviewed-by is fine.
>
> Regards,
>
> Hans
Hello Hans ,
Sure got it , thanks Will take care next time .
Regards ,
Balaji
>
>
> > drivers/usb/host/xhci-pci.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> > index a9ec7051f286..c2fe218e051f 100644
> > --- a/drivers/usb/host/xhci-pci.c
> > +++ b/drivers/usb/host/xhci-pci.c
> > @@ -194,6 +194,7 @@ static void xhci_pci_quirks(struct device *dev, struct
> xhci_hcd *xhci)
> > xhci->quirks |= XHCI_SSIC_PORT_UNUSED;
> > if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
> > (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||
> > + pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI ||
> > pdev->device == PCI_DEVICE_ID_INTEL_APL_XHCI))
> > xhci->quirks |= XHCI_INTEL_USB_ROLE_SW;
> > if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* [V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI
@ 2019-01-08 10:04 m.balaji
0 siblings, 0 replies; 5+ messages in thread
From: m.balaji @ 2019-01-08 10:04 UTC (permalink / raw)
To: linux-usb; +Cc: mathias.nyman, heikki.krogerus, hdegoede, M, Balaji
From: M, Balaji <m.balaji@intel.com>
This fix enables USB role feature on intel commercial nuc
platform which is based on Kabylake chipset.
Signed-off-by: M, Balaji <m.balaji@intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
---
Changes from v1: Added Reviewed-by
drivers/usb/host/xhci-pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index a9ec7051f286..c2fe218e051f 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -194,6 +194,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
xhci->quirks |= XHCI_SSIC_PORT_UNUSED;
if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
(pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||
+ pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI ||
pdev->device == PCI_DEVICE_ID_INTEL_APL_XHCI))
xhci->quirks |= XHCI_INTEL_USB_ROLE_SW;
if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI
@ 2019-01-07 16:15 Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2019-01-07 16:15 UTC (permalink / raw)
To: m.balaji; +Cc: linux-usb, mathias.nyman, heikki.krogerus, hdegoede, M
On Tue, Jan 08, 2019 at 05:04:20AM -0500, m.balaji@intel.com wrote:
> From: M, Balaji <m.balaji@intel.com>
>
> This fix enables USB role feature on intel commercial nuc
> platform which is based on Kabylake chipset.
Your subject prefix is a bit odd "roles" is not a global thing, it
should look something like:
usb: xhci: fix for enabling...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI
@ 2019-01-07 11:36 Heikki Krogerus
0 siblings, 0 replies; 5+ messages in thread
From: Heikki Krogerus @ 2019-01-07 11:36 UTC (permalink / raw)
To: m.balaji; +Cc: linux-usb, mathias.nyman, hdegoede, M
On Tue, Jan 08, 2019 at 05:04:20AM -0500, m.balaji@intel.com wrote:
> From: M, Balaji <m.balaji@intel.com>
>
> This fix enables USB role feature on intel commercial nuc
> platform which is based on Kabylake chipset.
>
> Signed-off-by: M, Balaji <m.balaji@intel.com>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
OK by me:
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Do not send an other version where you add just that tag! Mathias, as
the maintainer, will take care of adding the tag to the commit.
> ---
> Changes from v1: Added Reviewed-by
> drivers/usb/host/xhci-pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index a9ec7051f286..c2fe218e051f 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -194,6 +194,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
> xhci->quirks |= XHCI_SSIC_PORT_UNUSED;
> if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
> (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||
> + pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI ||
> pdev->device == PCI_DEVICE_ID_INTEL_APL_XHCI))
> xhci->quirks |= XHCI_INTEL_USB_ROLE_SW;
> if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
> --
> 2.17.1
thanks,
^ permalink raw reply [flat|nested] 5+ messages in thread
* [V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI
@ 2019-01-07 10:49 Hans de Goede
0 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2019-01-07 10:49 UTC (permalink / raw)
To: m.balaji, linux-usb; +Cc: mathias.nyman, heikki.krogerus
Hi,
On 08-01-19 11:04, m.balaji@intel.com wrote:
> From: M, Balaji <m.balaji@intel.com>
>
> This fix enables USB role feature on intel commercial nuc
> platform which is based on Kabylake chipset.
>
> Signed-off-by: M, Balaji <m.balaji@intel.com>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes from v1: Added Reviewed-by
There is no need to send out a v2 just to add a Reviewed-by,
the subsys-maintainer will pick the Reviewed-by up when merging.
If you need to do a v2 to add some other minor change adding the
Reviewed-by is fine.
Regards,
Hans
> drivers/usb/host/xhci-pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index a9ec7051f286..c2fe218e051f 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -194,6 +194,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
> xhci->quirks |= XHCI_SSIC_PORT_UNUSED;
> if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
> (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||
> + pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI ||
> pdev->device == PCI_DEVICE_ID_INTEL_APL_XHCI))
> xhci->quirks |= XHCI_INTEL_USB_ROLE_SW;
> if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-08 10:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-07 14:58 [V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI m.balaji
-- strict thread matches above, loose matches on Subject: below --
2019-01-08 10:04 m.balaji
2019-01-07 16:15 Greg KH
2019-01-07 11:36 Heikki Krogerus
2019-01-07 10:49 Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.