All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tinghan Shen <tinghan.shen@mediatek.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v1] dt-bindings: dsp: mediatek: add mt8186 dsp document
Date: Thu, 2 Jun 2022 09:40:18 +0200	[thread overview]
Message-ID: <591767ee-e349-7a17-a9e9-b95d0500c7c1@linaro.org> (raw)
In-Reply-To: <eb4deff1a01c09783518bbaff8fe4e4c4ca6fa5b.camel@mediatek.com>

On 02/06/2022 08:44, Tinghan Shen wrote:
>>> +  mbox-names:
>>> +    items:
>>> +      - const: mbox0
>>> +      - const: mbox1
>>
>> These should be rather some meaningful names, e.g. "rx" and "tx".
> 
> The mbox name has to align with the adsp ipc driver.
> The adsp ipc driver is using 'mbox%d' for mailbox channels.
> 
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?id=9db69df4bdd37eb1f65b6931ee067fb15b9a4d5c
> 
> 	chan_name = kasprintf(GFP_KERNEL, "mbox%d", i);
> 
> 	/* ...snip... */
> 
> 	adsp_chan->ch = mbox_request_channel_byname(cl, chan_name);
> 
> Is it ok to continue using these names?

It is a bit confusing... how did that driver got merged recently without
bindings? Why bindings are separate?

The bindings always come together in one patchset with the driver
implementing them. Bindings are though a separate patch, yet still
followed by the driver which uses them.

I do not see any compatibles in that driver, which suggests there is no
other binding using it. If that's correct, then you need to change the
driver.

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tinghan Shen <tinghan.shen@mediatek.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v1] dt-bindings: dsp: mediatek: add mt8186 dsp document
Date: Thu, 2 Jun 2022 09:40:18 +0200	[thread overview]
Message-ID: <591767ee-e349-7a17-a9e9-b95d0500c7c1@linaro.org> (raw)
In-Reply-To: <eb4deff1a01c09783518bbaff8fe4e4c4ca6fa5b.camel@mediatek.com>

On 02/06/2022 08:44, Tinghan Shen wrote:
>>> +  mbox-names:
>>> +    items:
>>> +      - const: mbox0
>>> +      - const: mbox1
>>
>> These should be rather some meaningful names, e.g. "rx" and "tx".
> 
> The mbox name has to align with the adsp ipc driver.
> The adsp ipc driver is using 'mbox%d' for mailbox channels.
> 
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?id=9db69df4bdd37eb1f65b6931ee067fb15b9a4d5c
> 
> 	chan_name = kasprintf(GFP_KERNEL, "mbox%d", i);
> 
> 	/* ...snip... */
> 
> 	adsp_chan->ch = mbox_request_channel_byname(cl, chan_name);
> 
> Is it ok to continue using these names?

It is a bit confusing... how did that driver got merged recently without
bindings? Why bindings are separate?

The bindings always come together in one patchset with the driver
implementing them. Bindings are though a separate patch, yet still
followed by the driver which uses them.

I do not see any compatibles in that driver, which suggests there is no
other binding using it. If that's correct, then you need to change the
driver.

Best regards,
Krzysztof

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tinghan Shen <tinghan.shen@mediatek.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v1] dt-bindings: dsp: mediatek: add mt8186 dsp document
Date: Thu, 2 Jun 2022 09:40:18 +0200	[thread overview]
Message-ID: <591767ee-e349-7a17-a9e9-b95d0500c7c1@linaro.org> (raw)
In-Reply-To: <eb4deff1a01c09783518bbaff8fe4e4c4ca6fa5b.camel@mediatek.com>

On 02/06/2022 08:44, Tinghan Shen wrote:
>>> +  mbox-names:
>>> +    items:
>>> +      - const: mbox0
>>> +      - const: mbox1
>>
>> These should be rather some meaningful names, e.g. "rx" and "tx".
> 
> The mbox name has to align with the adsp ipc driver.
> The adsp ipc driver is using 'mbox%d' for mailbox channels.
> 
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?id=9db69df4bdd37eb1f65b6931ee067fb15b9a4d5c
> 
> 	chan_name = kasprintf(GFP_KERNEL, "mbox%d", i);
> 
> 	/* ...snip... */
> 
> 	adsp_chan->ch = mbox_request_channel_byname(cl, chan_name);
> 
> Is it ok to continue using these names?

It is a bit confusing... how did that driver got merged recently without
bindings? Why bindings are separate?

The bindings always come together in one patchset with the driver
implementing them. Bindings are though a separate patch, yet still
followed by the driver which uses them.

I do not see any compatibles in that driver, which suggests there is no
other binding using it. If that's correct, then you need to change the
driver.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-06-02  7:40 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-22  7:15 [PATCH v1] dt-bindings: dsp: mediatek: add mt8186 dsp document Tinghan Shen
2022-04-22  7:15 ` Tinghan Shen
2022-04-22  7:15 ` Tinghan Shen
2022-04-22  7:59 ` Rex-BC Chen
2022-04-22  7:59   ` Rex-BC Chen
2022-04-22  7:59   ` Rex-BC Chen
2022-06-02  6:22   ` Tinghan Shen
2022-06-02  6:22     ` Tinghan Shen
2022-06-02  6:22     ` Tinghan Shen
2022-04-22 15:49 ` Krzysztof Kozlowski
2022-04-22 15:49   ` Krzysztof Kozlowski
2022-04-22 15:49   ` Krzysztof Kozlowski
2022-06-02  6:44   ` Tinghan Shen
2022-06-02  6:44     ` Tinghan Shen
2022-06-02  6:44     ` Tinghan Shen
2022-06-02  7:40     ` Krzysztof Kozlowski [this message]
2022-06-02  7:40       ` Krzysztof Kozlowski
2022-06-02  7:40       ` Krzysztof Kozlowski
2022-06-02 10:19       ` Tinghan Shen
2022-06-02 10:19         ` Tinghan Shen
2022-06-02 10:19         ` Tinghan Shen
2022-06-02 10:45         ` Krzysztof Kozlowski
2022-06-02 10:45           ` Krzysztof Kozlowski
2022-06-02 10:45           ` Krzysztof Kozlowski
2022-06-02 11:53           ` Tinghan Shen
2022-06-02 11:53             ` Tinghan Shen
2022-06-02 11:53             ` Tinghan Shen
2022-06-02 12:26             ` Krzysztof Kozlowski
2022-06-02 12:26               ` Krzysztof Kozlowski
2022-06-02 12:26               ` Krzysztof Kozlowski
2022-06-06  2:51               ` Tinghan Shen
2022-06-06  2:51                 ` Tinghan Shen
2022-06-06  2:51                 ` Tinghan Shen
2022-04-22 21:10 ` Rob Herring
2022-04-22 21:10   ` Rob Herring
2022-04-22 21:10   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=591767ee-e349-7a17-a9e9-b95d0500c7c1@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=tinghan.shen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.