All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Ming Qian <ming.qian@nxp.com>,
	mchehab@kernel.org, shawnguo@kernel.org, robh+dt@kernel.org,
	s.hauer@pengutronix.de
Cc: hverkuil-cisco@xs4all.nl, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 03/13] media: amphion: add amphion vpu device driver
Date: Wed, 13 Oct 2021 15:16:38 -0700	[thread overview]
Message-ID: <591813d6-2633-bc64-110e-8f62ca07044e@infradead.org> (raw)
In-Reply-To: <2a70d55e012874b9a3381e0aca23010edf65b2f4.1634095309.git.ming.qian@nxp.com>

On 10/13/21 1:27 AM, Ming Qian wrote:
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index d9f90084c2f6..2465a5f7a073 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -200,6 +200,25 @@ config VIDEO_TI_CAL_MC
>   
>   endif # VIDEO_TI_CAL
>   
> +config VIDEO_AMPHION_VPU
> +	tristate "Amphion VPU(Video Processing Unit) Codec IP"
> +	depends on ARCH_MXC
> +	depends on MEDIA_SUPPORT
> +	depends on VIDEO_DEV
> +	depends on VIDEO_V4L2
> +	select V4L2_MEM2MEM_DEV
> +	select VIDEOBUF2_DMA_CONTIG
> +	select VIDEOBUF2_VMALLOC
> +	default y

This should not be "default y" unless it is needed to boot up
some platform/machine. And even then it should depend on that
platform/machine if possible.

And there are 2 other drivers in that same Kconfig file that
have the same problem.

> +	help
> +	  Amphion VPU Codec IP contains two parts: Windsor and Malone.
> +	  Windsor is encoder that supports H.264, and Malone is decoder
> +	  that supports H.264, HEVC, and other video formats.
> +	  This is a V4L2 driver for NXP MXC 8Q video accelerator hardware.
> +	  It accelerates encoding and decoding operations on
> +	  various NXP SoCs.
> +	  To compile this driver as a module choose m here.


-- 
~Randy

WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: Ming Qian <ming.qian@nxp.com>,
	mchehab@kernel.org, shawnguo@kernel.org, robh+dt@kernel.org,
	s.hauer@pengutronix.de
Cc: hverkuil-cisco@xs4all.nl, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 03/13] media: amphion: add amphion vpu device driver
Date: Wed, 13 Oct 2021 15:16:38 -0700	[thread overview]
Message-ID: <591813d6-2633-bc64-110e-8f62ca07044e@infradead.org> (raw)
In-Reply-To: <2a70d55e012874b9a3381e0aca23010edf65b2f4.1634095309.git.ming.qian@nxp.com>

On 10/13/21 1:27 AM, Ming Qian wrote:
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index d9f90084c2f6..2465a5f7a073 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -200,6 +200,25 @@ config VIDEO_TI_CAL_MC
>   
>   endif # VIDEO_TI_CAL
>   
> +config VIDEO_AMPHION_VPU
> +	tristate "Amphion VPU(Video Processing Unit) Codec IP"
> +	depends on ARCH_MXC
> +	depends on MEDIA_SUPPORT
> +	depends on VIDEO_DEV
> +	depends on VIDEO_V4L2
> +	select V4L2_MEM2MEM_DEV
> +	select VIDEOBUF2_DMA_CONTIG
> +	select VIDEOBUF2_VMALLOC
> +	default y

This should not be "default y" unless it is needed to boot up
some platform/machine. And even then it should depend on that
platform/machine if possible.

And there are 2 other drivers in that same Kconfig file that
have the same problem.

> +	help
> +	  Amphion VPU Codec IP contains two parts: Windsor and Malone.
> +	  Windsor is encoder that supports H.264, and Malone is decoder
> +	  that supports H.264, HEVC, and other video formats.
> +	  This is a V4L2 driver for NXP MXC 8Q video accelerator hardware.
> +	  It accelerates encoding and decoding operations on
> +	  various NXP SoCs.
> +	  To compile this driver as a module choose m here.


-- 
~Randy

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-13 22:16 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13  8:27 [PATCH v10 00/13] amphion video decoder/encoder driver Ming Qian
2021-10-13  8:27 ` Ming Qian
2021-10-13  8:27 ` [PATCH v10 01/13] dt-bindings: media: amphion: add amphion video codec bindings Ming Qian
2021-10-13  8:27   ` Ming Qian
2021-10-13 18:39   ` Rob Herring
2021-10-13 18:39     ` Rob Herring
2021-10-14  2:14     ` [EXT] " Ming Qian
2021-10-14  2:14       ` Ming Qian
2021-10-13  8:27 ` [PATCH v10 02/13] media:Add nv12mt_8l128 and nv12mt_10be_8l128 video format Ming Qian
2021-10-13  8:27   ` Ming Qian
2021-10-13  8:27 ` [PATCH v10 03/13] media: amphion: add amphion vpu device driver Ming Qian
2021-10-13  8:27   ` Ming Qian
2021-10-13 22:16   ` Randy Dunlap [this message]
2021-10-13 22:16     ` Randy Dunlap
2021-10-14  1:49     ` [EXT] " Ming Qian
2021-10-14  1:49       ` Ming Qian
2021-10-14 19:54   ` kernel test robot
2021-10-14 19:54     ` kernel test robot
2021-10-13  8:27 ` [PATCH v10 04/13] media: amphion: add vpu core driver Ming Qian
2021-10-13  8:27   ` Ming Qian
2021-10-13  8:27 ` [PATCH v10 05/13] media: amphion: implement vpu core communication based on mailbox Ming Qian
2021-10-13  8:27   ` Ming Qian
2021-10-13  8:27 ` [PATCH v10 06/13] media: amphion: add vpu v4l2 m2m support Ming Qian
2021-10-13  8:27   ` Ming Qian
2021-10-13  8:27 ` [PATCH v10 07/13] media: amphion: add v4l2 m2m vpu encoder stateful driver Ming Qian
2021-10-13  8:27   ` Ming Qian
2021-10-13  8:27 ` [PATCH v10 08/13] media: amphion: add v4l2 m2m vpu decoder " Ming Qian
2021-10-13  8:27   ` Ming Qian
2021-10-13  8:27 ` [PATCH v10 09/13] media: amphion: implement windsor encoder rpc interface Ming Qian
2021-10-13  8:27   ` Ming Qian
2021-10-13  8:27 ` [PATCH v10 10/13] media: amphion: implement malone decoder " Ming Qian
2021-10-13  8:27   ` Ming Qian
2021-10-13  8:27 ` [PATCH v10 11/13] ARM64: dts: freescale: imx8q: add imx vpu codec entries Ming Qian
2021-10-13  8:27   ` Ming Qian
2021-10-13  8:27 ` [PATCH v10 12/13] firmware: imx: scu-pd: imx8q: add vpu mu resources Ming Qian
2021-10-13  8:27   ` Ming Qian
2021-10-13  8:27 ` [PATCH v10 13/13] MAINTAINERS: add AMPHION VPU CODEC V4L2 driver entry Ming Qian
2021-10-13  8:27   ` Ming Qian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=591813d6-2633-bc64-110e-8f62ca07044e@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=aisheng.dong@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=ming.qian@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.