From: "Jan Beulich" <JBeulich@suse.com>
To: xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Julien Grall <julien.grall@arm.com>, Tim Deegan <tim@xen.org>
Subject: [PATCH] x86/HAP: avoid using bogus/misleading locking
Date: Mon, 29 May 2017 06:37:37 -0600 [thread overview]
Message-ID: <592C3231020000780015D449@prv-mh.provo.novell.com> (raw)
In-Reply-To: 592C3231020000780015D449@prv-mh.provo.novell.com
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
hap_teardown() unconditionally releases the paging lock and is always
being called without the lock held: Lock acquire should then be
unconditional too.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
While this is only a cosmetic change afaict I would still like to
explore whether to include this in 4.9.
--- a/xen/arch/x86/mm/hap/hap.c
+++ b/xen/arch/x86/mm/hap/hap.c
@@ -576,8 +576,7 @@ void hap_teardown(struct domain *d, bool
ASSERT(d->is_dying);
ASSERT(d != current->domain);
- if ( !paging_locked_by_me(d) )
- paging_lock(d); /* Keep various asserts happy */
+ paging_lock(d); /* Keep various asserts happy */
if ( paging_mode_enabled(d) )
{
[-- Attachment #2: x86-HAP-teardown-locking.patch --]
[-- Type: text/plain, Size: 762 bytes --]
x86/HAP: avoid using bogus/misleading locking
hap_teardown() unconditionally releases the paging lock and is always
being called without the lock held: Lock acquire should then be
unconditional too.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
While this is only a cosmetic change afaict I would still like to
explore whether to include this in 4.9.
--- a/xen/arch/x86/mm/hap/hap.c
+++ b/xen/arch/x86/mm/hap/hap.c
@@ -576,8 +576,7 @@ void hap_teardown(struct domain *d, bool
ASSERT(d->is_dying);
ASSERT(d != current->domain);
- if ( !paging_locked_by_me(d) )
- paging_lock(d); /* Keep various asserts happy */
+ paging_lock(d); /* Keep various asserts happy */
if ( paging_mode_enabled(d) )
{
[-- Attachment #3: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next parent reply other threads:[~2017-05-29 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 12:37 Jan Beulich [this message]
2017-05-29 13:55 ` [PATCH] x86/HAP: avoid using bogus/misleading locking Andrew Cooper
2017-05-31 9:03 ` Julien Grall
2017-05-31 9:12 ` Jan Beulich
2017-06-06 15:50 ` Ping: " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=592C3231020000780015D449@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.