All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] smp: assert that all affected CPUs are online in on_selected_cpus()
@ 2017-05-31  7:49 Jan Beulich
  2017-05-31  9:52 ` Wei Liu
  2017-05-31 12:45 ` Andrew Cooper
  0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2017-05-31  7:49 UTC (permalink / raw)
  To: xen-devel
  Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper,
	Ian Jackson, Tim Deegan, Boris Ostrovsky

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Suggested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

--- a/xen/common/smp.c
+++ b/xen/common/smp.c
@@ -53,6 +53,7 @@ void on_selected_cpus(
     unsigned int nr_cpus;
 
     ASSERT(local_irq_is_enabled());
+    ASSERT(cpumask_subset(selected, &cpu_online_map));
 
     spin_lock(&call_lock);
 




[-- Attachment #2: osc-assert.patch --]
[-- Type: text/plain, Size: 432 bytes --]

smp: assert that all affected CPUs are online in on_selected_cpus()

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Suggested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

--- a/xen/common/smp.c
+++ b/xen/common/smp.c
@@ -53,6 +53,7 @@ void on_selected_cpus(
     unsigned int nr_cpus;
 
     ASSERT(local_irq_is_enabled());
+    ASSERT(cpumask_subset(selected, &cpu_online_map));
 
     spin_lock(&call_lock);
 

[-- Attachment #3: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] smp: assert that all affected CPUs are online in on_selected_cpus()
  2017-05-31  7:49 [PATCH] smp: assert that all affected CPUs are online in on_selected_cpus() Jan Beulich
@ 2017-05-31  9:52 ` Wei Liu
  2017-05-31 12:45 ` Andrew Cooper
  1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2017-05-31  9:52 UTC (permalink / raw)
  To: Jan Beulich
  Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper,
	Ian Jackson, Tim Deegan, xen-devel, Boris Ostrovsky

On Wed, May 31, 2017 at 01:49:58AM -0600, Jan Beulich wrote:
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Suggested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Reviewed-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] smp: assert that all affected CPUs are online in on_selected_cpus()
  2017-05-31  7:49 [PATCH] smp: assert that all affected CPUs are online in on_selected_cpus() Jan Beulich
  2017-05-31  9:52 ` Wei Liu
@ 2017-05-31 12:45 ` Andrew Cooper
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2017-05-31 12:45 UTC (permalink / raw)
  To: Jan Beulich, xen-devel
  Cc: Stefano Stabellini, Wei Liu, George Dunlap, Tim Deegan,
	Ian Jackson, Boris Ostrovsky

On 31/05/17 08:49, Jan Beulich wrote:
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Suggested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-31 12:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-31  7:49 [PATCH] smp: assert that all affected CPUs are online in on_selected_cpus() Jan Beulich
2017-05-31  9:52 ` Wei Liu
2017-05-31 12:45 ` Andrew Cooper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.