* [PATCH] x86/PoD: drop a pointless local variable
@ 2017-05-31 7:52 Jan Beulich
2017-06-05 9:53 ` George Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2017-05-31 7:52 UTC (permalink / raw)
To: xen-devel; +Cc: George Dunlap
[-- Attachment #1: Type: text/plain, Size: 923 bytes --]
... and move another one into a more narrow scope.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -1180,8 +1180,6 @@ guest_physmap_mark_populate_on_demand(st
{
struct p2m_domain *p2m = p2m_get_hostp2m(d);
unsigned long i, n, pod_count = 0;
- p2m_type_t ot;
- mfn_t omfn;
int rc = 0;
if ( !paging_mode_translate(d) )
@@ -1194,10 +1192,11 @@ guest_physmap_mark_populate_on_demand(st
/* Make sure all gpfns are unused */
for ( i = 0; i < (1UL << order); i += n )
{
+ p2m_type_t ot;
p2m_access_t a;
unsigned int cur_order;
- omfn = p2m->get_entry(p2m, gfn + i, &ot, &a, 0, &cur_order, NULL);
+ p2m->get_entry(p2m, gfn + i, &ot, &a, 0, &cur_order, NULL);
n = 1UL << min(order, cur_order);
if ( p2m_is_ram(ot) )
{
[-- Attachment #2: x86-PoD-drop-variable.patch --]
[-- Type: text/plain, Size: 961 bytes --]
x86/PoD: drop a pointless local variable
... and move another one into a more narrow scope.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -1180,8 +1180,6 @@ guest_physmap_mark_populate_on_demand(st
{
struct p2m_domain *p2m = p2m_get_hostp2m(d);
unsigned long i, n, pod_count = 0;
- p2m_type_t ot;
- mfn_t omfn;
int rc = 0;
if ( !paging_mode_translate(d) )
@@ -1194,10 +1192,11 @@ guest_physmap_mark_populate_on_demand(st
/* Make sure all gpfns are unused */
for ( i = 0; i < (1UL << order); i += n )
{
+ p2m_type_t ot;
p2m_access_t a;
unsigned int cur_order;
- omfn = p2m->get_entry(p2m, gfn + i, &ot, &a, 0, &cur_order, NULL);
+ p2m->get_entry(p2m, gfn + i, &ot, &a, 0, &cur_order, NULL);
n = 1UL << min(order, cur_order);
if ( p2m_is_ram(ot) )
{
[-- Attachment #3: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/PoD: drop a pointless local variable
2017-05-31 7:52 [PATCH] x86/PoD: drop a pointless local variable Jan Beulich
@ 2017-06-05 9:53 ` George Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: George Dunlap @ 2017-06-05 9:53 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel
On Wed, May 31, 2017 at 8:52 AM, Jan Beulich <JBeulich@suse.com> wrote:
> ... and move another one into a more narrow scope.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: George Dunlap <george.dunlap@citrix.com>
>
> --- a/xen/arch/x86/mm/p2m-pod.c
> +++ b/xen/arch/x86/mm/p2m-pod.c
> @@ -1180,8 +1180,6 @@ guest_physmap_mark_populate_on_demand(st
> {
> struct p2m_domain *p2m = p2m_get_hostp2m(d);
> unsigned long i, n, pod_count = 0;
> - p2m_type_t ot;
> - mfn_t omfn;
> int rc = 0;
>
> if ( !paging_mode_translate(d) )
> @@ -1194,10 +1192,11 @@ guest_physmap_mark_populate_on_demand(st
> /* Make sure all gpfns are unused */
> for ( i = 0; i < (1UL << order); i += n )
> {
> + p2m_type_t ot;
> p2m_access_t a;
> unsigned int cur_order;
>
> - omfn = p2m->get_entry(p2m, gfn + i, &ot, &a, 0, &cur_order, NULL);
> + p2m->get_entry(p2m, gfn + i, &ot, &a, 0, &cur_order, NULL);
> n = 1UL << min(order, cur_order);
> if ( p2m_is_ram(ot) )
> {
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-05 9:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-31 7:52 [PATCH] x86/PoD: drop a pointless local variable Jan Beulich
2017-06-05 9:53 ` George Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.