[yocto-autobuilder][PATCH] forcebuild: allow build with default options

[yocto-autobuilder][PATCH] forcebuild: allow build with default options

[Jose Lamego]

From: Anibal Limon <anibal.limon@linux.intel.com>

A forced build fails if no options are passed through command
line (using "-o OPTIONS").

This change allows build to use default options if none are passed
at the command line.

Signed-off-by: Jose Lamego <jose.a.lamego@linux.intel.com>
---
 bin/forcebuild.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/bin/forcebuild.py b/bin/forcebuild.py
index 5fe61a0..e6770a4 100755
--- a/bin/forcebuild.py
+++ b/bin/forcebuild.py
@@ -108,7 +108,11 @@ class YoctoAutobuilderAPI(object):
                     % (builder, state))
             return 1
 
-        opts = eval(opts) # FIXME: transform string argument into dictionary, security?
+        if opts:
+            # FIXME: transform string argument into dictionary, security?
+            opts = eval(opts)
+        else:
+            opts = {}
         current_opts = self._get_options_by_builder(builder)
         for opt in opts:
             if not opt in current_opts:
-- 
2.7.4

Re: [yocto-autobuilder][PATCH] forcebuild: allow build with default options

[Aníbal Limón]

[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]

+ Joshua

On 06/01/2017 12:32 PM, Jose Lamego wrote:
> From: Anibal Limon <anibal.limon@linux.intel.com>
> 
> A forced build fails if no options are passed through command
> line (using "-o OPTIONS").
> 
> This change allows build to use default options if none are passed
> at the command line.
> 
> Signed-off-by: Jose Lamego <jose.a.lamego@linux.intel.com>
> ---
>  bin/forcebuild.py | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/bin/forcebuild.py b/bin/forcebuild.py
> index 5fe61a0..e6770a4 100755
> --- a/bin/forcebuild.py
> +++ b/bin/forcebuild.py
> @@ -108,7 +108,11 @@ class YoctoAutobuilderAPI(object):
>                      % (builder, state))
>              return 1
>  
> -        opts = eval(opts) # FIXME: transform string argument into dictionary, security?
> +        if opts:
> +            # FIXME: transform string argument into dictionary, security?
> +            opts = eval(opts)
> +        else:
> +            opts = {}
>          current_opts = self._get_options_by_builder(builder)
>          for opt in opts:
>              if not opt in current_opts:
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [yocto-autobuilder][PATCH] forcebuild: allow build with default options

[Joshua Lock]

On Thu, 2017-06-01 at 12:32 -0500, Jose Lamego wrote:
> From: Anibal Limon <anibal.limon@linux.intel.com>
> 
> A forced build fails if no options are passed through command
> line (using "-o OPTIONS").
> 
> This change allows build to use default options if none are passed
> at the command line.

Useful. Merged, thanks!

Joshua

> Signed-off-by: Jose Lamego <jose.a.lamego@linux.intel.com>
> ---
>  bin/forcebuild.py | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/bin/forcebuild.py b/bin/forcebuild.py
> index 5fe61a0..e6770a4 100755
> --- a/bin/forcebuild.py
> +++ b/bin/forcebuild.py
> @@ -108,7 +108,11 @@ class YoctoAutobuilderAPI(object):
>                      % (builder, state))
>              return 1
>  
> -        opts = eval(opts) # FIXME: transform string argument into
> dictionary, security?
> +        if opts:
> +            # FIXME: transform string argument into dictionary,
> security?
> +            opts = eval(opts)
> +        else:
> +            opts = {}
>          current_opts = self._get_options_by_builder(builder)
>          for opt in opts:
>              if not opt in current_opts:
> -- 
> 2.7.4
>