* [patch 5/5] mm: correct the comment when reclaimed pages exceed the scanned pages
@ 2017-06-16 21:02 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2017-06-16 21:02 UTC (permalink / raw)
To: torvalds, mm-commits, akpm, zhongjiang, minchan
From: zhongjiang <zhongjiang@huawei.com>
Subject: mm: correct the comment when reclaimed pages exceed the scanned pages
e1587a494540 ("mm: vmpressure: fix sending wrong events on underflow")
declare that reclaimed pages exceed the scanned pages due to the thp
reclaim. it is incorrect because THP will be spilt to normal page and
loop again. which will result in the scanned pages increment.
[akpm@linux-foundation.org: tweak comment text]
Link: http://lkml.kernel.org/r/1496824266-25235-1-git-send-email-zhongjiang@huawei.com
Signed-off-by: zhongjiang <zhongjiang@huawei.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/vmpressure.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -puN mm/vmpressure.c~mm-correct-the-comment-when-reclaimed-pages-exceed-the-scanned-pages mm/vmpressure.c
--- a/mm/vmpressure.c~mm-correct-the-comment-when-reclaimed-pages-exceed-the-scanned-pages
+++ a/mm/vmpressure.c
@@ -115,9 +115,9 @@ static enum vmpressure_levels vmpressure
unsigned long pressure = 0;
/*
- * reclaimed can be greater than scanned in cases
- * like THP, where the scanned is 1 and reclaimed
- * could be 512
+ * reclaimed can be greater than scanned for things such as reclaimed
+ * slab pages. shrink_node() just adds reclaimed pages without a
+ * related increment to scanned pages.
*/
if (reclaimed >= scanned)
goto out;
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-06-16 21:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-16 21:02 [patch 5/5] mm: correct the comment when reclaimed pages exceed the scanned pages akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.