From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, Pavel Machek <pavel@ucw.cz>
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: leds: Add bindings for lm3697 driver
Date: Mon, 10 Sep 2018 21:07:55 +0200 [thread overview]
Message-ID: <59561e0f-e3b9-7898-a300-90b198ad14e6@gmail.com> (raw)
In-Reply-To: <20a814ce-a4c5-0649-6677-6b85a5fd2321@ti.com>
Dan, Pavel,
On 09/10/2018 04:37 PM, Dan Murphy wrote:
> Jacek
>
> On 09/08/2018 02:53 PM, Jacek Anaszewski wrote:
>> Dan,
>>
>> On 09/07/2018 03:52 PM, Dan Murphy wrote:
>> [...]
>>>>
>>>>> And I think Jacek pointed out that the bindings references in this bindings
>>>>> don't even exist.
>>>>>
>>>>> I am thinking we need to deprecate this MFD driver and consolidate these drivers
>>>>> in the LED directory as we indicated before. I did not find any ti-lmu support
>>>>> code.
>>>>>
>>>>> ti-lmu common core code and then the LED children appending the feature differentiation.
>>>>
>>>>> Need some maintainer weigh in here.
>>>>
>>>> Hehe. I'm maintnainer. Fun.
>>>
>>> I know. I want to see if there was any other opinion. Especially for the LED driver.
>>>
>> [...]
>>
>> I have a question - is this lm3697 LED controller a cell of some MFD
>> device? Or is it a self-contained chip?
>>
>
> This is a self contained chip. And the LM3697 only function is a LED driver.
> It does not have any other special functions like the LM363X drivers for GPIO and Regulator support.
This is an argument for merging it as a standalone LED class driver
then. It is even more justifiable, taking into account uncertainties
related to the proper way of adding the support for it to the existing
MFD driver, whereas the code reuse would be the only advantage of having
thus support in MFD subsystem.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2018-09-10 19:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 13:50 [PATCH v6 1/2] dt-bindings: leds: Add bindings for lm3697 driver Dan Murphy
2018-09-06 13:50 ` Dan Murphy
2018-09-06 13:50 ` [PATCH v6 2/2] leds: lm3697: Introduce the " Dan Murphy
2018-09-06 13:50 ` Dan Murphy
2018-09-06 21:16 ` [PATCH v6 1/2] dt-bindings: leds: Add bindings for " Pavel Machek
2018-09-07 13:20 ` Dan Murphy
2018-09-07 13:20 ` Dan Murphy
2018-09-07 13:32 ` Pavel Machek
2018-09-07 13:52 ` Dan Murphy
2018-09-07 13:52 ` Dan Murphy
2018-09-08 19:53 ` Jacek Anaszewski
2018-09-10 14:37 ` Dan Murphy
2018-09-10 14:37 ` Dan Murphy
2018-09-10 19:07 ` Jacek Anaszewski [this message]
2018-09-10 19:51 ` Dan Murphy
2018-09-10 19:51 ` Dan Murphy
2018-09-11 18:27 ` Jacek Anaszewski
2018-09-11 18:37 ` Dan Murphy
2018-09-11 18:37 ` Dan Murphy
2018-09-11 20:55 ` Pavel Machek
2018-09-11 21:05 ` Dan Murphy
2018-09-11 21:05 ` Dan Murphy
2018-09-10 15:41 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59561e0f-e3b9-7898-a300-90b198ad14e6@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.