* [PATCH] target: make device_mutex and device_list static
@ 2017-07-04 8:44 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2017-07-04 8:44 UTC (permalink / raw)
To: Nicholas A . Bellinger, linux-scsi, target-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variables device_mutex and device_list static are local to the source,
so make them static.
Cleans up sparse warnings:
"symbol 'device_list' was not declared. Should it be static?"
"symbol 'device_mutex' was not declared. Should it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/target/target_core_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 3ae8fbf01bdf..bbcef3bc66c8 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -49,8 +49,8 @@
#include "target_core_pr.h"
#include "target_core_ua.h"
-DEFINE_MUTEX(device_mutex);
-LIST_HEAD(device_list);
+static DEFINE_MUTEX(device_mutex);
+static LIST_HEAD(device_list);
static DEFINE_IDR(devices_idr);
static struct se_hba *lun0_hba;
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] target: make device_mutex and device_list static
@ 2017-07-04 8:44 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2017-07-04 8:44 UTC (permalink / raw)
To: Nicholas A . Bellinger, linux-scsi, target-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variables device_mutex and device_list static are local to the source,
so make them static.
Cleans up sparse warnings:
"symbol 'device_list' was not declared. Should it be static?"
"symbol 'device_mutex' was not declared. Should it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/target/target_core_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 3ae8fbf01bdf..bbcef3bc66c8 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -49,8 +49,8 @@
#include "target_core_pr.h"
#include "target_core_ua.h"
-DEFINE_MUTEX(device_mutex);
-LIST_HEAD(device_list);
+static DEFINE_MUTEX(device_mutex);
+static LIST_HEAD(device_list);
static DEFINE_IDR(devices_idr);
static struct se_hba *lun0_hba;
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] target: make device_mutex and device_list static
2017-07-04 8:44 ` Colin King
@ 2017-07-05 18:15 ` Mike Christie
-1 siblings, 0 replies; 6+ messages in thread
From: Mike Christie @ 2017-07-05 18:15 UTC (permalink / raw)
To: Colin King, Nicholas A . Bellinger, linux-scsi, target-devel
Cc: kernel-janitors, linux-kernel
On 07/04/2017 03:44 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables device_mutex and device_list static are local to the source,
> so make them static.
>
> Cleans up sparse warnings:
> "symbol 'device_list' was not declared. Should it be static?"
> "symbol 'device_mutex' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/target/target_core_device.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
> index 3ae8fbf01bdf..bbcef3bc66c8 100644
> --- a/drivers/target/target_core_device.c
> +++ b/drivers/target/target_core_device.c
> @@ -49,8 +49,8 @@
> #include "target_core_pr.h"
> #include "target_core_ua.h"
>
> -DEFINE_MUTEX(device_mutex);
> -LIST_HEAD(device_list);
> +static DEFINE_MUTEX(device_mutex);
> +static LIST_HEAD(device_list);
> static DEFINE_IDR(devices_idr);
>
> static struct se_hba *lun0_hba;
>
My fault. Thanks.
Reviewed-by: Mike Christie <mchristi@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] target: make device_mutex and device_list static
@ 2017-07-05 18:15 ` Mike Christie
0 siblings, 0 replies; 6+ messages in thread
From: Mike Christie @ 2017-07-05 18:15 UTC (permalink / raw)
To: Colin King, Nicholas A . Bellinger, linux-scsi, target-devel
Cc: kernel-janitors, linux-kernel
On 07/04/2017 03:44 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables device_mutex and device_list static are local to the source,
> so make them static.
>
> Cleans up sparse warnings:
> "symbol 'device_list' was not declared. Should it be static?"
> "symbol 'device_mutex' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/target/target_core_device.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
> index 3ae8fbf01bdf..bbcef3bc66c8 100644
> --- a/drivers/target/target_core_device.c
> +++ b/drivers/target/target_core_device.c
> @@ -49,8 +49,8 @@
> #include "target_core_pr.h"
> #include "target_core_ua.h"
>
> -DEFINE_MUTEX(device_mutex);
> -LIST_HEAD(device_list);
> +static DEFINE_MUTEX(device_mutex);
> +static LIST_HEAD(device_list);
> static DEFINE_IDR(devices_idr);
>
> static struct se_hba *lun0_hba;
>
My fault. Thanks.
Reviewed-by: Mike Christie <mchristi@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] target: make device_mutex and device_list static
2017-07-05 18:15 ` Mike Christie
@ 2017-07-07 4:29 ` Nicholas A. Bellinger
-1 siblings, 0 replies; 6+ messages in thread
From: Nicholas A. Bellinger @ 2017-07-07 4:29 UTC (permalink / raw)
To: Mike Christie
Cc: Colin King, linux-scsi, target-devel, kernel-janitors, linux-kernel
On Wed, 2017-07-05 at 13:15 -0500, Mike Christie wrote:
> On 07/04/2017 03:44 AM, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Variables device_mutex and device_list static are local to the source,
> > so make them static.
> >
> > Cleans up sparse warnings:
> > "symbol 'device_list' was not declared. Should it be static?"
> > "symbol 'device_mutex' was not declared. Should it be static?"
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/target/target_core_device.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
> > index 3ae8fbf01bdf..bbcef3bc66c8 100644
> > --- a/drivers/target/target_core_device.c
> > +++ b/drivers/target/target_core_device.c
> > @@ -49,8 +49,8 @@
> > #include "target_core_pr.h"
> > #include "target_core_ua.h"
> >
> > -DEFINE_MUTEX(device_mutex);
> > -LIST_HEAD(device_list);
> > +static DEFINE_MUTEX(device_mutex);
> > +static LIST_HEAD(device_list);
> > static DEFINE_IDR(devices_idr);
> >
> > static struct se_hba *lun0_hba;
> >
>
> My fault. Thanks.
>
> Reviewed-by: Mike Christie <mchristi@redhat.com>
Applied.
Thanks Colin + MNC.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] target: make device_mutex and device_list static
@ 2017-07-07 4:29 ` Nicholas A. Bellinger
0 siblings, 0 replies; 6+ messages in thread
From: Nicholas A. Bellinger @ 2017-07-07 4:29 UTC (permalink / raw)
To: Mike Christie
Cc: Colin King, linux-scsi, target-devel, kernel-janitors, linux-kernel
On Wed, 2017-07-05 at 13:15 -0500, Mike Christie wrote:
> On 07/04/2017 03:44 AM, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Variables device_mutex and device_list static are local to the source,
> > so make them static.
> >
> > Cleans up sparse warnings:
> > "symbol 'device_list' was not declared. Should it be static?"
> > "symbol 'device_mutex' was not declared. Should it be static?"
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/target/target_core_device.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
> > index 3ae8fbf01bdf..bbcef3bc66c8 100644
> > --- a/drivers/target/target_core_device.c
> > +++ b/drivers/target/target_core_device.c
> > @@ -49,8 +49,8 @@
> > #include "target_core_pr.h"
> > #include "target_core_ua.h"
> >
> > -DEFINE_MUTEX(device_mutex);
> > -LIST_HEAD(device_list);
> > +static DEFINE_MUTEX(device_mutex);
> > +static LIST_HEAD(device_list);
> > static DEFINE_IDR(devices_idr);
> >
> > static struct se_hba *lun0_hba;
> >
>
> My fault. Thanks.
>
> Reviewed-by: Mike Christie <mchristi@redhat.com>
Applied.
Thanks Colin + MNC.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-07-07 4:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-04 8:44 [PATCH] target: make device_mutex and device_list static Colin King
2017-07-04 8:44 ` Colin King
2017-07-05 18:15 ` Mike Christie
2017-07-05 18:15 ` Mike Christie
2017-07-07 4:29 ` Nicholas A. Bellinger
2017-07-07 4:29 ` Nicholas A. Bellinger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.