From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: Intel-gfx@lists.freedesktop.org Cc: Matthew Brost <matthew.brost@intel.com>, John Harrison <John.C.Harrison@Intel.com>, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc: Log engine resets Date: Fri, 17 Dec 2021 12:15:53 +0000 [thread overview] Message-ID: <597d4ad0-fdae-49a6-b471-3a83d4c25b98@linux.intel.com> (raw) In-Reply-To: <20211214150704.984034-1-tvrtko.ursulin@linux.intel.com> On 14/12/2021 15:07, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Log engine resets done by the GuC firmware in the similar way it is done > by the execlists backend. > > This way we have notion of where the hangs are before the GuC gains > support for proper error capture. Ping - any interest to log this info? All there currently is a non-descriptive "[drm] GPU HANG: ecode 12:0:00000000". Also, will GuC be reporting the reason for the engine reset at any point? Regards, Tvrtko > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Cc: Matthew Brost <matthew.brost@intel.com> > Cc: John Harrison <John.C.Harrison@Intel.com> > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > index 97311119da6f..51512123dc1a 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > @@ -11,6 +11,7 @@ > #include "gt/intel_context.h" > #include "gt/intel_engine_pm.h" > #include "gt/intel_engine_heartbeat.h" > +#include "gt/intel_engine_user.h" > #include "gt/intel_gpu_commands.h" > #include "gt/intel_gt.h" > #include "gt/intel_gt_clock_utils.h" > @@ -3934,9 +3935,18 @@ static void capture_error_state(struct intel_guc *guc, > { > struct intel_gt *gt = guc_to_gt(guc); > struct drm_i915_private *i915 = gt->i915; > - struct intel_engine_cs *engine = __context_to_physical_engine(ce); > + struct intel_engine_cs *engine = ce->engine; > intel_wakeref_t wakeref; > > + if (intel_engine_is_virtual(engine)) { > + drm_notice(&i915->drm, "%s class, engines 0x%x; GuC engine reset\n", > + intel_engine_class_repr(engine->class), > + engine->mask); > + engine = guc_virtual_get_sibling(engine, 0); > + } else { > + drm_notice(&i915->drm, "%s GuC engine reset\n", engine->name); > + } > + > intel_engine_set_hung_context(engine, ce); > with_intel_runtime_pm(&i915->runtime_pm, wakeref) > i915_capture_error_state(gt, engine->mask); >
WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: Intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc: Log engine resets Date: Fri, 17 Dec 2021 12:15:53 +0000 [thread overview] Message-ID: <597d4ad0-fdae-49a6-b471-3a83d4c25b98@linux.intel.com> (raw) In-Reply-To: <20211214150704.984034-1-tvrtko.ursulin@linux.intel.com> On 14/12/2021 15:07, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Log engine resets done by the GuC firmware in the similar way it is done > by the execlists backend. > > This way we have notion of where the hangs are before the GuC gains > support for proper error capture. Ping - any interest to log this info? All there currently is a non-descriptive "[drm] GPU HANG: ecode 12:0:00000000". Also, will GuC be reporting the reason for the engine reset at any point? Regards, Tvrtko > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Cc: Matthew Brost <matthew.brost@intel.com> > Cc: John Harrison <John.C.Harrison@Intel.com> > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > index 97311119da6f..51512123dc1a 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > @@ -11,6 +11,7 @@ > #include "gt/intel_context.h" > #include "gt/intel_engine_pm.h" > #include "gt/intel_engine_heartbeat.h" > +#include "gt/intel_engine_user.h" > #include "gt/intel_gpu_commands.h" > #include "gt/intel_gt.h" > #include "gt/intel_gt_clock_utils.h" > @@ -3934,9 +3935,18 @@ static void capture_error_state(struct intel_guc *guc, > { > struct intel_gt *gt = guc_to_gt(guc); > struct drm_i915_private *i915 = gt->i915; > - struct intel_engine_cs *engine = __context_to_physical_engine(ce); > + struct intel_engine_cs *engine = ce->engine; > intel_wakeref_t wakeref; > > + if (intel_engine_is_virtual(engine)) { > + drm_notice(&i915->drm, "%s class, engines 0x%x; GuC engine reset\n", > + intel_engine_class_repr(engine->class), > + engine->mask); > + engine = guc_virtual_get_sibling(engine, 0); > + } else { > + drm_notice(&i915->drm, "%s GuC engine reset\n", engine->name); > + } > + > intel_engine_set_hung_context(engine, ce); > with_intel_runtime_pm(&i915->runtime_pm, wakeref) > i915_capture_error_state(gt, engine->mask); >
next prev parent reply other threads:[~2021-12-17 12:16 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-14 15:07 [PATCH] drm/i915/guc: Log engine resets Tvrtko Ursulin 2021-12-14 15:07 ` [Intel-gfx] " Tvrtko Ursulin 2021-12-14 16:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-12-14 22:25 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-12-17 12:15 ` Tvrtko Ursulin [this message] 2021-12-17 12:15 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2021-12-17 16:22 ` Matthew Brost 2021-12-17 16:22 ` Matthew Brost 2021-12-20 15:00 ` Tvrtko Ursulin 2021-12-20 15:00 ` Tvrtko Ursulin 2021-12-20 17:55 ` Matthew Brost 2021-12-20 17:55 ` Matthew Brost 2021-12-20 18:34 ` John Harrison 2021-12-21 13:37 ` Tvrtko Ursulin 2021-12-21 22:14 ` John Harrison 2021-12-22 16:21 ` Tvrtko Ursulin 2021-12-22 21:58 ` John Harrison 2021-12-23 10:23 ` Tvrtko Ursulin 2021-12-23 17:35 ` John Harrison 2021-12-24 11:57 ` Tvrtko Ursulin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=597d4ad0-fdae-49a6-b471-3a83d4c25b98@linux.intel.com \ --to=tvrtko.ursulin@linux.intel.com \ --cc=Intel-gfx@lists.freedesktop.org \ --cc=John.C.Harrison@Intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=matthew.brost@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.