* [net-next PATCH v2] net: comment fixes against BPF devmap helper calls
@ 2017-08-04 15:24 John Fastabend
2017-08-04 15:30 ` Daniel Borkmann
2017-08-04 18:29 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: John Fastabend @ 2017-08-04 15:24 UTC (permalink / raw)
To: davem, daniel, ast; +Cc: netdev
Update BPF comments to accurately reflect XDP usage.
Fixes: 97f91a7cf04ff ("bpf: add bpf_redirect_map helper routine")
Reported-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
---
include/uapi/linux/bpf.h | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
index 1106a8c..1d06be1 100644
--- a/include/uapi/linux/bpf.h
+++ b/include/uapi/linux/bpf.h
@@ -345,14 +345,20 @@ enum bpf_attach_type {
* int bpf_redirect(ifindex, flags)
* redirect to another netdev
* @ifindex: ifindex of the net device
- * @flags: bit 0 - if set, redirect to ingress instead of egress
- * other bits - reserved
- * Return: TC_ACT_REDIRECT
- * int bpf_redirect_map(key, map, flags)
+ * @flags:
+ * cls_bpf:
+ * bit 0 - if set, redirect to ingress instead of egress
+ * other bits - reserved
+ * xdp_bpf:
+ * all bits - reserved
+ * Return: cls_bpf: TC_ACT_REDIRECT on success or TC_ACT_SHOT on error
+ * xdp_bfp: XDP_REDIRECT on success or XDP_ABORT on error
+ * int bpf_redirect_map(map, key, flags)
* redirect to endpoint in map
+ * @map: pointer to dev map
* @key: index in map to lookup
- * @map: fd of map to do lookup in
* @flags: --
+ * Return: XDP_REDIRECT on success or XDP_ABORT on error
*
* u32 bpf_get_route_realm(skb)
* retrieve a dst's tclassid
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net-next PATCH v2] net: comment fixes against BPF devmap helper calls
2017-08-04 15:24 [net-next PATCH v2] net: comment fixes against BPF devmap helper calls John Fastabend
@ 2017-08-04 15:30 ` Daniel Borkmann
2017-08-04 18:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2017-08-04 15:30 UTC (permalink / raw)
To: John Fastabend, davem, ast; +Cc: netdev
On 08/04/2017 05:24 PM, John Fastabend wrote:
> Update BPF comments to accurately reflect XDP usage.
>
> Fixes: 97f91a7cf04ff ("bpf: add bpf_redirect_map helper routine")
> Reported-by: Alexei Starovoitov <ast@kernel.org>
> Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net-next PATCH v2] net: comment fixes against BPF devmap helper calls
2017-08-04 15:24 [net-next PATCH v2] net: comment fixes against BPF devmap helper calls John Fastabend
2017-08-04 15:30 ` Daniel Borkmann
@ 2017-08-04 18:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-08-04 18:29 UTC (permalink / raw)
To: john.fastabend; +Cc: daniel, ast, netdev
From: John Fastabend <john.fastabend@gmail.com>
Date: Fri, 04 Aug 2017 08:24:05 -0700
> Update BPF comments to accurately reflect XDP usage.
>
> Fixes: 97f91a7cf04ff ("bpf: add bpf_redirect_map helper routine")
> Reported-by: Alexei Starovoitov <ast@kernel.org>
> Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-04 18:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-04 15:24 [net-next PATCH v2] net: comment fixes against BPF devmap helper calls John Fastabend
2017-08-04 15:30 ` Daniel Borkmann
2017-08-04 18:29 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.