All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: balbi@kernel.org
Cc: kishon@ti.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
	chanwoo@kernel.org, myungjoo.ham@samsung.com,
	Raviteja Garimella <raviteja.garimella@broadcom.com>
Subject: Re: [PATCH v2 4/5] usb: gadget: udc: Replace the deprecated extcon API
Date: Mon, 07 Aug 2017 11:07:21 +0900	[thread overview]
Message-ID: <5987CB59.9070008@samsung.com> (raw)
In-Reply-To: <1501748448-26821-5-git-send-email-cw00.choi@samsung.com>

Dear Felipe,

Could you please review this patch?
I hope to remove the deprecated extcon API.

Regards,
Chanwoo Choi

On 2017년 08월 03일 17:20, Chanwoo Choi wrote:
> This patch replaces the deprecated extcon API as following:
> - extcon_get_cable_state_() -> extcon_get_state()
> 
> Cc: Felipe Balbi <balbi@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Raviteja Garimella <raviteja.garimella@broadcom.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  drivers/usb/gadget/udc/snps_udc_plat.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadget/udc/snps_udc_plat.c
> index 2e11f19e07ae..0ce7b3ba60ff 100644
> --- a/drivers/usb/gadget/udc/snps_udc_plat.c
> +++ b/drivers/usb/gadget/udc/snps_udc_plat.c
> @@ -184,7 +184,7 @@ static int udc_plat_probe(struct platform_device *pdev)
>  			goto exit_phy;
>  		}
>  
> -		ret = extcon_get_cable_state_(udc->edev, EXTCON_USB);
> +		ret = extcon_get_state(udc->edev, EXTCON_USB);
>  		if (ret < 0) {
>  			dev_err(dev, "Can't get cable state\n");
>  			goto exit_extcon;
> @@ -273,7 +273,7 @@ static int udc_plat_suspend(struct device *dev)
>  	udc = dev_get_drvdata(dev);
>  	stop_udc(udc);
>  
> -	if (extcon_get_cable_state_(udc->edev, EXTCON_USB) > 0) {
> +	if (extcon_get_state(udc->edev, EXTCON_USB) > 0) {
>  		dev_dbg(udc->dev, "device -> idle\n");
>  		stop_udc(udc);
>  	}
> @@ -303,7 +303,7 @@ static int udc_plat_resume(struct device *dev)
>  		return ret;
>  	}
>  
> -	if (extcon_get_cable_state_(udc->edev, EXTCON_USB) > 0) {
> +	if (extcon_get_state(udc->edev, EXTCON_USB) > 0) {
>  		dev_dbg(udc->dev, "idle -> device\n");
>  		start_udc(udc);
>  	}
> 

WARNING: multiple messages have this Message-ID (diff)
From: cw00.choi@samsung.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/5] usb: gadget: udc: Replace the deprecated extcon API
Date: Mon, 07 Aug 2017 11:07:21 +0900	[thread overview]
Message-ID: <5987CB59.9070008@samsung.com> (raw)
In-Reply-To: <1501748448-26821-5-git-send-email-cw00.choi@samsung.com>

Dear Felipe,

Could you please review this patch?
I hope to remove the deprecated extcon API.

Regards,
Chanwoo Choi

On 2017? 08? 03? 17:20, Chanwoo Choi wrote:
> This patch replaces the deprecated extcon API as following:
> - extcon_get_cable_state_() -> extcon_get_state()
> 
> Cc: Felipe Balbi <balbi@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Raviteja Garimella <raviteja.garimella@broadcom.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  drivers/usb/gadget/udc/snps_udc_plat.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadget/udc/snps_udc_plat.c
> index 2e11f19e07ae..0ce7b3ba60ff 100644
> --- a/drivers/usb/gadget/udc/snps_udc_plat.c
> +++ b/drivers/usb/gadget/udc/snps_udc_plat.c
> @@ -184,7 +184,7 @@ static int udc_plat_probe(struct platform_device *pdev)
>  			goto exit_phy;
>  		}
>  
> -		ret = extcon_get_cable_state_(udc->edev, EXTCON_USB);
> +		ret = extcon_get_state(udc->edev, EXTCON_USB);
>  		if (ret < 0) {
>  			dev_err(dev, "Can't get cable state\n");
>  			goto exit_extcon;
> @@ -273,7 +273,7 @@ static int udc_plat_suspend(struct device *dev)
>  	udc = dev_get_drvdata(dev);
>  	stop_udc(udc);
>  
> -	if (extcon_get_cable_state_(udc->edev, EXTCON_USB) > 0) {
> +	if (extcon_get_state(udc->edev, EXTCON_USB) > 0) {
>  		dev_dbg(udc->dev, "device -> idle\n");
>  		stop_udc(udc);
>  	}
> @@ -303,7 +303,7 @@ static int udc_plat_resume(struct device *dev)
>  		return ret;
>  	}
>  
> -	if (extcon_get_cable_state_(udc->edev, EXTCON_USB) > 0) {
> +	if (extcon_get_state(udc->edev, EXTCON_USB) > 0) {
>  		dev_dbg(udc->dev, "idle -> device\n");
>  		start_udc(udc);
>  	}
> 

  reply	other threads:[~2017-08-07  2:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170803082049epcas1p3ca6cb415ce40b24fa360f7155ea0829c@epcas1p3.samsung.com>
2017-08-03  8:20 ` [PATCH v2 0/5] usb: Replace the deprecated extcon API Chanwoo Choi
2017-08-03  8:20   ` Chanwoo Choi
     [not found]   ` <CGME20170803082050epcas1p2d72847ff1a6c31a9ba281daeecd17b18@epcas1p2.samsung.com>
2017-08-03  8:20     ` [PATCH v2 1/5] phy: qcom-usb-hs: Replace the " Chanwoo Choi
2017-08-03  8:20       ` Chanwoo Choi
     [not found]   ` <CGME20170803082050epcas1p3040420e1fef2186519f50a68f865e006@epcas1p3.samsung.com>
2017-08-03  8:20     ` [PATCH v2 2/5] phy: rockchip-inno-usb2: " Chanwoo Choi
2017-08-03  8:20       ` Chanwoo Choi
     [not found]   ` <CGME20170803082050epcas1p179818a40e214e4ab5884f8a3bca657f8@epcas1p1.samsung.com>
2017-08-03  8:20     ` [PATCH v2 3/5] phy: phy-bcm-ns2-usbdrd: Replace the deprecated " Chanwoo Choi
2017-08-03  8:20       ` Chanwoo Choi
     [not found]   ` <CGME20170803082050epcas1p2491eedf2f26510f55cd15ce777356fce@epcas1p2.samsung.com>
2017-08-03  8:20     ` [PATCH v2 4/5] usb: gadget: udc: " Chanwoo Choi
2017-08-03  8:20       ` Chanwoo Choi
2017-08-07  2:07       ` Chanwoo Choi [this message]
2017-08-07  2:07         ` Chanwoo Choi
2017-08-10  0:09         ` Chanwoo Choi
2017-08-10  0:09           ` Chanwoo Choi
2017-08-15  9:48       ` Felipe Balbi
2017-08-15  9:48         ` Felipe Balbi
2017-08-16  0:19         ` Chanwoo Choi
2017-08-16  0:19           ` Chanwoo Choi
     [not found]   ` <CGME20170803082050epcas1p38d70b5df911a855708c891b659a56fce@epcas1p3.samsung.com>
2017-08-03  8:20     ` [PATCH v2 5/5] extcon: Remove deprecated extcon_set/get_cable_state_() Chanwoo Choi
2017-08-03  8:20       ` Chanwoo Choi
2017-08-16  1:52   ` [PATCH v2 0/5] usb: Replace the deprecated extcon API Chanwoo Choi
2017-08-16  1:52     ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5987CB59.9070008@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=balbi@kernel.org \
    --cc=chanwoo@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=raviteja.garimella@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.