From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc: Avi Fishman <avifishman70@gmail.com>,
Tomer Maimon <tmaimon77@gmail.com>,
Tali Perry <tali.perry1@gmail.com>,
Patrick Venture <venture@google.com>,
Nancy Yuen <yuenn@google.com>,
Benjamin Fair <benjaminfair@google.com>,
Russell King <linux@armlinux.org.uk>,
openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
Brendan Higgins <brendan.higgins@linux.dev>
Subject: Re: [PATCH] ARM: npcm: remove select of non-existant ERRATA
Date: Wed, 22 Mar 2023 08:50:32 +0100 [thread overview]
Message-ID: <59886f87-c277-5917-a521-5893ab75acee@molgen.mpg.de> (raw)
In-Reply-To: <20230316204749.19902-1-r.czerwinski@pengutronix.de>
Dear Rouven,
Thank you for your patch.
Am 16.03.23 um 21:47 schrieb Rouven Czerwinski:
There is a small typo in the commit message summary/title:
non-exist*e*nt. Maybe also mention the errata number:
ARM: npcm: Remove select of non-existent ARM_ERRATA_794072
> config ARCH_NPCM7XX selects ARM_ERRATA_794072, however this config
> option does not exist since the workaround for the errata requires
> secure mode access which needs to be run by the bootloader or firmware
> since linux can't determine whether it is running in secure mode.
Please add a Fixes: tag.
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
> arch/arm/mach-npcm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-npcm/Kconfig b/arch/arm/mach-npcm/Kconfig
> index 63b42a19d1b8..d933e8abb50f 100644
> --- a/arch/arm/mach-npcm/Kconfig
> +++ b/arch/arm/mach-npcm/Kconfig
> @@ -30,7 +30,6 @@ config ARCH_NPCM7XX
> select ARM_ERRATA_764369 if SMP
> select ARM_ERRATA_720789
> select ARM_ERRATA_754322
> - select ARM_ERRATA_794072
> select PL310_ERRATA_588369
> select PL310_ERRATA_727915
> select MFD_SYSCON
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
WARNING: multiple messages have this Message-ID (diff)
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
Benjamin Fair <benjaminfair@google.com>,
Brendan Higgins <brendan.higgins@linux.dev>,
Avi Fishman <avifishman70@gmail.com>,
Patrick Venture <venture@google.com>,
openbmc@lists.ozlabs.org, Russell King <linux@armlinux.org.uk>,
Tali Perry <tali.perry1@gmail.com>,
kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
Tomer Maimon <tmaimon77@gmail.com>
Subject: Re: [PATCH] ARM: npcm: remove select of non-existant ERRATA
Date: Wed, 22 Mar 2023 08:50:32 +0100 [thread overview]
Message-ID: <59886f87-c277-5917-a521-5893ab75acee@molgen.mpg.de> (raw)
In-Reply-To: <20230316204749.19902-1-r.czerwinski@pengutronix.de>
Dear Rouven,
Thank you for your patch.
Am 16.03.23 um 21:47 schrieb Rouven Czerwinski:
There is a small typo in the commit message summary/title:
non-exist*e*nt. Maybe also mention the errata number:
ARM: npcm: Remove select of non-existent ARM_ERRATA_794072
> config ARCH_NPCM7XX selects ARM_ERRATA_794072, however this config
> option does not exist since the workaround for the errata requires
> secure mode access which needs to be run by the bootloader or firmware
> since linux can't determine whether it is running in secure mode.
Please add a Fixes: tag.
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
> arch/arm/mach-npcm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-npcm/Kconfig b/arch/arm/mach-npcm/Kconfig
> index 63b42a19d1b8..d933e8abb50f 100644
> --- a/arch/arm/mach-npcm/Kconfig
> +++ b/arch/arm/mach-npcm/Kconfig
> @@ -30,7 +30,6 @@ config ARCH_NPCM7XX
> select ARM_ERRATA_764369 if SMP
> select ARM_ERRATA_720789
> select ARM_ERRATA_754322
> - select ARM_ERRATA_794072
> select PL310_ERRATA_588369
> select PL310_ERRATA_727915
> select MFD_SYSCON
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
WARNING: multiple messages have this Message-ID (diff)
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc: Avi Fishman <avifishman70@gmail.com>,
Tomer Maimon <tmaimon77@gmail.com>,
Tali Perry <tali.perry1@gmail.com>,
Patrick Venture <venture@google.com>,
Nancy Yuen <yuenn@google.com>,
Benjamin Fair <benjaminfair@google.com>,
Russell King <linux@armlinux.org.uk>,
openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
Brendan Higgins <brendan.higgins@linux.dev>
Subject: Re: [PATCH] ARM: npcm: remove select of non-existant ERRATA
Date: Wed, 22 Mar 2023 08:50:32 +0100 [thread overview]
Message-ID: <59886f87-c277-5917-a521-5893ab75acee@molgen.mpg.de> (raw)
In-Reply-To: <20230316204749.19902-1-r.czerwinski@pengutronix.de>
Dear Rouven,
Thank you for your patch.
Am 16.03.23 um 21:47 schrieb Rouven Czerwinski:
There is a small typo in the commit message summary/title:
non-exist*e*nt. Maybe also mention the errata number:
ARM: npcm: Remove select of non-existent ARM_ERRATA_794072
> config ARCH_NPCM7XX selects ARM_ERRATA_794072, however this config
> option does not exist since the workaround for the errata requires
> secure mode access which needs to be run by the bootloader or firmware
> since linux can't determine whether it is running in secure mode.
Please add a Fixes: tag.
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
> arch/arm/mach-npcm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-npcm/Kconfig b/arch/arm/mach-npcm/Kconfig
> index 63b42a19d1b8..d933e8abb50f 100644
> --- a/arch/arm/mach-npcm/Kconfig
> +++ b/arch/arm/mach-npcm/Kconfig
> @@ -30,7 +30,6 @@ config ARCH_NPCM7XX
> select ARM_ERRATA_764369 if SMP
> select ARM_ERRATA_720789
> select ARM_ERRATA_754322
> - select ARM_ERRATA_794072
> select PL310_ERRATA_588369
> select PL310_ERRATA_727915
> select MFD_SYSCON
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-22 7:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 20:47 [PATCH] ARM: npcm: remove select of non-existant ERRATA Rouven Czerwinski
2023-03-16 20:47 ` Rouven Czerwinski
2023-03-16 20:47 ` Rouven Czerwinski
2023-03-22 7:50 ` Paul Menzel [this message]
2023-03-22 7:50 ` Paul Menzel
2023-03-22 7:50 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59886f87-c277-5917-a521-5893ab75acee@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=brendan.higgins@linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=openbmc@lists.ozlabs.org \
--cc=r.czerwinski@pengutronix.de \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.