From: James Morse <james.morse-5wv7dgnIgG8@public.gmane.org> To: Dave Martin <Dave.Martin-5wv7dgnIgG8@public.gmane.org> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>, Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>, Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, kvmarm-FPEHb7Xf0XXUo1n7N8X6UoWGPAHP3yOg@public.gmane.org, Christoffer Dall <christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Subject: Re: [PATCH 07/11] firmware: arm_sdei: Add driver for Software Delegated Exceptions Date: Tue, 08 Aug 2017 17:48:01 +0100 [thread overview] Message-ID: <5989EB41.10909@arm.com> (raw) In-Reply-To: <20170719135213.GA1538-M5GwZQ6tE7x5pKCnmE3YQBJ8xKzm50AiAL8bYrjMMd8@public.gmane.org> Hi Dave, On 19/07/17 14:52, Dave Martin wrote: > On Mon, May 15, 2017 at 06:43:55PM +0100, James Morse wrote: >> The Software Delegated Exception Interface (SDEI) is an ARM standard >> for registering callbacks from the platform firmware into the OS. >> This is typically used to implement RAS notifications. >> >> Add the code for detecting the SDEI version and the framework for >> registering and unregistering events. Subsequent patches will add the >> arch-specific backend code and the necessary power management hooks. >> >> Currently only shared events are supported. >> diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c >> new file mode 100644 >> index 000000000000..d22dda5e0fed >> --- /dev/null >> +++ b/drivers/firmware/arm_sdei.c >> +int sdei_mask_local_cpu(unsigned int cpu) >> +{ >> + int err; >> + struct arm_smccc_res res; >> + >> + WARN_ON(preemptible()); >> + err = invoke_sdei_fn(&res, SDEI_1_0_FN_SDEI_PE_MASK, 0, 0, 0, 0, 0); > It seems awkward to have to declare res repeatedly when it's basically > unused. Several callsites seem to do this. Out of context, this looks > bug-like (though it's not a bug). After a quick trawl, only the 'qcom' and 'optee' callers use regs other than x0. > Could we make it explicit that the results other than x0 are unwanted by > passing NULL instead? Looks straightforward, the quirk buffer has the same behaviour. I will put something together. > invoke_sdei_fn (or some downstream function) could declare its own res > for this case, but at least we'd only have to do that in one place. > arm_smccc_smc() and friends (at least the C interface in the headers) > could do something similar. Yes, for SDEI I can reduce this weirdness by moving smccc_res up a level. Thanks, James -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: james.morse@arm.com (James Morse) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 07/11] firmware: arm_sdei: Add driver for Software Delegated Exceptions Date: Tue, 08 Aug 2017 17:48:01 +0100 [thread overview] Message-ID: <5989EB41.10909@arm.com> (raw) In-Reply-To: <20170719135213.GA1538@e103592.cambridge.arm.com> Hi Dave, On 19/07/17 14:52, Dave Martin wrote: > On Mon, May 15, 2017 at 06:43:55PM +0100, James Morse wrote: >> The Software Delegated Exception Interface (SDEI) is an ARM standard >> for registering callbacks from the platform firmware into the OS. >> This is typically used to implement RAS notifications. >> >> Add the code for detecting the SDEI version and the framework for >> registering and unregistering events. Subsequent patches will add the >> arch-specific backend code and the necessary power management hooks. >> >> Currently only shared events are supported. >> diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c >> new file mode 100644 >> index 000000000000..d22dda5e0fed >> --- /dev/null >> +++ b/drivers/firmware/arm_sdei.c >> +int sdei_mask_local_cpu(unsigned int cpu) >> +{ >> + int err; >> + struct arm_smccc_res res; >> + >> + WARN_ON(preemptible()); >> + err = invoke_sdei_fn(&res, SDEI_1_0_FN_SDEI_PE_MASK, 0, 0, 0, 0, 0); > It seems awkward to have to declare res repeatedly when it's basically > unused. Several callsites seem to do this. Out of context, this looks > bug-like (though it's not a bug). After a quick trawl, only the 'qcom' and 'optee' callers use regs other than x0. > Could we make it explicit that the results other than x0 are unwanted by > passing NULL instead? Looks straightforward, the quirk buffer has the same behaviour. I will put something together. > invoke_sdei_fn (or some downstream function) could declare its own res > for this case, but at least we'd only have to do that in one place. > arm_smccc_smc() and friends (at least the C interface in the headers) > could do something similar. Yes, for SDEI I can reduce this weirdness by moving smccc_res up a level. Thanks, James
next prev parent reply other threads:[~2017-08-08 16:48 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-15 17:43 [PATCH 00/11] arm64/firmware: Software Delegated Exception Interface James Morse 2017-05-15 17:43 ` James Morse 2017-05-15 17:43 ` [PATCH 01/11] KVM: arm64: Store vcpu on the stack during __guest_enter() James Morse 2017-05-15 17:43 ` James Morse [not found] ` <20170515174400.29735-2-james.morse-5wv7dgnIgG8@public.gmane.org> 2017-06-06 19:59 ` Christoffer Dall 2017-06-06 19:59 ` Christoffer Dall 2017-08-08 16:48 ` James Morse 2017-08-08 16:48 ` James Morse [not found] ` <5989EB5D.6-5wv7dgnIgG8@public.gmane.org> 2017-08-09 8:48 ` Christoffer Dall 2017-08-09 8:48 ` Christoffer Dall [not found] ` <20170515174400.29735-1-james.morse-5wv7dgnIgG8@public.gmane.org> 2017-05-15 17:43 ` [PATCH 02/11] KVM: arm/arm64: Convert kvm_host_cpu_state to a static per-cpu allocation James Morse 2017-05-15 17:43 ` James Morse [not found] ` <20170515174400.29735-3-james.morse-5wv7dgnIgG8@public.gmane.org> 2017-06-06 19:59 ` Christoffer Dall 2017-06-06 19:59 ` Christoffer Dall 2017-05-15 17:43 ` [PATCH 03/11] KVM: arm64: Change hyp_panic()s dependency on tpidr_el2 James Morse 2017-05-15 17:43 ` James Morse 2017-06-06 19:45 ` Christoffer Dall 2017-06-06 19:45 ` Christoffer Dall 2017-06-08 10:23 ` James Morse 2017-06-08 10:23 ` James Morse [not found] ` <593925BB.30503-5wv7dgnIgG8@public.gmane.org> 2017-06-08 10:34 ` Christoffer Dall 2017-06-08 10:34 ` Christoffer Dall 2017-05-15 17:43 ` [PATCH 04/11] arm64: alternatives: use tpidr_el2 on VHE hosts James Morse 2017-05-15 17:43 ` James Morse 2017-05-15 17:43 ` [PATCH 06/11] dt-bindings: add devicetree binding for describing arm64 SDEI firmware James Morse 2017-05-15 17:43 ` James Morse 2017-05-19 1:48 ` Rob Herring 2017-05-19 1:48 ` Rob Herring 2017-06-07 8:28 ` James Morse 2017-06-07 8:28 ` James Morse 2017-05-15 17:43 ` [PATCH 08/11] arm64: kernel: Add arch-specific SDEI entry code and CPU masking James Morse 2017-05-15 17:43 ` James Morse 2017-05-15 17:43 ` [PATCH 09/11] firmware: arm_sdei: Add support for CPU and system power states James Morse 2017-05-15 17:43 ` James Morse 2017-05-15 17:43 ` [PATCH 10/11] firmware: arm_sdei: add support for CPU private events James Morse 2017-05-15 17:43 ` James Morse 2017-05-15 17:43 ` [PATCH 11/11] KVM: arm64: Delegate support for SDEI to userspace James Morse 2017-05-15 17:43 ` James Morse [not found] ` <20170515174400.29735-12-james.morse-5wv7dgnIgG8@public.gmane.org> 2017-06-06 19:58 ` Christoffer Dall 2017-06-06 19:58 ` Christoffer Dall 2017-07-26 17:00 ` James Morse 2017-07-26 17:00 ` James Morse [not found] ` <5978CA93.5090600-5wv7dgnIgG8@public.gmane.org> 2017-07-27 7:49 ` Christoffer Dall 2017-07-27 7:49 ` Christoffer Dall 2017-06-06 19:59 ` [PATCH 00/11] arm64/firmware: Software Delegated Exception Interface Christoffer Dall 2017-06-06 19:59 ` Christoffer Dall 2017-06-07 9:45 ` James Morse 2017-06-07 9:45 ` James Morse 2017-06-07 9:53 ` Christoffer Dall 2017-06-07 9:53 ` Christoffer Dall 2017-05-15 17:43 ` [PATCH 05/11] arm64: KVM: Stop save/restoring host tpidr_el1 on VHE James Morse 2017-05-15 17:43 ` James Morse [not found] ` <20170515174400.29735-6-james.morse-5wv7dgnIgG8@public.gmane.org> 2017-06-06 20:00 ` Christoffer Dall 2017-06-06 20:00 ` Christoffer Dall 2017-05-15 17:43 ` [PATCH 07/11] firmware: arm_sdei: Add driver for Software Delegated Exceptions James Morse 2017-05-15 17:43 ` James Morse [not found] ` <20170515174400.29735-8-james.morse-5wv7dgnIgG8@public.gmane.org> 2017-07-19 13:52 ` Dave Martin 2017-07-19 13:52 ` Dave Martin [not found] ` <20170719135213.GA1538-M5GwZQ6tE7x5pKCnmE3YQBJ8xKzm50AiAL8bYrjMMd8@public.gmane.org> 2017-08-08 16:48 ` James Morse [this message] 2017-08-08 16:48 ` James Morse
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5989EB41.10909@arm.com \ --to=james.morse-5wv7dgnigg8@public.gmane.org \ --cc=Dave.Martin-5wv7dgnIgG8@public.gmane.org \ --cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \ --cc=christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=kvmarm-FPEHb7Xf0XXUo1n7N8X6UoWGPAHP3yOg@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=marc.zyngier-5wv7dgnIgG8@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.