[LTP] [PATCH] syscalls/access01: Set umask value before run case

[LTP] [PATCH] syscalls/access01: Set umask value before run case

[Bixuan Cui]

The case will fail when set the umask to 0077 acquiescently in system.
Because the value of actual mode is 'set value' & ~'default value
for the umask' when create dir.
So add 'umask(0022)' in setup().

Signed-off-by: Cui Bixuan <cuibixuan@huawei.com>
---
 testcases/kernel/syscalls/access/access01.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/testcases/kernel/syscalls/access/access01.c b/testcases/kernel/syscalls/access/access01.c
index 7a92525..b679832 100644
--- a/testcases/kernel/syscalls/access/access01.c
+++ b/testcases/kernel/syscalls/access/access01.c
@@ -315,6 +315,8 @@ static void setup(void)
 {
 	struct passwd *pw;

+	umask(0022);
+
 	pw = SAFE_GETPWNAM("nobody");

 	uid = pw->pw_uid;
--
2.6.2

[LTP] [PATCH] syscalls/access01: Set umask value before run case

[Jan Stancek]

----- Original Message -----
> The case will fail when set the umask to 0077 acquiescently in system.
> Because the value of actual mode is 'set value' & ~'default value
> for the umask' when create dir.
> So add 'umask(0022)' in setup().

We do umask(0) in ltp-pan:

# umask
0077

# /opt/ltp/runltp -p -d results -l RUNTEST.log -o RUNTEST.run.log -s access01 -f syscalls > /dev/null

# cat /opt/ltp/results/RUNTEST.log
Test Start Time: Fri Sep 22 14:24:28 2017
-----------------------------------------
Testcase                       Result     Exit Value
--------                       ------     ----------
access01                       PASS       0    

I'm aware that running tests outside of ltp-pan is sometimes useful,
so maybe we could add this to a library rather than in each test
separately? What do you think Cyril?

Regards,
Jan

[LTP] [PATCH] syscalls/access01: Set umask value before run case

[Bixuan Cui]

On 2017/9/22 20:28, Jan Stancek wrote:
> 
> 
> ----- Original Message -----
>> The case will fail when set the umask to 0077 acquiescently in system.
>> Because the value of actual mode is 'set value' & ~'default value
>> for the umask' when create dir.
>> So add 'umask(0022)' in setup().
> 
> We do umask(0) in ltp-pan:
> 
> # umask
> 0077
> 
> # /opt/ltp/runltp -p -d results -l RUNTEST.log -o RUNTEST.run.log -s access01 -f syscalls > /dev/null
> 
> # cat /opt/ltp/results/RUNTEST.log
> Test Start Time: Fri Sep 22 14:24:28 2017
> -----------------------------------------
> Testcase                       Result     Exit Value
> --------                       ------     ----------
> access01                       PASS       0    
> 
> I'm aware that running tests outside of ltp-pan is sometimes useful,
> so maybe we could add this to a library rather than in each test
> separately? What do you think Cyril?
Yes, I shouldn't run it without runltp script.

Thanks,
Bixuan Cui
> 
> Regards,
> Jan
> 
> 

[LTP] [PATCH] syscalls/access01: Set umask value before run case

[Cyril Hrubis]

Hi!
> We do umask(0) in ltp-pan:
> 
> # umask
> 0077
> 
> # /opt/ltp/runltp -p -d results -l RUNTEST.log -o RUNTEST.run.log -s access01 -f syscalls > /dev/null
> 
> # cat /opt/ltp/results/RUNTEST.log
> Test Start Time: Fri Sep 22 14:24:28 2017
> -----------------------------------------
> Testcase                       Result     Exit Value
> --------                       ------     ----------
> access01                       PASS       0    
> 
> I'm aware that running tests outside of ltp-pan is sometimes useful,
> so maybe we could add this to a library rather than in each test
> separately? What do you think Cyril?

Running tests outside ltp-pan should indeed possible but I'm not sure
that we want to change the umask in the test library. Most of the
testcases will run with the more restrictive umask just fine and I would
rather test the system in the default configuration. So changing it in
the test setup in this case sounds reasonable to me.

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] [PATCH] syscalls/access01: Set umask value before run case

[Jan Stancek]

----- Original Message -----
> Hi!
> > We do umask(0) in ltp-pan:
> > 
> > # umask
> > 0077
> > 
> > # /opt/ltp/runltp -p -d results -l RUNTEST.log -o RUNTEST.run.log -s
> > access01 -f syscalls > /dev/null
> > 
> > # cat /opt/ltp/results/RUNTEST.log
> > Test Start Time: Fri Sep 22 14:24:28 2017
> > -----------------------------------------
> > Testcase                       Result     Exit Value
> > --------                       ------     ----------
> > access01                       PASS       0
> > 
> > I'm aware that running tests outside of ltp-pan is sometimes useful,
> > so maybe we could add this to a library rather than in each test
> > separately? What do you think Cyril?
> 
> Running tests outside ltp-pan should indeed possible but I'm not sure
> that we want to change the umask in the test library. Most of the
> testcases will run with the more restrictive umask just fine and I would
> rather test the system in the default configuration. So changing it in
> the test setup in this case sounds reasonable to me.

OK, Will you push the patch?

Regards,
Jan

[LTP] [PATCH] syscalls/access01: Set umask value before run case

[Cyril Hrubis]

Hi!
I've reworded the commit message and pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] [PATCH] syscalls/access01: Set umask value before run case

[Cyril Hrubis]

Hi!
> OK, Will you push the patch?

Done.

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] [PATCH] syscalls/access01: Set umask value before run case

[Bixuan Cui]

On 2017/10/3 23:52, Cyril Hrubis wrote:
> Hi!
> I've reworded the commit message and pushed, thanks.

Thanks,
Bixuan Cui

>