From: Wei Wang <wei.w.wang@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"mhocko@kernel.org" <mhocko@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mawilcox@microsoft.com" <mawilcox@microsoft.com>,
"david@redhat.com" <david@redhat.com>,
"cornelia.huck@de.ibm.com" <cornelia.huck@de.ibm.com>,
"mgorman@techsingularity.net" <mgorman@techsingularity.net>,
"aarcange@redhat.com" <aarcange@redhat.com>,
"amit.shah@redhat.com" <amit.shah@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"willy@infradead.org" <willy@infradead.org>,
"liliang.opensource@gmail.com" <liliang.opensource@gmail.com>,
"yang.zhang.wz@gmail.com" <yang.zhang.wz@gmail.com>,
"quan.xu@aliyun.com" <quan.xu@aliyun.com>
Subject: Re: [PATCH v16 5/5] virtio-balloon: VIRTIO_BALLOON_F_CTRL_VQ
Date: Thu, 19 Oct 2017 16:07:06 +0800 [thread overview]
Message-ID: <59E85D2A.1060407@intel.com> (raw)
In-Reply-To: <20171013163503-mutt-send-email-mst@kernel.org>
On 10/13/2017 09:38 PM, Michael S. Tsirkin wrote:
> On Thu, Oct 12, 2017 at 11:54:56AM +0800, Wei Wang wrote:
>>> But I think flushing is very fragile. You will easily run into races
>>> if one of the actors gets out of sync and keeps adding data.
>>> I think adding an ID in the free vq stream is a more robust
>>> approach.
>>>
>> Adding ID to the free vq would need the device to distinguish whether it
>> receives an ID or a free page hint,
> Not really. It's pretty simple: a 64 bit buffer is an ID. A 4K and bigger one
> is a page.
I think we can also use the previous method, free page via in_buf, and
id via out_buf.
Best,
Wei
WARNING: multiple messages have this Message-ID (diff)
From: Wei Wang <wei.w.wang@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"mhocko@kernel.org" <mhocko@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mawilcox@microsoft.com" <mawilcox@microsoft.com>,
"david@redhat.com" <david@redhat.com>,
"cornelia.huck@de.ibm.com" <cornelia.huck@de.ibm.com>,
"mgorman@techsingularity.net" <mgorman@techsingularity.net>,
"aarcange@redhat.com" <aarcange@redhat.com>,
"amit.shah@redhat.com" <amit.shah@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"willy@infradead.org" <willy@infradead.org>,
"liliang.opensource@gmail.co
Subject: Re: [PATCH v16 5/5] virtio-balloon: VIRTIO_BALLOON_F_CTRL_VQ
Date: Thu, 19 Oct 2017 16:07:06 +0800 [thread overview]
Message-ID: <59E85D2A.1060407@intel.com> (raw)
In-Reply-To: <20171013163503-mutt-send-email-mst@kernel.org>
On 10/13/2017 09:38 PM, Michael S. Tsirkin wrote:
> On Thu, Oct 12, 2017 at 11:54:56AM +0800, Wei Wang wrote:
>>> But I think flushing is very fragile. You will easily run into races
>>> if one of the actors gets out of sync and keeps adding data.
>>> I think adding an ID in the free vq stream is a more robust
>>> approach.
>>>
>> Adding ID to the free vq would need the device to distinguish whether it
>> receives an ID or a free page hint,
> Not really. It's pretty simple: a 64 bit buffer is an ID. A 4K and bigger one
> is a page.
I think we can also use the previous method, free page via in_buf, and
id via out_buf.
Best,
Wei
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Wei Wang <wei.w.wang@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"mhocko@kernel.org" <mhocko@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mawilcox@microsoft.com" <mawilcox@microsoft.com>,
"david@redhat.com" <david@redhat.com>,
"cornelia.huck@de.ibm.com" <cornelia.huck@de.ibm.com>,
"mgorman@techsingularity.net" <mgorman@techsingularity.net>,
"aarcange@redhat.com" <aarcange@redhat.com>,
"amit.shah@redhat.com" <amit.shah@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"willy@infradead.org" <willy@infradead.org>,
"liliang.opensource@gmail.com" <liliang.opensource@gmail.com>,
"yang.zhang.wz@gmail.com" <yang.zhang.wz@gmail.com>,
"quan.xu@aliyun.com" <quan.xu@aliyun.com>
Subject: Re: [PATCH v16 5/5] virtio-balloon: VIRTIO_BALLOON_F_CTRL_VQ
Date: Thu, 19 Oct 2017 16:07:06 +0800 [thread overview]
Message-ID: <59E85D2A.1060407@intel.com> (raw)
In-Reply-To: <20171013163503-mutt-send-email-mst@kernel.org>
On 10/13/2017 09:38 PM, Michael S. Tsirkin wrote:
> On Thu, Oct 12, 2017 at 11:54:56AM +0800, Wei Wang wrote:
>>> But I think flushing is very fragile. You will easily run into races
>>> if one of the actors gets out of sync and keeps adding data.
>>> I think adding an ID in the free vq stream is a more robust
>>> approach.
>>>
>> Adding ID to the free vq would need the device to distinguish whether it
>> receives an ID or a free page hint,
> Not really. It's pretty simple: a 64 bit buffer is an ID. A 4K and bigger one
> is a page.
I think we can also use the previous method, free page via in_buf, and
id via out_buf.
Best,
Wei
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Wei Wang <wei.w.wang@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"mhocko@kernel.org" <mhocko@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mawilcox@microsoft.com" <mawilcox@microsoft.com>,
"david@redhat.com" <david@redhat.com>,
"cornelia.huck@de.ibm.com" <cornelia.huck@de.ibm.com>,
"mgorman@techsingularity.net" <mgorman@techsingularity.net>,
"aarcange@redhat.com" <aarcange@redhat.com>,
"amit.shah@redhat.com" <amit.shah@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"willy@infradead.org" <willy@infradead.org>,
"liliang.opensource@gmail.com" <liliang.opensource@gmail.com>,
"yang.zhang.wz@gmail.com" <yang.zhang.wz@gmail.com>,
"quan.xu@aliyun.com" <quan.xu@aliyun.com>
Subject: Re: [Qemu-devel] [PATCH v16 5/5] virtio-balloon: VIRTIO_BALLOON_F_CTRL_VQ
Date: Thu, 19 Oct 2017 16:07:06 +0800 [thread overview]
Message-ID: <59E85D2A.1060407@intel.com> (raw)
In-Reply-To: <20171013163503-mutt-send-email-mst@kernel.org>
On 10/13/2017 09:38 PM, Michael S. Tsirkin wrote:
> On Thu, Oct 12, 2017 at 11:54:56AM +0800, Wei Wang wrote:
>>> But I think flushing is very fragile. You will easily run into races
>>> if one of the actors gets out of sync and keeps adding data.
>>> I think adding an ID in the free vq stream is a more robust
>>> approach.
>>>
>> Adding ID to the free vq would need the device to distinguish whether it
>> receives an ID or a free page hint,
> Not really. It's pretty simple: a 64 bit buffer is an ID. A 4K and bigger one
> is a page.
I think we can also use the previous method, free page via in_buf, and
id via out_buf.
Best,
Wei
WARNING: multiple messages have this Message-ID (diff)
From: Wei Wang <wei.w.wang@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"mhocko@kernel.org" <mhocko@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mawilcox@microsoft.com" <mawilcox@microsoft.com>,
"david@redhat.com" <david@redhat.com>,
"cornelia.huck@de.ibm.com" <cornelia.huck@de.ibm.com>,
"mgorman@techsingularity.net" <mgorman@techsingularity.net>,
"aarcange@redhat.com" <aarcange@redhat.com>,
"amit.shah@redhat.com" <amit.shah@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"willy@infradead.org" <willy@infradead.org>,
"liliang.opensource@gmail.com" <liliang.opensource@gmail.com>,
"yang.zhang.wz@gmail.com" <yang.zhang.wz@gmail.com>,
"quan.xu@aliyun.com" <quan.xu@aliyun.com>
Subject: [virtio-dev] Re: [PATCH v16 5/5] virtio-balloon: VIRTIO_BALLOON_F_CTRL_VQ
Date: Thu, 19 Oct 2017 16:07:06 +0800 [thread overview]
Message-ID: <59E85D2A.1060407@intel.com> (raw)
In-Reply-To: <20171013163503-mutt-send-email-mst@kernel.org>
On 10/13/2017 09:38 PM, Michael S. Tsirkin wrote:
> On Thu, Oct 12, 2017 at 11:54:56AM +0800, Wei Wang wrote:
>>> But I think flushing is very fragile. You will easily run into races
>>> if one of the actors gets out of sync and keeps adding data.
>>> I think adding an ID in the free vq stream is a more robust
>>> approach.
>>>
>> Adding ID to the free vq would need the device to distinguish whether it
>> receives an ID or a free page hint,
> Not really. It's pretty simple: a 64 bit buffer is an ID. A 4K and bigger one
> is a page.
I think we can also use the previous method, free page via in_buf, and
id via out_buf.
Best,
Wei
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2017-10-19 8:05 UTC|newest]
Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-30 4:05 [PATCH v16 0/5] Virtio-balloon Enhancement Wei Wang
2017-09-30 4:05 ` [virtio-dev] " Wei Wang
2017-09-30 4:05 ` [Qemu-devel] " Wei Wang
2017-09-30 4:05 ` Wei Wang
2017-09-30 4:05 ` [PATCH v16 1/5] lib/xbitmap: Introduce xbitmap Wei Wang
2017-09-30 4:05 ` [virtio-dev] " Wei Wang
2017-09-30 4:05 ` [Qemu-devel] " Wei Wang
2017-09-30 4:05 ` Wei Wang
2017-09-30 4:05 ` Wei Wang
2017-10-09 11:30 ` Tetsuo Handa
2017-10-09 11:30 ` [Qemu-devel] " Tetsuo Handa
2017-10-09 11:30 ` Tetsuo Handa
2017-09-30 4:05 ` Wei Wang
2017-09-30 4:05 ` [PATCH v16 2/5] radix tree test suite: add tests for xbitmap Wei Wang
2017-09-30 4:05 ` Wei Wang
2017-09-30 4:05 ` [virtio-dev] " Wei Wang
2017-09-30 4:05 ` [Qemu-devel] " Wei Wang
2017-09-30 4:05 ` Wei Wang
2017-09-30 4:05 ` [PATCH v16 3/5] virtio-balloon: VIRTIO_BALLOON_F_SG Wei Wang
2017-09-30 4:05 ` Wei Wang
2017-09-30 4:05 ` [virtio-dev] " Wei Wang
2017-09-30 4:05 ` [Qemu-devel] " Wei Wang
2017-09-30 4:05 ` Wei Wang
2017-10-02 4:30 ` Michael S. Tsirkin
2017-10-02 4:30 ` Michael S. Tsirkin
2017-10-02 4:30 ` [Qemu-devel] " Michael S. Tsirkin
2017-10-02 4:30 ` Michael S. Tsirkin
2017-10-02 12:39 ` Wang, Wei W
2017-10-02 12:39 ` Wang, Wei W
2017-10-02 12:39 ` [Qemu-devel] " Wang, Wei W
2017-10-02 12:39 ` Wang, Wei W
2017-10-02 12:39 ` Wang, Wei W
2017-10-02 13:44 ` Michael S. Tsirkin
2017-10-02 13:44 ` Michael S. Tsirkin
2017-10-02 13:44 ` [Qemu-devel] " Michael S. Tsirkin
2017-10-02 13:44 ` Michael S. Tsirkin
2017-10-02 13:44 ` Michael S. Tsirkin
2017-10-09 15:20 ` Michael S. Tsirkin
2017-10-09 15:20 ` [virtio-dev] " Michael S. Tsirkin
2017-10-09 15:20 ` [Qemu-devel] " Michael S. Tsirkin
2017-10-09 15:20 ` Michael S. Tsirkin
2017-10-10 7:28 ` Wei Wang
2017-10-10 7:28 ` Wei Wang
2017-10-10 7:28 ` [virtio-dev] " Wei Wang
2017-10-10 7:28 ` [Qemu-devel] " Wei Wang
2017-10-10 7:28 ` Wei Wang
2017-10-10 11:08 ` Tetsuo Handa
2017-10-10 11:08 ` [Qemu-devel] " Tetsuo Handa
2017-10-10 11:08 ` Tetsuo Handa
2017-10-10 12:32 ` Wei Wang
2017-10-10 12:32 ` [virtio-dev] " Wei Wang
2017-10-10 12:32 ` [Qemu-devel] " Wei Wang
2017-10-10 12:32 ` Wei Wang
2017-10-10 13:09 ` Tetsuo Handa
2017-10-10 13:09 ` [Qemu-devel] " Tetsuo Handa
2017-10-10 13:09 ` Tetsuo Handa
2017-10-11 1:51 ` Wei Wang
2017-10-11 1:51 ` Wei Wang
2017-10-11 1:51 ` [virtio-dev] " Wei Wang
2017-10-11 1:51 ` [Qemu-devel] " Wei Wang
2017-10-11 1:51 ` Wei Wang
2017-10-11 2:26 ` Tetsuo Handa
2017-10-11 2:26 ` [Qemu-devel] " Tetsuo Handa
2017-10-11 3:16 ` Wei Wang
2017-10-11 3:16 ` [virtio-dev] " Wei Wang
2017-10-11 3:16 ` [Qemu-devel] " Wei Wang
2017-10-11 3:16 ` Wei Wang
2017-10-11 3:16 ` Wei Wang
2017-10-10 12:32 ` Wei Wang
2017-10-09 15:20 ` Michael S. Tsirkin
2017-09-30 4:05 ` [PATCH v16 4/5] mm: support reporting free page blocks Wei Wang
2017-09-30 4:05 ` Wei Wang
2017-09-30 4:05 ` [virtio-dev] " Wei Wang
2017-09-30 4:05 ` [Qemu-devel] " Wei Wang
2017-09-30 4:05 ` Wei Wang
2017-10-03 14:50 ` Michal Hocko
2017-10-03 14:50 ` [Qemu-devel] " Michal Hocko
2017-10-03 14:50 ` Michal Hocko
2017-10-03 14:50 ` Michal Hocko
2017-09-30 4:05 ` [PATCH v16 5/5] virtio-balloon: VIRTIO_BALLOON_F_CTRL_VQ Wei Wang
2017-09-30 4:05 ` [virtio-dev] " Wei Wang
2017-09-30 4:05 ` [Qemu-devel] " Wei Wang
2017-09-30 4:05 ` Wei Wang
2017-10-01 3:18 ` Michael S. Tsirkin
2017-10-01 3:18 ` [virtio-dev] " Michael S. Tsirkin
2017-10-01 3:18 ` [Qemu-devel] " Michael S. Tsirkin
2017-10-01 3:18 ` Michael S. Tsirkin
2017-10-02 16:38 ` Wang, Wei W
2017-10-02 16:38 ` Wang, Wei W
2017-10-02 16:38 ` [virtio-dev] " Wang, Wei W
2017-10-02 16:38 ` [Qemu-devel] " Wang, Wei W
2017-10-02 16:38 ` Wang, Wei W
2017-10-02 16:38 ` Wang, Wei W
2017-10-10 15:15 ` Michael S. Tsirkin
2017-10-10 15:15 ` [virtio-dev] " Michael S. Tsirkin
2017-10-10 15:15 ` [Qemu-devel] " Michael S. Tsirkin
2017-10-10 15:15 ` Michael S. Tsirkin
2017-10-10 15:15 ` Michael S. Tsirkin
2017-10-11 6:03 ` Wei Wang
2017-10-11 6:03 ` Wei Wang
2017-10-11 6:03 ` [virtio-dev] " Wei Wang
2017-10-11 6:03 ` [Qemu-devel] " Wei Wang
2017-10-11 6:03 ` Wei Wang
2017-10-11 6:03 ` Wei Wang
2017-10-11 13:49 ` Michael S. Tsirkin
2017-10-11 13:49 ` Michael S. Tsirkin
2017-10-11 13:49 ` [virtio-dev] " Michael S. Tsirkin
2017-10-11 13:49 ` [Qemu-devel] " Michael S. Tsirkin
2017-10-11 13:49 ` Michael S. Tsirkin
2017-10-11 13:49 ` Michael S. Tsirkin
2017-10-12 3:54 ` Wei Wang
2017-10-12 3:54 ` [virtio-dev] " Wei Wang
2017-10-12 3:54 ` [Qemu-devel] " Wei Wang
2017-10-12 3:54 ` Wei Wang
2017-10-12 3:54 ` Wei Wang
2017-10-13 13:38 ` Michael S. Tsirkin
2017-10-13 13:38 ` [virtio-dev] " Michael S. Tsirkin
2017-10-13 13:38 ` [Qemu-devel] " Michael S. Tsirkin
2017-10-13 13:38 ` Michael S. Tsirkin
2017-10-13 13:38 ` Michael S. Tsirkin
2017-10-19 8:07 ` Wei Wang
2017-10-19 8:07 ` Wei Wang [this message]
2017-10-19 8:07 ` [virtio-dev] " Wei Wang
2017-10-19 8:07 ` [Qemu-devel] " Wei Wang
2017-10-19 8:07 ` Wei Wang
2017-10-19 8:07 ` Wei Wang
2017-10-13 13:38 ` Michael S. Tsirkin
2017-10-12 3:54 ` Wei Wang
2017-10-10 15:15 ` Michael S. Tsirkin
2017-10-01 3:18 ` Michael S. Tsirkin
2017-09-30 4:05 ` Wei Wang
2017-10-01 13:16 ` [PATCH v16 0/5] Virtio-balloon Enhancement Damian Tometzki
2017-10-01 13:16 ` Damian Tometzki
2017-10-01 13:16 ` [Qemu-devel] " Damian Tometzki
2017-10-01 13:16 ` Damian Tometzki
2017-10-01 13:16 ` Damian Tometzki
2017-10-01 13:25 ` Damian Tometzki
2017-10-01 13:25 ` [Qemu-devel] " Damian Tometzki
2017-10-01 13:25 ` Damian Tometzki
2017-10-01 13:25 ` Damian Tometzki
2017-10-09 9:39 ` Wei Wang
2017-10-09 9:39 ` [virtio-dev] " Wei Wang
2017-10-09 9:39 ` [Qemu-devel] " Wei Wang
2017-10-09 9:39 ` Wei Wang
2017-10-09 9:39 ` Wei Wang
2017-10-01 13:25 ` Damian Tometzki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59E85D2A.1060407@intel.com \
--to=wei.w.wang@intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=amit.shah@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=liliang.opensource@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mawilcox@microsoft.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quan.xu@aliyun.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=willy@infradead.org \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.