All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/rockchip: Fix build warning in analogix_dp-rockchip.c
@ 2017-10-20 17:25 ` Sean Paul
  0 siblings, 0 replies; 4+ messages in thread
From: Sean Paul @ 2017-10-20 17:25 UTC (permalink / raw)
  To: dri-devel, Jeffy Chen; +Cc: linux-rockchip, linux-arm-kernel

I didn't catch this before applying, just right after (of course).

Fixes:
../drivers/gpu/drm/rockchip/analogix_dp-rockchip.c: In function
‘rockchip_dp_of_probe’:
../drivers/gpu/drm/rockchip/analogix_dp-rockchip.c:276:6: warning:
unused variable ‘ret’ [-Wunused-variable]
  int ret;
        ^~~

Fixes: 102712a32ff5 ("drm/rockchip: analogix_dp: Remove unnecessary init
code")
Cc: Jeffy Chen <jeffy.chen@rock-chips.com>
Cc: Mark Yao <mark.yao@rock-chips.com>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
 drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
index 8cae5ad926cd..39944c0f1c0b 100644
--- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
@@ -273,7 +273,6 @@ static int rockchip_dp_of_probe(struct rockchip_dp_device *dp)
 {
 	struct device *dev = dp->dev;
 	struct device_node *np = dev->of_node;
-	int ret;
 
 	dp->grf = syscon_regmap_lookup_by_phandle(np, "rockchip,grf");
 	if (IS_ERR(dp->grf)) {
-- 
2.15.0.rc0.271.g36b669edcc-goog

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] drm/rockchip: Fix build warning in analogix_dp-rockchip.c
@ 2017-10-20 17:25 ` Sean Paul
  0 siblings, 0 replies; 4+ messages in thread
From: Sean Paul @ 2017-10-20 17:25 UTC (permalink / raw)
  To: linux-arm-kernel

I didn't catch this before applying, just right after (of course).

Fixes:
../drivers/gpu/drm/rockchip/analogix_dp-rockchip.c: In function
?rockchip_dp_of_probe?:
../drivers/gpu/drm/rockchip/analogix_dp-rockchip.c:276:6: warning:
unused variable ?ret? [-Wunused-variable]
  int ret;
        ^~~

Fixes: 102712a32ff5 ("drm/rockchip: analogix_dp: Remove unnecessary init
code")
Cc: Jeffy Chen <jeffy.chen@rock-chips.com>
Cc: Mark Yao <mark.yao@rock-chips.com>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: dri-devel at lists.freedesktop.org
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-rockchip at lists.infradead.org
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
 drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
index 8cae5ad926cd..39944c0f1c0b 100644
--- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
@@ -273,7 +273,6 @@ static int rockchip_dp_of_probe(struct rockchip_dp_device *dp)
 {
 	struct device *dev = dp->dev;
 	struct device_node *np = dev->of_node;
-	int ret;
 
 	dp->grf = syscon_regmap_lookup_by_phandle(np, "rockchip,grf");
 	if (IS_ERR(dp->grf)) {
-- 
2.15.0.rc0.271.g36b669edcc-goog

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/rockchip: Fix build warning in analogix_dp-rockchip.c
  2017-10-20 17:25 ` Sean Paul
@ 2017-10-20 23:14   ` jeffy
  -1 siblings, 0 replies; 4+ messages in thread
From: jeffy @ 2017-10-20 23:14 UTC (permalink / raw)
  To: Sean Paul, dri-devel; +Cc: linux-rockchip, linux-arm-kernel

Hi Sean,

On 10/21/2017 01:25 AM, Sean Paul wrote:
> I didn't catch this before applying, just right after (of course).
>
> Fixes:
> ../drivers/gpu/drm/rockchip/analogix_dp-rockchip.c: In function
> ‘rockchip_dp_of_probe’:
> ../drivers/gpu/drm/rockchip/analogix_dp-rockchip.c:276:6: warning:
> unused variable ‘ret’ [-Wunused-variable]
>    int ret;
>          ^~~

sorry, i thought i fixed that, but it looks like i amended it to the 
wrong commit by mistake...
>
> Fixes: 102712a32ff5 ("drm/rockchip: analogix_dp: Remove unnecessary init
> code")
> Cc: Jeffy Chen <jeffy.chen@rock-chips.com>
> Cc: Mark Yao <mark.yao@rock-chips.com>
> Cc: Sean Paul <seanpaul@chromium.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
>   drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> index 8cae5ad926cd..39944c0f1c0b 100644
> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> @@ -273,7 +273,6 @@ static int rockchip_dp_of_probe(struct rockchip_dp_device *dp)
>   {
>   	struct device *dev = dp->dev;
>   	struct device_node *np = dev->of_node;
> -	int ret;
>
>   	dp->grf = syscon_regmap_lookup_by_phandle(np, "rockchip,grf");
>   	if (IS_ERR(dp->grf)) {
>


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] drm/rockchip: Fix build warning in analogix_dp-rockchip.c
@ 2017-10-20 23:14   ` jeffy
  0 siblings, 0 replies; 4+ messages in thread
From: jeffy @ 2017-10-20 23:14 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Sean,

On 10/21/2017 01:25 AM, Sean Paul wrote:
> I didn't catch this before applying, just right after (of course).
>
> Fixes:
> ../drivers/gpu/drm/rockchip/analogix_dp-rockchip.c: In function
> ?rockchip_dp_of_probe?:
> ../drivers/gpu/drm/rockchip/analogix_dp-rockchip.c:276:6: warning:
> unused variable ?ret? [-Wunused-variable]
>    int ret;
>          ^~~

sorry, i thought i fixed that, but it looks like i amended it to the 
wrong commit by mistake...
>
> Fixes: 102712a32ff5 ("drm/rockchip: analogix_dp: Remove unnecessary init
> code")
> Cc: Jeffy Chen <jeffy.chen@rock-chips.com>
> Cc: Mark Yao <mark.yao@rock-chips.com>
> Cc: Sean Paul <seanpaul@chromium.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: dri-devel at lists.freedesktop.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-rockchip at lists.infradead.org
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
>   drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> index 8cae5ad926cd..39944c0f1c0b 100644
> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> @@ -273,7 +273,6 @@ static int rockchip_dp_of_probe(struct rockchip_dp_device *dp)
>   {
>   	struct device *dev = dp->dev;
>   	struct device_node *np = dev->of_node;
> -	int ret;
>
>   	dp->grf = syscon_regmap_lookup_by_phandle(np, "rockchip,grf");
>   	if (IS_ERR(dp->grf)) {
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-20 23:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-20 17:25 [PATCH] drm/rockchip: Fix build warning in analogix_dp-rockchip.c Sean Paul
2017-10-20 17:25 ` Sean Paul
2017-10-20 23:14 ` jeffy
2017-10-20 23:14   ` jeffy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.