All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tkaczyk, Mariusz" <mariusz.tkaczyk@linux.intel.com>
To: Coly Li <colyli@suse.de>, linux-raid@vger.kernel.org
Cc: George Gkioulis <ggkioulis@suse.com>, Jes Sorensen <jsorensen@fb.com>
Subject: Re: [PATCH v2] Monitor: print message before quit for no array to monitor
Date: Thu, 2 Sep 2021 09:08:25 +0200	[thread overview]
Message-ID: <59b40b04-399a-a0cd-f8be-ebdebe9a458c@linux.intel.com> (raw)
In-Reply-To: <20210902023644.509-1-colyli@suse.de>

Hi Coly,
On 02.09.2021 04:36, Coly Li wrote:
> @@ -258,6 +258,7 @@ int Monitor(struct mddev_dev *devlist,
>   			if (oneshot)
>   				break;
>   			else if (!anyredundant) {
> +				pr_err("Stop for no array to monitor\n");
>   				break;

IMO the message is not precise enough. See that if there is only raid0
then it also stops. Something like:
"No array with redundancy detected, stopping" is more detailed.

Thanks,
Mariusz


  reply	other threads:[~2021-09-02  7:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02  2:36 [PATCH v2] Monitor: print message before quit for no array to monitor Coly Li
2021-09-02  7:08 ` Tkaczyk, Mariusz [this message]
2021-09-02  7:26   ` Coly Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59b40b04-399a-a0cd-f8be-ebdebe9a458c@linux.intel.com \
    --to=mariusz.tkaczyk@linux.intel.com \
    --cc=colyli@suse.de \
    --cc=ggkioulis@suse.com \
    --cc=jsorensen@fb.com \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.