All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v1 10/41] s390x/tcg: Implement VECTOR ELEMENT COMPARE *
Date: Fri, 12 Apr 2019 13:14:19 -1000	[thread overview]
Message-ID: <59b43a53-8c25-53ea-c5a8-1cd33b4011e5@linaro.org> (raw)
In-Reply-To: <20190411100836.646-11-david@redhat.com>

On 4/11/19 12:08 AM, David Hildenbrand wrote:
> +                         es | logical ? 0 : MO_SIGN);

Incorrect operator precedence.  You need:

  es | (logical ? 0 : MO_SIGN)

or

  logical ? es : es | MO_SIGN

And perhaps cse this expression into a temporary
and not replicate it between the two reads.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

  reply	other threads:[~2019-04-12 23:14 UTC|newest]

Thread overview: 152+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 10:07 [Qemu-devel] [PATCH v1 00/41] s390x/tcg: Vector Instruction Support Part 2 David Hildenbrand
2019-04-11 10:07 ` David Hildenbrand
2019-04-11 10:07 ` [Qemu-devel] [PATCH v1 01/41] tcg: Implement tcg_gen_gvec_3i() David Hildenbrand
2019-04-11 10:07   ` David Hildenbrand
2019-04-11 10:07 ` [Qemu-devel] [PATCH v1 02/41] s390x/tcg: Implement VECTOR ADD David Hildenbrand
2019-04-11 10:07   ` David Hildenbrand
2019-04-12 18:28   ` Richard Henderson
2019-04-12 18:28     ` Richard Henderson
2019-04-11 10:07 ` [Qemu-devel] [PATCH v1 03/41] s390x/tcg: Implement VECTOR ADD COMPUTE CARRY David Hildenbrand
2019-04-11 10:07   ` David Hildenbrand
2019-04-12 21:05   ` Richard Henderson
2019-04-12 21:05     ` Richard Henderson
2019-04-16  8:01     ` David Hildenbrand
2019-04-16  8:01       ` David Hildenbrand
2019-04-16  8:17       ` Richard Henderson
2019-04-16  8:17         ` Richard Henderson
2019-04-16  8:33         ` David Hildenbrand
2019-04-16  8:33           ` David Hildenbrand
2019-04-16  8:43           ` Richard Henderson
2019-04-16  8:43             ` Richard Henderson
2019-04-16  8:46             ` David Hildenbrand
2019-04-16  8:46               ` David Hildenbrand
2019-04-11 10:07 ` [Qemu-devel] [PATCH v1 04/41] s390x/tcg: Implement VECTOR ADD WITH CARRY David Hildenbrand
2019-04-11 10:07   ` David Hildenbrand
2019-04-12 21:36   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 05/41] s390x/tcg: Implement VECTOR ADD WITH CARRY COMPUTE CARRY David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-12 21:58   ` Richard Henderson
2019-04-16  8:40     ` David Hildenbrand
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 06/41] s390x/tcg: Implement VECTOR AND (WITH COMPLEMENT) David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-12 21:59   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 07/41] s390x/tcg: Implement VECTOR AVERAGE David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-12 22:34   ` Richard Henderson
2019-04-16  8:52     ` David Hildenbrand
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 08/41] s390x/tcg: Implement VECTOR AVERAGE LOGICAL David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-12 22:35   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 09/41] s390x/tcg: Implement VECTOR CHECKSUM David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-12 23:01   ` Richard Henderson
2019-04-16  8:58     ` David Hildenbrand
2019-04-16  9:08       ` Richard Henderson
2019-04-16  9:13         ` David Hildenbrand
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 10/41] s390x/tcg: Implement VECTOR ELEMENT COMPARE * David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-12 23:14   ` Richard Henderson [this message]
2019-04-16  9:05     ` David Hildenbrand
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 11/41] s390x/tcg: Implement VECTOR " David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-12 23:17   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 12/41] s390x/tcg: Implement VECTOR COUNT LEADING ZEROS David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-12 23:21   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 13/41] s390x/tcg: Implement VECTOR COUNT TRAILING ZEROS David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-12 23:23   ` Richard Henderson
2019-04-16  9:07     ` David Hildenbrand
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 14/41] s390x/tcg: Implement VECTOR EXCLUSIVE OR David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-12 23:23   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 15/41] s390x/tcg: Implement VECTOR GALOIS FIELD MULTIPLY SUM (AND ACCUMULATE) David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-12 23:44   ` Richard Henderson
2019-04-16  9:10     ` David Hildenbrand
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 16/41] s390x/tcg: Implement VECTOR LOAD COMPLEMENT David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-12 23:47   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 17/41] s390x/tcg: Implement VECTOR LOAD POSITIVE David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-12 23:50   ` Richard Henderson
2019-04-16  9:16     ` David Hildenbrand
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 18/41] s390x/tcg: Implement VECTOR (MAXIMUM|MINIMUM) (LOGICAL) David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-12 23:51   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 19/41] s390x/tcg: Implement VECTOR MULTIPLY AND ADD * David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  0:01   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 20/41] s390x/tcg: Implement VECTOR MULTIPLY * David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  0:04   ` Richard Henderson
2019-04-16  9:23     ` David Hildenbrand
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 21/41] s390x/tcg: Implement VECTOR NAND David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  0:05   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 22/41] s390x/tcg: Implement VECTOR NOR David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  0:05   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 23/41] s390x/tcg: Implement VECTOR NOT EXCLUSIVE OR David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  0:06   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 24/41] s390x/tcg: Implement VECTOR OR David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  0:06   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 25/41] s390x/tcg: Implement VECTOR OR WITH COMPLEMENT David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  0:07   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 26/41] s390x/tcg: Implement VECTOR POPULATION COUNT David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  0:08   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 27/41] s390x/tcg: Implement VECTOR ELEMENT ROTATE LEFT LOGICAL David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  0:15   ` Richard Henderson
2019-04-16  9:27     ` David Hildenbrand
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 28/41] s390x/tcg: Implement VECTOR ELEMENT ROTATE AND INSERT UNDER MASK David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  0:29   ` Richard Henderson
2019-04-16  9:35     ` David Hildenbrand
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 29/41] s390x/tcg: Implement VECTOR ELEMENT SHIFT David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  0:31   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 30/41] s390x/tcg: Implement VECTOR SHIFT LEFT (BY BYTE) David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  0:36   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 31/41] s390x/tcg: Implement VECTOR SHIFT LEFT DOUBLE BY BYTE David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  0:54   ` Richard Henderson
2019-04-16  9:45     ` David Hildenbrand
2019-04-16 15:21       ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 32/41] s390x/tcg: Implement VECTOR SHIFT RIGHT ARITHMETIC David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  5:48   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 33/41] s390x/tcg: Implement VECTOR SHIFT RIGHT LOGICAL * David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  5:48   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 34/41] s390x/tcg: Implement VECTOR SUBTRACT David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  5:49   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 35/41] s390x/tcg: Implement VECTOR SUBTRACT COMPUTE BORROW INDICATION David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  5:51   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 36/41] s390x/tcg: Implement VECTOR SUBTRACT WITH " David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  5:52   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 37/41] s390x/tcg: Implement VECTOR SUBTRACT WITH BORROW COMPUTE " David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  6:11   ` Richard Henderson
2019-04-16 18:26     ` David Hildenbrand
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 38/41] s390x/tcg: Implement VECTOR SUM ACROSS DOUBLEWORD David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  6:15   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 39/41] s390x/tcg: Implement VECTOR SUM ACROSS QUADWORD David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  6:17   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 40/41] s390x/tcg: Implement VECTOR SUM ACROSS WORD David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  6:19   ` Richard Henderson
2019-04-11 10:08 ` [Qemu-devel] [PATCH v1 41/41] s390x/tcg: Implement VECTOR TEST UNDER MASK David Hildenbrand
2019-04-11 10:08   ` David Hildenbrand
2019-04-13  6:28   ` Richard Henderson
2019-04-16 18:20     ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59b43a53-8c25-53ea-c5a8-1cd33b4011e5@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.