All of lore.kernel.org
 help / color / mirror / Atom feed
* [PACTH iproute2] ip: align the name of the 'nohandler' stat
@ 2021-05-01  3:08 Jakub Kicinski
  2021-05-06 14:41 ` David Ahern
  0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2021-05-01  3:08 UTC (permalink / raw)
  To: stephen, dsahern; +Cc: netdev, Jakub Kicinski

Before:

    RX: bytes  packets  errors  dropped missed  mcast
    8848233056 8548168  0       0       0       0
    RX errors: length   crc     frame   fifo    overrun   nohandler
               0        0       0       0       0       101
    TX: bytes  packets  errors  dropped carrier collsns compressed
    1142925945 4683483  0       0       0       0       101
    TX errors: aborted  fifo   window heartbeat transns
               0        0       0       0       14

After:

    RX: bytes  packets  errors  dropped missed  mcast
    8848297833 8548461  0       0       0       0
    RX errors: length   crc     frame   fifo    overrun nohandler
               0        0       0       0       0       101
    TX: bytes  packets  errors  dropped carrier collsns compressed
    1143049820 4683865  0       0       0       0       101
    TX errors: aborted  fifo   window heartbeat transns
               0        0       0       0       14

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 ip/ipaddress.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index cfb24f5c1e34..8783b70d81e2 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -757,7 +757,7 @@ static void __print_link_stats(FILE *fp, struct rtattr *tb[])
 		if (show_stats > 1) {
 			fprintf(fp, "%s", _SL_);
 			fprintf(fp, "    RX errors: length   crc     frame   fifo    overrun%s%s",
-				s->rx_nohandler ? "   nohandler" : "", _SL_);
+				s->rx_nohandler ? " nohandler" : "", _SL_);
 			fprintf(fp, "               ");
 			print_num(fp, 8, s->rx_length_errors);
 			print_num(fp, 7, s->rx_crc_errors);
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PACTH iproute2] ip: align the name of the 'nohandler' stat
  2021-05-01  3:08 [PACTH iproute2] ip: align the name of the 'nohandler' stat Jakub Kicinski
@ 2021-05-06 14:41 ` David Ahern
  0 siblings, 0 replies; 2+ messages in thread
From: David Ahern @ 2021-05-06 14:41 UTC (permalink / raw)
  To: Jakub Kicinski, stephen; +Cc: netdev

On 4/30/21 9:08 PM, Jakub Kicinski wrote:
> Before:
> 
>     RX: bytes  packets  errors  dropped missed  mcast
>     8848233056 8548168  0       0       0       0
>     RX errors: length   crc     frame   fifo    overrun   nohandler
>                0        0       0       0       0       101
>     TX: bytes  packets  errors  dropped carrier collsns compressed
>     1142925945 4683483  0       0       0       0       101
>     TX errors: aborted  fifo   window heartbeat transns
>                0        0       0       0       14
> 
> After:
> 
>     RX: bytes  packets  errors  dropped missed  mcast
>     8848297833 8548461  0       0       0       0
>     RX errors: length   crc     frame   fifo    overrun nohandler
>                0        0       0       0       0       101
>     TX: bytes  packets  errors  dropped carrier collsns compressed
>     1143049820 4683865  0       0       0       0       101
>     TX errors: aborted  fifo   window heartbeat transns
>                0        0       0       0       14
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  ip/ipaddress.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

applied


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-06 14:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-01  3:08 [PACTH iproute2] ip: align the name of the 'nohandler' stat Jakub Kicinski
2021-05-06 14:41 ` David Ahern

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.