* + bloat-o-meter-provide-3-different-arguments-for-data-function-and-all.patch added to -mm tree
@ 2017-09-26 0:04 akpm
2017-09-26 18:26 ` Alexey Dobriyan
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2017-09-26 0:04 UTC (permalink / raw)
To: maninder1.s, andi, a.sahrawat, mmarek, pankaj.m, v.narang, mm-commits
The patch titled
Subject: bloat-o-meter: provide 3 different arguments for data, function and All
has been added to the -mm tree. Its filename is
bloat-o-meter-provide-3-different-arguments-for-data-function-and-all.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/bloat-o-meter-provide-3-different-arguments-for-data-function-and-all.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/bloat-o-meter-provide-3-different-arguments-for-data-function-and-all.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Maninder Singh <maninder1.s@samsung.com>
Subject: bloat-o-meter: provide 3 different arguments for data, function and All
This patch provides 3 new arguments for bloat-o-meter
1) -c -> for all (showing function and data differently)
2) -d -> data
3) -t -> function
output:-
./scripts/bloat-o-meter -c "file1" "file2"
add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-152 (-152)
Function old new delta
main 412 260 -152
Total: Before=548, After=396, chg -27.74%
##########################################################
add/remove: 1/0 grow/shrink: 1/0 up/down: 84/0 (84)
Data old new delta
arr - 64 +64
backtrace 60 80 +20
Total: Before=109, After=193, chg +77.06%
##########################################################
add/remove: 0/1 grow/shrink: 0/0 up/down: 0/-64 (-64)
RO Data old new delta
arr 64 - -64
Total: Before=68, After=4, chg -94.12%
Link: http://lkml.kernel.org/r/1506336313-27187-1-git-send-email-maninder1.s@samsung.com
Signed-off-by: Vaneet Narang <v.narang@samsung.com>
Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Cc: Amit Sahrawat <a.sahrawat@samsung.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Michal Marek <mmarek@suse.cz>
Cc: <pankaj.m@samsung.com>
Cc: <a.sahrawat@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
scripts/bloat-o-meter | 130 ++++++++++++++++++++++++----------------
1 file changed, 79 insertions(+), 51 deletions(-)
diff -puN scripts/bloat-o-meter~bloat-o-meter-provide-3-different-arguments-for-data-function-and-all scripts/bloat-o-meter
--- a/scripts/bloat-o-meter~bloat-o-meter-provide-3-different-arguments-for-data-function-and-all
+++ a/scripts/bloat-o-meter
@@ -12,66 +12,94 @@ from signal import signal, SIGPIPE, SIG_
signal(SIGPIPE, SIG_DFL)
-if len(sys.argv) != 3:
- sys.stderr.write("usage: %s file1 file2\n" % sys.argv[0])
+if len(sys.argv) < 3:
+ sys.stderr.write("usage: %s [option] file1 file2 \n" % sys.argv[0])
+ sys.stderr.write("The options are:\n")
+ sys.stderr.write("-c cateogrize output based on symbole type\n")
+ sys.stderr.write("-d Show delta of Data Section\n")
+ sys.stderr.write("-t Show delta of text Section\n")
sys.exit(-1)
re_NUMBER = re.compile(r'\.[0-9]+')
-def getsizes(file):
- sym = {}
- with os.popen("nm --size-sort " + file) as f:
- for line in f:
- size, type, name = line.split()
- if type in "tTdDbBrR":
- # strip generated symbols
- if name.startswith("__mod_"): continue
- if name.startswith("SyS_"): continue
- if name.startswith("compat_SyS_"): continue
- if name == "linux_banner": continue
- # statics and some other optimizations adds random .NUMBER
- name = re_NUMBER.sub('', name)
- sym[name] = sym.get(name, 0) + int(size, 16)
- return sym
-
-old = getsizes(sys.argv[1])
-new = getsizes(sys.argv[2])
-grow, shrink, add, remove, up, down = 0, 0, 0, 0, 0, 0
-delta, common = [], {}
-otot, ntot = 0, 0
-
-for a in old:
- if a in new:
- common[a] = 1
-
-for name in old:
- otot += old[name]
- if name not in common:
- remove += 1
- down += old[name]
- delta.append((-old[name], name))
-
-for name in new:
- ntot += new[name]
- if name not in common:
- add += 1
- up += new[name]
- delta.append((new[name], name))
+def getsizes(file, format) :
+ func_sym = {}
+ for l in os.popen("nm --size-sort " + file).readlines():
+ size, type, name = l[:-1].split()
+ if type in format:
+ # strip generated symbols
+ if name.startswith("__mod_"): continue
+ if name.startswith("SyS_"): continue
+ if name.startswith("compat_SyS_"): continue
+ if name == "linux_banner": continue
+ # statics and some other optimizations adds random .NUMBER
+ name = re_NUMBER.sub('', name)
+ func_sym[name] = func_sym.get(name, 0) + int(size, 16)
+ return func_sym
+
+def calc(oldfile, newfile, format):
+ old = getsizes(oldfile , format)
+ new = getsizes(newfile, format)
+ grow, shrink, add, remove, up, down = 0, 0, 0, 0, 0, 0
+ delta, common = [], {}
+ otot, ntot = 0, 0
+
+ for a in old:
+ if a in new:
+ common[a] = 1
+
+ for name in old:
+ otot += old[name]
+ if name not in common:
+ remove += 1
+ down += old[name]
+ delta.append((-old[name], name))
+
+ for name in new:
+ ntot += new[name]
+ if name not in common:
+ add += 1
+ up += new[name]
+ delta.append((new[name], name))
-for name in common:
+ for name in common:
d = new.get(name, 0) - old.get(name, 0)
if d>0: grow, up = grow+1, up+d
if d<0: shrink, down = shrink+1, down-d
delta.append((d, name))
-delta.sort()
-delta.reverse()
+ delta.sort()
+ delta.reverse()
+ return grow, shrink, add, remove, up, down, delta, old, new, otot, ntot
-print("add/remove: %s/%s grow/shrink: %s/%s up/down: %s/%s (%s)" % \
- (add, remove, grow, shrink, up, -down, up-down))
-print("%-40s %7s %7s %+7s" % ("function", "old", "new", "delta"))
-for d, n in delta:
- if d: print("%-40s %7s %7s %+7d" % (n, old.get(n,"-"), new.get(n,"-"), d))
+def print_result(symboltype, symbolformat, argc):
+ grow, shrink, add, remove, up, down, delta, old, new, otot, ntot = \
+ calc(sys.argv[argc - 1], sys.argv[argc], symbolformat)
-print("Total: Before=%d, After=%d, chg %+.2f%%" % \
- (otot, ntot, (ntot - otot)*100.0/otot))
+ print("add/remove: %s/%s grow/shrink: %s/%s up/down: %s/%s (%s)" % \
+ (add, remove, grow, shrink, up, -down, up-down))
+ print("%-40s %7s %7s %+7s" % (symboltype, "old", "new", "delta"))
+
+ for d, n in delta:
+ if d: print "%-40s %7s %7s %+7d" % (n, old.get(n,"-"), new.get(n,"-"), d)
+
+ print("Total: Before=%d, After=%d, chg %+.2f%%" % \
+ (otot, ntot, (ntot - otot)*100.0/otot))
+
+if(sys.argv[1] == "-c"):
+ print_result("Function", "tT", 3)
+ print("##########################################################")
+
+ print_result("Data", "dDbB", 3)
+ print("##########################################################")
+
+ print_result("RO Data", "rR", 3)
+
+elif(sys.argv[1] == "-d"):
+ print_result("Data", "dDbBrR", 3)
+
+elif(sys.argv[1] == "-t"):
+ print_result("Function", "tT", 3)
+
+else:
+ print_result("Function", "tTdDbBrR", 2)
_
Patches currently in -mm which might be from maninder1.s@samsung.com are
bloat-o-meter-provide-3-different-arguments-for-data-function-and-all.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: + bloat-o-meter-provide-3-different-arguments-for-data-function-and-all.patch added to -mm tree
2017-09-26 0:04 + bloat-o-meter-provide-3-different-arguments-for-data-function-and-all.patch added to -mm tree akpm
@ 2017-09-26 18:26 ` Alexey Dobriyan
0 siblings, 0 replies; 2+ messages in thread
From: Alexey Dobriyan @ 2017-09-26 18:26 UTC (permalink / raw)
To: linux-kernel, akpm
Cc: maninder1.s, andi, a.sahrawat, mmarek, pankaj.m, v.narang
On Mon, Sep 25, 2017 at 05:04:01PM -0700, akpm@linux-foundation.org wrote:
> +def getsizes(file, format) :
> + func_sym = {}
> + for l in os.popen("nm --size-sort " + file).readlines():
This simply undoes "for line in f" optimization I did.
> +if(sys.argv[1] == "-c"):
> +elif(sys.argv[1] == "-d"):
> +elif(sys.argv[1] == "-t"):
Python doesn't require () here.
In general output is pretty noisy already and all those "#######"
do not help.
A
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-26 18:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-26 0:04 + bloat-o-meter-provide-3-different-arguments-for-data-function-and-all.patch added to -mm tree akpm
2017-09-26 18:26 ` Alexey Dobriyan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.