* + mm-mempolicy-fix-numa_interleave_hit-counter.patch added to -mm tree
@ 2017-10-03 21:37 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2017-10-03 21:37 UTC (permalink / raw)
To: aryabinin, kemi.wang, mgorman, mm-commits
The patch titled
Subject: mm/mempolicy: fix NUMA_INTERLEAVE_HIT counter
has been added to the -mm tree. Its filename is
mm-mempolicy-fix-numa_interleave_hit-counter.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-mempolicy-fix-numa_interleave_hit-counter.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-mempolicy-fix-numa_interleave_hit-counter.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Andrey Ryabinin <aryabinin@virtuozzo.com>
Subject: mm/mempolicy: fix NUMA_INTERLEAVE_HIT counter
3a321d2a3dde81214 ("mm: change the call sites of numa statistics items")
separated NUMA counters from zone counters, but the NUMA_INTERLEAVE_HIT
call site wasn't updated to use the new interface. So
alloc_page_interleave() actually increments NR_ZONE_INACTIVE_FILE instead
of NUMA_INTERLEAVE_HIT.
Fix this by using __inc_numa_state() interface to increment
NUMA_INTERLEAVE_HIT.
Link: http://lkml.kernel.org/r/20171003191003.8573-1-aryabinin@virtuozzo.com
Fixes: 3a321d2a3dde ("mm: change the call sites of numa statistics items")
Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
Cc: Kemi Wang <kemi.wang@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/mempolicy.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff -puN mm/mempolicy.c~mm-mempolicy-fix-numa_interleave_hit-counter mm/mempolicy.c
--- a/mm/mempolicy.c~mm-mempolicy-fix-numa_interleave_hit-counter
+++ a/mm/mempolicy.c
@@ -1920,8 +1920,11 @@ static struct page *alloc_page_interleav
struct page *page;
page = __alloc_pages(gfp, order, nid);
- if (page && page_to_nid(page) == nid)
- inc_zone_page_state(page, NUMA_INTERLEAVE_HIT);
+ if (page && page_to_nid(page) == nid) {
+ preempt_disable();
+ __inc_numa_state(page_zone(page), NUMA_INTERLEAVE_HIT);
+ preempt_enable();
+ }
return page;
}
_
Patches currently in -mm which might be from aryabinin@virtuozzo.com are
mm-mempolicy-fix-numa_interleave_hit-counter.patch
kcov-remove-pointless-current-=-null-check.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-10-03 21:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-03 21:37 + mm-mempolicy-fix-numa_interleave_hit-counter.patch added to -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.