* [PATCH] arm64: dts: rockchip: Fix NanoPC-T4 cooling maps
@ 2019-11-16 12:47 ` Robin Murphy
0 siblings, 0 replies; 6+ messages in thread
From: Robin Murphy @ 2019-11-16 12:47 UTC (permalink / raw)
To: heiko; +Cc: linux-rockchip, linux-arm-kernel
Although it appeared to follow logically from the bindings, apparently
the thermal framework can't properly cope with a single cooling device
being shared between multiple maps. The CPU zone is probably easier to
overheat, so remove the references to the (optional) fan from the GPU
cooling zone to avoid things getting confused. Hopefully GPU-intensive
tasks will leak enough heat across to the CPU zone to still hit the
fan trips before reaching critical GPU temperatures.
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
.../boot/dts/rockchip/rk3399-nanopc-t4.dts | 27 -------------------
1 file changed, 27 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopc-t4.dts b/arch/arm64/boot/dts/rockchip/rk3399-nanopc-t4.dts
index f399853c635a..f81a8429f139 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-nanopc-t4.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopc-t4.dts
@@ -113,33 +113,6 @@
};
};
-&gpu_thermal {
- trips {
- gpu_warm: gpu_warm {
- temperature = <55000>;
- hysteresis = <2000>;
- type = "active";
- };
-
- gpu_hot: gpu_hot {
- temperature = <65000>;
- hysteresis = <2000>;
- type = "active";
- };
- };
- cooling-maps {
- map1 {
- trip = <&gpu_warm>;
- cooling-device = <&fan THERMAL_NO_LIMIT 1>;
- };
-
- map2 {
- trip = <&gpu_hot>;
- cooling-device = <&fan 2 THERMAL_NO_LIMIT>;
- };
- };
-};
-
&i2s0 {
status = "okay";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] arm64: dts: rockchip: Fix NanoPC-T4 cooling maps
@ 2019-11-16 12:47 ` Robin Murphy
0 siblings, 0 replies; 6+ messages in thread
From: Robin Murphy @ 2019-11-16 12:47 UTC (permalink / raw)
To: heiko; +Cc: linux-rockchip, linux-arm-kernel
Although it appeared to follow logically from the bindings, apparently
the thermal framework can't properly cope with a single cooling device
being shared between multiple maps. The CPU zone is probably easier to
overheat, so remove the references to the (optional) fan from the GPU
cooling zone to avoid things getting confused. Hopefully GPU-intensive
tasks will leak enough heat across to the CPU zone to still hit the
fan trips before reaching critical GPU temperatures.
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
.../boot/dts/rockchip/rk3399-nanopc-t4.dts | 27 -------------------
1 file changed, 27 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopc-t4.dts b/arch/arm64/boot/dts/rockchip/rk3399-nanopc-t4.dts
index f399853c635a..f81a8429f139 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-nanopc-t4.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopc-t4.dts
@@ -113,33 +113,6 @@
};
};
-&gpu_thermal {
- trips {
- gpu_warm: gpu_warm {
- temperature = <55000>;
- hysteresis = <2000>;
- type = "active";
- };
-
- gpu_hot: gpu_hot {
- temperature = <65000>;
- hysteresis = <2000>;
- type = "active";
- };
- };
- cooling-maps {
- map1 {
- trip = <&gpu_warm>;
- cooling-device = <&fan THERMAL_NO_LIMIT 1>;
- };
-
- map2 {
- trip = <&gpu_hot>;
- cooling-device = <&fan 2 THERMAL_NO_LIMIT>;
- };
- };
-};
-
&i2s0 {
status = "okay";
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <5bb39f3115df1a487d717d3ae87e523b03749379.1573908197.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>]
* Re: [PATCH] arm64: dts: rockchip: Fix NanoPC-T4 cooling maps
2019-11-16 12:47 ` Robin Murphy
@ 2019-11-18 0:52 ` Heiko Stuebner
-1 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2019-11-18 0:52 UTC (permalink / raw)
To: Robin Murphy
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Am Samstag, 16. November 2019, 13:47:19 CET schrieb Robin Murphy:
> Although it appeared to follow logically from the bindings, apparently
> the thermal framework can't properly cope with a single cooling device
> being shared between multiple maps. The CPU zone is probably easier to
> overheat, so remove the references to the (optional) fan from the GPU
> cooling zone to avoid things getting confused. Hopefully GPU-intensive
> tasks will leak enough heat across to the CPU zone to still hit the
> fan trips before reaching critical GPU temperatures.
>
> Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
applied, after little bit of editing.
> &i2s0 {
> status = "okay";
> };
although my nano-pc dts does not seem to have that &i2s0 node yet.
Did I miss a patch somewhere?
Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Fix NanoPC-T4 cooling maps
@ 2019-11-18 0:52 ` Heiko Stuebner
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2019-11-18 0:52 UTC (permalink / raw)
To: Robin Murphy; +Cc: linux-rockchip, linux-arm-kernel
Am Samstag, 16. November 2019, 13:47:19 CET schrieb Robin Murphy:
> Although it appeared to follow logically from the bindings, apparently
> the thermal framework can't properly cope with a single cooling device
> being shared between multiple maps. The CPU zone is probably easier to
> overheat, so remove the references to the (optional) fan from the GPU
> cooling zone to avoid things getting confused. Hopefully GPU-intensive
> tasks will leak enough heat across to the CPU zone to still hit the
> fan trips before reaching critical GPU temperatures.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
applied, after little bit of editing.
> &i2s0 {
> status = "okay";
> };
although my nano-pc dts does not seem to have that &i2s0 node yet.
Did I miss a patch somewhere?
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Fix NanoPC-T4 cooling maps
2019-11-18 0:52 ` Heiko Stuebner
@ 2019-11-18 12:09 ` Robin Murphy
-1 siblings, 0 replies; 6+ messages in thread
From: Robin Murphy @ 2019-11-18 12:09 UTC (permalink / raw)
To: Heiko Stuebner; +Cc: linux-rockchip, linux-arm-kernel
On 18/11/2019 12:52 am, Heiko Stuebner wrote:
> Am Samstag, 16. November 2019, 13:47:19 CET schrieb Robin Murphy:
>> Although it appeared to follow logically from the bindings, apparently
>> the thermal framework can't properly cope with a single cooling device
>> being shared between multiple maps. The CPU zone is probably easier to
>> overheat, so remove the references to the (optional) fan from the GPU
>> cooling zone to avoid things getting confused. Hopefully GPU-intensive
>> tasks will leak enough heat across to the CPU zone to still hit the
>> fan trips before reaching critical GPU temperatures.
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>
> applied, after little bit of editing.
>
>> &i2s0 {
>> status = "okay";
>> };
>
> although my nano-pc dts does not seem to have that &i2s0 node yet.
> Did I miss a patch somewhere?
Oops, no, my fault - there were more changes in the middle of my local
branch which I thought were entirely orthogonal. I should have checked
the diff context more closely... thanks for cleaning it up!
Robin.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Fix NanoPC-T4 cooling maps
@ 2019-11-18 12:09 ` Robin Murphy
0 siblings, 0 replies; 6+ messages in thread
From: Robin Murphy @ 2019-11-18 12:09 UTC (permalink / raw)
To: Heiko Stuebner; +Cc: linux-rockchip, linux-arm-kernel
On 18/11/2019 12:52 am, Heiko Stuebner wrote:
> Am Samstag, 16. November 2019, 13:47:19 CET schrieb Robin Murphy:
>> Although it appeared to follow logically from the bindings, apparently
>> the thermal framework can't properly cope with a single cooling device
>> being shared between multiple maps. The CPU zone is probably easier to
>> overheat, so remove the references to the (optional) fan from the GPU
>> cooling zone to avoid things getting confused. Hopefully GPU-intensive
>> tasks will leak enough heat across to the CPU zone to still hit the
>> fan trips before reaching critical GPU temperatures.
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>
> applied, after little bit of editing.
>
>> &i2s0 {
>> status = "okay";
>> };
>
> although my nano-pc dts does not seem to have that &i2s0 node yet.
> Did I miss a patch somewhere?
Oops, no, my fault - there were more changes in the middle of my local
branch which I thought were entirely orthogonal. I should have checked
the diff context more closely... thanks for cleaning it up!
Robin.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-18 12:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-16 12:47 [PATCH] arm64: dts: rockchip: Fix NanoPC-T4 cooling maps Robin Murphy
2019-11-16 12:47 ` Robin Murphy
[not found] ` <5bb39f3115df1a487d717d3ae87e523b03749379.1573908197.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2019-11-18 0:52 ` Heiko Stuebner
2019-11-18 0:52 ` Heiko Stuebner
2019-11-18 12:09 ` Robin Murphy
2019-11-18 12:09 ` Robin Murphy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.