From: Andrew Cooper <amc96@srcf.net>
To: Anthony PERARD <anthony.perard@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
"Jan Beulich" <JBeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>
Subject: Re: [PATCH] xen/build: Fix dependency for the MAP rule
Date: Thu, 14 Apr 2022 19:17:03 +0100 [thread overview]
Message-ID: <59eab45c-ea10-b7b6-d78d-5ea4b6213246@srcf.net> (raw)
In-Reply-To: <YlhetDD/Xsnn2Vif@perard.uk.xensource.com>
On 14/04/2022 18:49, Anthony PERARD wrote:
> On Thu, Apr 14, 2022 at 05:23:48PM +0100, Andrew Cooper wrote:
>> diff --git a/xen/Makefile b/xen/Makefile
>> index dd05672ff42d..02a274f56dc0 100644
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -599,7 +599,7 @@ cscope:
>> cscope -k -b -q
>>
>> .PHONY: _MAP
>> -_MAP:
>> +_MAP: $(TARGET)-syms
> That's not going to work well as make isn't going to know how to build
> $(TARGET)-syms.
Huh... It appears to work for me, but it's parallel build so who knows.
> I guess you want to have $(TARGET) as prerequisite or
> add somewhere "$(TARGET)-syms: $(TARGET)".
That becomes cyclic with arch/*/Makefile which has:
$(TARGET): $(TARGET)-syms
The _install rule does make the implication that a dependency on
$(TARGET) builds $(TARGET)-syms so I guess that's good enough for _MAP too.
~Andrew
next prev parent reply other threads:[~2022-04-14 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 16:23 [PATCH] xen/build: Fix dependency for the MAP rule Andrew Cooper
2022-04-14 17:49 ` Anthony PERARD
2022-04-14 18:17 ` Andrew Cooper [this message]
2022-04-14 18:35 ` [PATCH v2] " Andrew Cooper
2022-04-20 10:06 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59eab45c-ea10-b7b6-d78d-5ea4b6213246@srcf.net \
--to=amc96@srcf.net \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.