From: Dmitry Osipenko <digetx@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
mkarthik@nvidia.com, smohammed@nvidia.com, talho@nvidia.com
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH V14 3/5] i2c: tegra: Add DMA support
Date: Thu, 7 Feb 2019 23:46:17 +0300 [thread overview]
Message-ID: <59f39ee7-c7da-52ea-cc67-52c5af879c35@gmail.com> (raw)
In-Reply-To: <1549480569-24860-3-git-send-email-skomatineni@nvidia.com>
06.02.2019 22:16, Sowjanya Komatineni пишет:
> + if (!i2c_dev->msg_read) {
> + if (dma) {
> + memcpy(buffer, msg->buf, msg->len);
> + dma_sync_single_for_device(i2c_dev->dev,
> + i2c_dev->dma_phys,
> + xfer_size,
> + DMA_TO_DEVICE);
> + err = tegra_i2c_dma_submit(i2c_dev, xfer_size);
> + if (err < 0) {
> + dev_err(i2c_dev->dev,
> + "starting TX DMA failed, err %d\n",
> + err);
> + goto unlock;
> + }
> +
This newline is not really needed here.
> + } else {
> + tegra_i2c_fill_tx_fifo(i2c_dev);
> + }
> + }
That's my last comment for v14. Looking forward for v15!
next prev parent reply other threads:[~2019-02-07 20:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 19:16 [PATCH V14 1/5] i2c: tegra: sort all the include headers alphabetically Sowjanya Komatineni
2019-02-06 19:16 ` Sowjanya Komatineni
2019-02-06 19:16 ` [PATCH V14 2/5] i2c: tegra: add bus clear Master Support Sowjanya Komatineni
2019-02-06 19:16 ` Sowjanya Komatineni
2019-02-07 18:26 ` Dmitry Osipenko
2019-02-06 19:16 ` [PATCH V14 3/5] i2c: tegra: Add DMA support Sowjanya Komatineni
2019-02-06 19:16 ` Sowjanya Komatineni
2019-02-07 11:01 ` Thierry Reding
2019-02-07 13:57 ` Dmitry Osipenko
2019-02-07 15:23 ` Sowjanya Komatineni
2019-02-07 16:01 ` Dmitry Osipenko
2019-02-07 16:06 ` Thierry Reding
2019-02-07 16:08 ` Sowjanya Komatineni
2019-02-07 16:17 ` Dmitry Osipenko
2019-02-07 18:02 ` Sowjanya Komatineni
2019-02-07 18:22 ` Dmitry Osipenko
2019-02-07 14:52 ` Dmitry Osipenko
2019-02-07 15:11 ` Sowjanya Komatineni
2019-02-07 15:17 ` Dmitry Osipenko
2019-02-07 15:17 ` Sowjanya Komatineni
2019-02-07 15:56 ` Dmitry Osipenko
2019-02-07 16:02 ` Thierry Reding
2019-02-07 18:24 ` Dmitry Osipenko
2019-02-07 18:50 ` Dmitry Osipenko
2019-02-07 18:56 ` Sowjanya Komatineni
2019-02-07 19:03 ` Dmitry Osipenko
2019-02-07 19:14 ` Sowjanya Komatineni
2019-02-07 18:55 ` Dmitry Osipenko
2019-02-07 19:14 ` Dmitry Osipenko
2019-02-07 20:22 ` Dmitry Osipenko
2019-02-07 20:46 ` Dmitry Osipenko [this message]
2019-02-06 19:16 ` [PATCH V14 4/5] i2c: tegra: update transfer timeout Sowjanya Komatineni
2019-02-06 19:16 ` Sowjanya Komatineni
2019-02-06 19:16 ` [PATCH V14 5/5] i2c: tegra: add i2c interface timing support Sowjanya Komatineni
2019-02-06 19:16 ` Sowjanya Komatineni
2019-02-07 14:34 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59f39ee7-c7da-52ea-cc67-52c5af879c35@gmail.com \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkarthik@nvidia.com \
--cc=skomatineni@nvidia.com \
--cc=smohammed@nvidia.com \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.