From: Sowjanya Komatineni <skomatineni@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mantravadi Karthik <mkarthik@nvidia.com>,
Shardar Mohammed <smohammed@nvidia.com>,
Timo Alho <talho@nvidia.com>
Cc: "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: RE: [PATCH V14 3/5] i2c: tegra: Add DMA support
Date: Thu, 7 Feb 2019 19:14:33 +0000 [thread overview]
Message-ID: <BYAPR12MB339812565AB1C9973A934522C2680@BYAPR12MB3398.namprd12.prod.outlook.com> (raw)
In-Reply-To: <da8138fe-ea4b-42be-1065-c7098ac59691@gmail.com>
> >>> static const struct tegra_i2c_hw_feature tegra210_i2c_hw = { @@
> >>> -980,6 +1302,7 @@ static const struct tegra_i2c_hw_feature tegra210_i2c_hw = {
> >>> .has_mst_fifo = false,
> >>> .quirks = &tegra_i2c_quirks,
> >>> .supports_bus_clear = true,
> >>> + .has_apb_dma = true,
> >>> };
> >>
> >> T186 is missed here.
> >
> > Currently t186 hw feature is not present in existing linux next and device trees use both t186 and t114 compatibles, so t114 is being applies.
> > But dmas are not used for t186 yet.
> >
> > T186 hw feature is added for first time as part of interface timing and its in patch next to this patch in same series.
> > This is the same from beginning of all these series.
> >
> >>
> >>>
> >>> static const struct tegra_i2c_hw_feature tegra194_i2c_hw = { @@
> >>> -995,6 +1318,7 @@ static const struct tegra_i2c_hw_feature tegra194_i2c_hw = {
> >>> .has_mst_fifo = true,
> >>> .quirks = &tegra194_i2c_quirks,
> >>> .supports_bus_clear = true,
> >>> + .has_apb_dma = false,
> >>> };
> >
>
> You added "has_apb_dma" for T194 and not T186 in this patch, I happened to notice it only right now. Please, let's be consistent and set the new field for all of the platforms in this patch.
OK, Will move t186 hw feature addition to this path from interface timing to reflect apb dma flag.
next prev parent reply other threads:[~2019-02-07 19:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 19:16 [PATCH V14 1/5] i2c: tegra: sort all the include headers alphabetically Sowjanya Komatineni
2019-02-06 19:16 ` Sowjanya Komatineni
2019-02-06 19:16 ` [PATCH V14 2/5] i2c: tegra: add bus clear Master Support Sowjanya Komatineni
2019-02-06 19:16 ` Sowjanya Komatineni
2019-02-07 18:26 ` Dmitry Osipenko
2019-02-06 19:16 ` [PATCH V14 3/5] i2c: tegra: Add DMA support Sowjanya Komatineni
2019-02-06 19:16 ` Sowjanya Komatineni
2019-02-07 11:01 ` Thierry Reding
2019-02-07 13:57 ` Dmitry Osipenko
2019-02-07 15:23 ` Sowjanya Komatineni
2019-02-07 16:01 ` Dmitry Osipenko
2019-02-07 16:06 ` Thierry Reding
2019-02-07 16:08 ` Sowjanya Komatineni
2019-02-07 16:17 ` Dmitry Osipenko
2019-02-07 18:02 ` Sowjanya Komatineni
2019-02-07 18:22 ` Dmitry Osipenko
2019-02-07 14:52 ` Dmitry Osipenko
2019-02-07 15:11 ` Sowjanya Komatineni
2019-02-07 15:17 ` Dmitry Osipenko
2019-02-07 15:17 ` Sowjanya Komatineni
2019-02-07 15:56 ` Dmitry Osipenko
2019-02-07 16:02 ` Thierry Reding
2019-02-07 18:24 ` Dmitry Osipenko
2019-02-07 18:50 ` Dmitry Osipenko
2019-02-07 18:56 ` Sowjanya Komatineni
2019-02-07 19:03 ` Dmitry Osipenko
2019-02-07 19:14 ` Sowjanya Komatineni [this message]
2019-02-07 18:55 ` Dmitry Osipenko
2019-02-07 19:14 ` Dmitry Osipenko
2019-02-07 20:22 ` Dmitry Osipenko
2019-02-07 20:46 ` Dmitry Osipenko
2019-02-06 19:16 ` [PATCH V14 4/5] i2c: tegra: update transfer timeout Sowjanya Komatineni
2019-02-06 19:16 ` Sowjanya Komatineni
2019-02-06 19:16 ` [PATCH V14 5/5] i2c: tegra: add i2c interface timing support Sowjanya Komatineni
2019-02-06 19:16 ` Sowjanya Komatineni
2019-02-07 14:34 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR12MB339812565AB1C9973A934522C2680@BYAPR12MB3398.namprd12.prod.outlook.com \
--to=skomatineni@nvidia.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkarthik@nvidia.com \
--cc=smohammed@nvidia.com \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.