BCM4356 does not initalize after firmware update

BCM4356 does not initalize after firmware update

[Stanislaw Gruszka]

Hi

After firmware update, this device:

[0280]: Broadcom Limited BCM4356 802.11ac Wireless Network Adapter [14e4:43ec] (rev 02)

no longer initialize. With the firmware update I have:

[  272.063814] brcmfmac: brcmf_fw_map_chip_to_name: using brcm/brcmfmac4356-pcie.bin for chip 0x004356(17238) rev 0x000002
[  272.529582] brcmfmac 0000:03:00.0: irq 31 for MSI/MSI-X
[  274.529476] brcmfmac: brcmf_msgbuf_query_dcmd: Timeout on response for query command
[  274.537356] brcmfmac: brcmf_c_preinit_dcmds: Retreiving cur_etheraddr failed, -5
[  274.544881] brcmfmac: brcmf_bus_started: failed: -5
[  274.549854] brcmfmac: brcmf_pcie_attach_bus: dongle is not responding

and no wlan device is created. With older version of the firmware I have:

[   10.716878] brcmfmac: brcmf_fw_map_chip_to_name: using brcm/brcmfmac4356-pcie.bin for chip 0x004356(17238) rev 0x000002
[   11.312875] brcmfmac 0000:03:00.0: irq 31 for MSI/MSI-X
[   11.314735] brcmfmac: brcmf_c_preinit_dcmds: Firmware version = wl0: Oct 22 2015 06:16:41 version 7.35.180.119 (r594535) FWID 01-1a5c4016
[   16.598211] brcmfmac: brcmf_p2p_create_p2pdev: set p2p_disc error
[   16.604416] brcmfmac: brcmf_cfg80211_add_iface: add iface p2p-dev-wlp3s0 type 10 failed: err=-16

and despite P2P errors, device works correctly.

Regards
Stanislaw

Re: BCM4356 does not initalize after firmware update

[Arend van Spriel]

On 12/13/2017 5:12 PM, Stanislaw Gruszka wrote:
> Hi
>
> After firmware update, this device:
>
> [0280]: Broadcom Limited BCM4356 802.11ac Wireless Network Adapter [14e4:43ec] (rev 02)
>
> no longer initialize. With the firmware update I have:
>
> [  272.063814] brcmfmac: brcmf_fw_map_chip_to_name: using brcm/brcmfmac4356-pcie.bin for chip 0x004356(17238) rev 0x000002
> [  272.529582] brcmfmac 0000:03:00.0: irq 31 for MSI/MSI-X
> [  274.529476] brcmfmac: brcmf_msgbuf_query_dcmd: Timeout on response for query command
> [  274.537356] brcmfmac: brcmf_c_preinit_dcmds: Retreiving cur_etheraddr failed, -5
> [  274.544881] brcmfmac: brcmf_bus_started: failed: -5
> [  274.549854] brcmfmac: brcmf_pcie_attach_bus: dongle is not responding
>
> and no wlan device is created. With older version of the firmware I have:
>
> [   10.716878] brcmfmac: brcmf_fw_map_chip_to_name: using brcm/brcmfmac4356-pcie.bin for chip 0x004356(17238) rev 0x000002
> [   11.312875] brcmfmac 0000:03:00.0: irq 31 for MSI/MSI-X
> [   11.314735] brcmfmac: brcmf_c_preinit_dcmds: Firmware version = wl0: Oct 22 2015 06:16:41 version 7.35.180.119 (r594535) FWID 01-1a5c4016
> [   16.598211] brcmfmac: brcmf_p2p_create_p2pdev: set p2p_disc error
> [   16.604416] brcmfmac: brcmf_cfg80211_add_iface: add iface p2p-dev-wlp3s0 type 10 failed: err=-16
>
> and despite P2P errors, device works correctly.

The cur_etheraddr is the first piece of info we try to get from the 
firmware. Could you build the driver with CONFIG_BRCMDBG and load the 
module with 'debug=0x181416'.

Regards,
Arend

Re: BCM4356 does not initalize after firmware update

[Stanislaw Gruszka]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

On Thu, Dec 14, 2017 at 10:13:29AM +0100, Arend van Spriel wrote:
> The cur_etheraddr is the first piece of info we try to get from the
> firmware. Could you build the driver with CONFIG_BRCMDBG and load
> the module with 'debug=0x181416'.

dmesg attached. 

Thanks
Stanislaw

[-- Attachment #2: brcmfmac-dmesg.txt --]
[-- Type: text/plain, Size: 7714 bytes --]

[ 2665.150833] usbcore: deregistering interface driver brcmfmac
[ 2685.122741] brcmfmac: brcmfmac_module_init No platform data available.
[ 2685.123368] usbcore: registered new interface driver brcmfmac
[ 2685.129239] brcmfmac: brcmf_pcie_register Enter
[ 2685.131783] brcmfmac: brcmf_pcie_probe Enter 14e4:43ec (1/3)
[ 2685.132186] brcmfmac: brcmf_pcie_get_resource Phys addr : reg space = ffffa0ff40af0000 base addr 0x000000f7c00000
[ 2685.132194] brcmfmac: brcmf_pcie_get_resource Phys addr : mem space = ffffa0ff41800000 base addr 0x000000f7800000 size 0x400000
[ 2685.132213] brcmfmac: brcmf_chip_recognition found AXI chip: BCM4356, rev=2
[ 2685.133298] brcmfmac: brcmf_chip_cores_check  [1 ] core 0x800:47 base 0x18000000 wrap 0x18100000
[ 2685.133306] brcmfmac: brcmf_chip_cores_check  [2 ] core 0x812:48 base 0x18001000 wrap 0x18101000
[ 2685.133312] brcmfmac: brcmf_chip_cores_check  [3 ] core 0x83e:6  base 0x18002000 wrap 0x18102000
[ 2685.133320] brcmfmac: brcmf_chip_cores_check  [4 ] core 0x83c:11 base 0x18003000 wrap 0x18103000
[ 2685.133326] brcmfmac: brcmf_chip_cores_check  [5 ] core 0x81a:22 base 0x18004000 wrap 0x18104000
[ 2685.133332] brcmfmac: brcmf_chip_cores_check  [6 ] core 0x829:21 base 0x18005000 wrap 0x18105000
[ 2685.133337] brcmfmac: brcmf_chip_cores_check  [7 ] core 0x83d:2  base 0x18006000 wrap 0x18106000
[ 2685.133343] brcmfmac: brcmf_chip_cores_check  [8 ] core 0x135:0  base 0x00000000 wrap 0x1810a000
[ 2685.133348] brcmfmac: brcmf_chip_cores_check  [9 ] core 0x240:0  base 0x00000000 wrap 0x00000000
[ 2685.133353] brcmfmac: brcmf_chip_set_passive Enter
[ 2685.236599] brcmfmac: brcmf_pcie_reset_device config offset 0x0004, value 0x100106
[ 2685.236610] brcmfmac: brcmf_pcie_reset_device config offset 0x004c, value 0x4008
[ 2685.236618] brcmfmac: brcmf_pcie_reset_device config offset 0x0058, value 0x886805
[ 2685.236625] brcmfmac: brcmf_pcie_reset_device config offset 0x005c, value 0xfee0300c
[ 2685.236632] brcmfmac: brcmf_pcie_reset_device config offset 0x0060, value 0x0000
[ 2685.236638] brcmfmac: brcmf_pcie_reset_device config offset 0x0064, value 0x4182
[ 2685.236645] brcmfmac: brcmf_pcie_reset_device config offset 0x00dc, value 0x10001
[ 2685.236652] brcmfmac: brcmf_pcie_reset_device config offset 0x0228, value 0x0222
[ 2685.236658] brcmfmac: brcmf_pcie_reset_device config offset 0x0248, value 0x0000
[ 2685.236665] brcmfmac: brcmf_pcie_reset_device config offset 0x04e0, value 0x0017
[ 2685.236672] brcmfmac: brcmf_pcie_reset_device config offset 0x04f4, value 0x0000
[ 2685.236679] brcmfmac: brcmf_chip_set_passive Enter
[ 2685.237106] brcmfmac: brcmf_chip_get_raminfo RAM: base=0x180000 size=786432 (0xc0000) sr=0 (0x0)
[ 2685.237137] brcmfmac: brcmf_chip_setup ccrev=47, pmurev=24, pmucaps=0x420e5f18
[ 2685.237141] brcmfmac: brcmf_get_module_param Enter, bus=2, chip=17238, rev=2
[ 2685.237148] brcmfmac: brcmf_fw_map_chip_to_name: using brcm/brcmfmac4356-pcie.bin for chip 0x004356(17238) rev 0x000002
[ 2685.248121] brcmfmac: brcmf_fw_get_firmwares_pcie enter: dev=0000:03:00.0
[ 2685.252332] brcmfmac: brcmf_fw_request_code_done enter: dev=0000:03:00.0
[ 2685.252606] brcmfmac: brcmf_fw_request_nvram_done enter: dev=0000:03:00.0
[ 2685.256784] brcmfmac: brcmf_pcie_download_fw_nvram Halt ARM.
[ 2685.256790] brcmfmac: brcmf_pcie_download_fw_nvram Download FW brcm/brcmfmac4356-pcie.bin
[ 2685.588821] brcmfmac: brcmf_pcie_download_fw_nvram No matching NVRAM file found brcm/brcmfmac4356-pcie.txt
[ 2685.588831] brcmfmac: brcmf_pcie_download_fw_nvram Bring ARM in running state
[ 2685.588834] brcmfmac: brcmf_chip_set_active Enter
[ 2685.589035] brcmfmac: brcmf_pcie_download_fw_nvram Wait for FW init
[ 2685.639593] brcmfmac: brcmf_pcie_download_fw_nvram Shared RAM addr: 0x001f1528
[ 2685.639603] brcmfmac: brcmf_pcie_init_share_ram_info PCIe protocol version 5
[ 2685.639620] brcmfmac: brcmf_pcie_init_share_ram_info max rx buf post 255, rx dataoffset 0
[ 2685.639633] brcmfmac: brcmf_pcie_bus_console_init Console: base 23debc, buf 23dab4, size 1024
[ 2685.639657] brcmfmac: brcmf_pcie_init_ringbuffers Using TCM indices
[ 2685.639712] brcmfmac: brcmf_pcie_init_ringbuffers Nr of flowrings is 40
[ 2685.639736] brcmfmac: brcmf_pcie_request_irq Enter
[ 2685.639822] brcmfmac 0000:03:00.0: irq 31 for MSI/MSI-X
[ 2685.640052] brcmfmac: brcmf_attach Enter
[ 2685.640202] brcmfmac: brcmf_proto_attach Enter
[ 2685.642347] brcmfmac: brcmf_pcie_ring_mb_write_wptr W w_ptr 255 (0), ring 1
[ 2685.642354] brcmfmac: brcmf_pcie_ring_mb_ring_bell RING !
[ 2685.642594] brcmfmac: brcmf_pcie_ring_mb_write_wptr W w_ptr 8 (0), ring 0
[ 2685.642599] brcmfmac: brcmf_pcie_ring_mb_ring_bell RING !
[ 2685.642790] brcmfmac: brcmf_pcie_ring_mb_write_wptr W w_ptr 16 (0), ring 0
[ 2685.642796] brcmfmac: brcmf_pcie_ring_mb_ring_bell RING !
[ 2685.642838] brcmfmac: brcmf_fweh_register event handler registered for PSM_WATCHDOG
[ 2685.642846] brcmfmac: brcmf_bus_started 
[ 2685.642851] brcmfmac: brcmf_add_if Enter, bsscfgidx=0, ifidx=0
[ 2685.642855] brcmfmac: brcmf_add_if allocate netdev interface
[ 2685.642876] brcmfmac: brcmf_add_if  ==== pid:1c, if:wlan%d (00:00:00:00:00:00) created ===
[ 2685.642881] brcmfmac: brcmf_bus_change_state 0 -> 1
[ 2685.642996] brcmfmac: brcmf_pcie_ring_mb_write_wptr W w_ptr 17 (0), ring 0
[ 2685.643001] brcmfmac: brcmf_pcie_ring_mb_ring_bell RING !
[ 2685.701557] brcmfmac: brcmf_pcie_quick_check_isr Enter
[ 2685.701602] brcmfmac: brcmf_pcie_isr_thread Enter 100
[ 2685.701613] brcmfmac: brcmf_pcie_handle_mb_data D2H_MB_DATA: 0x10000000
[ 2685.701634] brcmfmac: CONSOLE: 0d
[ 2685.701706] brcmfmac: CONSOLE: 000000.049 sp+ec 00184635
[ 2685.701778] brcmfmac: CONSOLE: 000000.049 sp+f4 00182ca7
[ 2685.701854] brcmfmac: CONSOLE: 000000.049 sp+100 000001df
[ 2685.701928] brcmfmac: CONSOLE: 000000.049 sp+140 0000823f
[ 2685.702003] brcmfmac: CONSOLE: 000000.049 sp+150 0018b8d9
[ 2687.642667] brcmfmac: brcmf_msgbuf_query_dcmd: Timeout on response for query command
[ 2687.650464] brcmfmac: brcmf_fil_cmd_data Failed: BCME_NOTDOWN (-5)
[ 2687.650469] brcmfmac: brcmf_fil_iovar_data_get ifidx=0, name=cur_etheraddr, len=6
[ 2687.650471] brcmutil: data
[ 2687.650475] 00000000: 00 00 00 00 00 00                                ......
[ 2687.650479] brcmfmac: brcmf_c_preinit_dcmds: Retreiving cur_etheraddr failed, -5
[ 2687.658056] brcmfmac: brcmf_bus_started: failed: -5
[ 2687.663054] brcmfmac: brcmf_pcie_attach_bus: dongle is not responding
[ 2687.669658] brcmfmac: brcmf_pcie_remove Enter
[ 2687.669664] brcmfmac: brcmf_detach Enter
[ 2687.672761] brcmfmac: brcmf_bus_change_state 1 -> 0
[ 2687.672767] brcmfmac: brcmf_proto_detach Enter
[ 2687.672770] brcmfmac: brcmf_proto_msgbuf_detach Enter
[ 2687.674601] brcmfmac: brcmf_fweh_unregister event handler cleared for PSM_WATCHDOG
[ 2687.826671] brcmfmac: brcmf_pcie_reset_device config offset 0x0004, value 0x100106
[ 2687.826681] brcmfmac: brcmf_pcie_reset_device config offset 0x004c, value 0x4008
[ 2687.826689] brcmfmac: brcmf_pcie_reset_device config offset 0x0058, value 0x886805
[ 2687.826696] brcmfmac: brcmf_pcie_reset_device config offset 0x005c, value 0xfee0300c
[ 2687.826702] brcmfmac: brcmf_pcie_reset_device config offset 0x0060, value 0x0000
[ 2687.826709] brcmfmac: brcmf_pcie_reset_device config offset 0x0064, value 0x4192
[ 2687.826716] brcmfmac: brcmf_pcie_reset_device config offset 0x00dc, value 0x10001
[ 2687.826722] brcmfmac: brcmf_pcie_reset_device config offset 0x0228, value 0x0222
[ 2687.826729] brcmfmac: brcmf_pcie_reset_device config offset 0x0248, value 0x0000
[ 2687.826735] brcmfmac: brcmf_pcie_reset_device config offset 0x04e0, value 0x0017
[ 2687.826742] brcmfmac: brcmf_pcie_reset_device config offset 0x04f4, value 0x0000

Re: BCM4356 does not initalize after firmware update

[Arend van Spriel]

On 12/14/2017 3:22 PM, Stanislaw Gruszka wrote:
> On Thu, Dec 14, 2017 at 10:13:29AM +0100, Arend van Spriel wrote:
>> The cur_etheraddr is the first piece of info we try to get from the
>> firmware. Could you build the driver with CONFIG_BRCMDBG and load
>> the module with 'debug=0x181416'.
>
> dmesg attached.

So the firmware console output in the dmesg shows partial stack trace 
which clearly means the firmware crashed.

[ 2685.701602] brcmfmac: brcmf_pcie_isr_thread Enter 100
[ 2685.701613] brcmfmac: brcmf_pcie_handle_mb_data D2H_MB_DATA: 0x10000000
[ 2685.701634] brcmfmac: CONSOLE: 0d
[ 2685.701706] brcmfmac: CONSOLE: 000000.049 sp+ec 00184635
[ 2685.701778] brcmfmac: CONSOLE: 000000.049 sp+f4 00182ca7
[ 2685.701854] brcmfmac: CONSOLE: 000000.049 sp+100 000001df
[ 2685.701928] brcmfmac: CONSOLE: 000000.049 sp+140 0000823f
[ 2685.702003] brcmfmac: CONSOLE: 000000.049 sp+150 0018b8d9
[ 2687.642667] brcmfmac: brcmf_msgbuf_query_dcmd: Timeout on response 
for query command
[ 2687.650464] brcmfmac: brcmf_fil_cmd_data Failed: BCME_NOTDOWN (-5)
[ 2687.650469] brcmfmac: brcmf_fil_iovar_data_get ifidx=0, 
name=cur_etheraddr, len=6
[ 2687.650471] brcmutil: data
[ 2687.650475] 00000000: 00 00 00 00 00 00 
   ......
[ 2687.650479] brcmfmac: brcmf_c_preinit_dcmds: Retreiving cur_etheraddr 
failed, -5

I noticed you are not using a nvram file. Do you know if one was 
orignally provided with the device?

Regards,
Arend

Re: BCM4356 does not initalize after firmware update

[Stanislaw Gruszka]

On Fri, Dec 15, 2017 at 10:58:10AM +0100, Arend van Spriel wrote:
> On 12/14/2017 3:22 PM, Stanislaw Gruszka wrote:
> >On Thu, Dec 14, 2017 at 10:13:29AM +0100, Arend van Spriel wrote:
> >>The cur_etheraddr is the first piece of info we try to get from the
> >>firmware. Could you build the driver with CONFIG_BRCMDBG and load
> >>the module with 'debug=0x181416'.
> >
> >dmesg attached.
> 
> So the firmware console output in the dmesg shows partial stack
> trace which clearly means the firmware crashed.
> 
> [ 2685.701602] brcmfmac: brcmf_pcie_isr_thread Enter 100
> [ 2685.701613] brcmfmac: brcmf_pcie_handle_mb_data D2H_MB_DATA: 0x10000000
> [ 2685.701634] brcmfmac: CONSOLE: 0d
> [ 2685.701706] brcmfmac: CONSOLE: 000000.049 sp+ec 00184635
> [ 2685.701778] brcmfmac: CONSOLE: 000000.049 sp+f4 00182ca7
> [ 2685.701854] brcmfmac: CONSOLE: 000000.049 sp+100 000001df
> [ 2685.701928] brcmfmac: CONSOLE: 000000.049 sp+140 0000823f
> [ 2685.702003] brcmfmac: CONSOLE: 000000.049 sp+150 0018b8d9
> [ 2687.642667] brcmfmac: brcmf_msgbuf_query_dcmd: Timeout on
> response for query command
> [ 2687.650464] brcmfmac: brcmf_fil_cmd_data Failed: BCME_NOTDOWN (-5)
> [ 2687.650469] brcmfmac: brcmf_fil_iovar_data_get ifidx=0,
> name=cur_etheraddr, len=6
> [ 2687.650471] brcmutil: data
> [ 2687.650475] 00000000: 00 00 00 00 00 00   ......
> [ 2687.650479] brcmfmac: brcmf_c_preinit_dcmds: Retreiving
> cur_etheraddr failed, -5
> 
> I noticed you are not using a nvram file. Do you know if one was
> orignally provided with the device?

I think it was not. The device was bought and setup in Fedora/RHEL
machine, which do not include any extra brcmfmac nvram file.

Thanks
Stanislaw

Re: BCM4356 does not initalize after firmware update

[Arend van Spriel]

On 12/15/2017 11:32 AM, Stanislaw Gruszka wrote:
> On Fri, Dec 15, 2017 at 10:58:10AM +0100, Arend van Spriel wrote:
>> On 12/14/2017 3:22 PM, Stanislaw Gruszka wrote:
>>> On Thu, Dec 14, 2017 at 10:13:29AM +0100, Arend van Spriel wrote:
>>>> The cur_etheraddr is the first piece of info we try to get from the
>>>> firmware. Could you build the driver with CONFIG_BRCMDBG and load
>>>> the module with 'debug=0x181416'.
>>>
>>> dmesg attached.
>>
>> So the firmware console output in the dmesg shows partial stack
>> trace which clearly means the firmware crashed.
>>
>> [ 2685.701602] brcmfmac: brcmf_pcie_isr_thread Enter 100
>> [ 2685.701613] brcmfmac: brcmf_pcie_handle_mb_data D2H_MB_DATA: 0x10000000
>> [ 2685.701634] brcmfmac: CONSOLE: 0d
>> [ 2685.701706] brcmfmac: CONSOLE: 000000.049 sp+ec 00184635
>> [ 2685.701778] brcmfmac: CONSOLE: 000000.049 sp+f4 00182ca7
>> [ 2685.701854] brcmfmac: CONSOLE: 000000.049 sp+100 000001df
>> [ 2685.701928] brcmfmac: CONSOLE: 000000.049 sp+140 0000823f
>> [ 2685.702003] brcmfmac: CONSOLE: 000000.049 sp+150 0018b8d9
>> [ 2687.642667] brcmfmac: brcmf_msgbuf_query_dcmd: Timeout on
>> response for query command
>> [ 2687.650464] brcmfmac: brcmf_fil_cmd_data Failed: BCME_NOTDOWN (-5)
>> [ 2687.650469] brcmfmac: brcmf_fil_iovar_data_get ifidx=0,
>> name=cur_etheraddr, len=6
>> [ 2687.650471] brcmutil: data
>> [ 2687.650475] 00000000: 00 00 00 00 00 00   ......
>> [ 2687.650479] brcmfmac: brcmf_c_preinit_dcmds: Retreiving
>> cur_etheraddr failed, -5
>>
>> I noticed you are not using a nvram file. Do you know if one was
>> orignally provided with the device?
>
> I think it was not. The device was bought and setup in Fedora/RHEL
> machine, which do not include any extra brcmfmac nvram file.

If the supplier of the device did not include such file it is probably 
not needed.

When using the old (working) firmware could you dump revinfo file in 
debugfs, ie.:

# cat /sys/kernel/debug/brcmfmac/0000:03:00.0/revinfo

Thanks,
Arend

Re: BCM4356 does not initalize after firmware update

[Stanislaw Gruszka]

On Fri, Dec 15, 2017 at 12:10:34PM +0100, Arend van Spriel wrote:
> # cat /sys/kernel/debug/brcmfmac/0000:03:00.0/revinfo

vendorid: 0x14e4
deviceid: 0x43ec
radiorev: 0.41.32.105
chipnum: 17238 (4356)
chiprev: 2
chippkg: 2
corerev: 48
boardid: 0x0777
boardvendor: 0x14e4
boardrev: P103
driverrev: 7.35.180.119
ucoderev: 0
bus: 0
phytype: 11
phyrev: 17
anarev: 0
nvramrev: 00000000

Regards
Stanislaw

Re: BCM4356 does not initalize after firmware update

[Arend van Spriel]

On 12/15/2017 1:20 PM, Stanislaw Gruszka wrote:
> On Fri, Dec 15, 2017 at 12:10:34PM +0100, Arend van Spriel wrote:
>> # cat /sys/kernel/debug/brcmfmac/0000:03:00.0/revinfo
>
> vendorid: 0x14e4
> deviceid: 0x43ec
> radiorev: 0.41.32.105
> chipnum: 17238 (4356)
> chiprev: 2
> chippkg: 2
> corerev: 48
> boardid: 0x0777
> boardvendor: 0x14e4
> boardrev: P103
> driverrev: 7.35.180.119
> ucoderev: 0
> bus: 0
> phytype: 11
> phyrev: 17
> anarev: 0
> nvramrev: 00000000

Thanks for the info. I was looking for the board info. It seems we do 
not have an nvram file for that specific board.

For SDIO devices I would suggest to use the module parameter 
'ignore_probe_fail' so we could do post-mortem stuff with the driver 
bound to the device, but for PCIe there are not much debug options. Let 
me work on that. May take a bit longer though.

Regards,
Arend

Re: BCM4356 does not initalize after firmware update

[Stanislaw Gruszka]

On Tue, Dec 19, 2017 at 12:36:36PM +0100, Arend van Spriel wrote:
> On 12/15/2017 1:20 PM, Stanislaw Gruszka wrote:
> >On Fri, Dec 15, 2017 at 12:10:34PM +0100, Arend van Spriel wrote:
> >># cat /sys/kernel/debug/brcmfmac/0000:03:00.0/revinfo
> >
> >vendorid: 0x14e4
> >deviceid: 0x43ec
> >radiorev: 0.41.32.105
> >chipnum: 17238 (4356)
> >chiprev: 2
> >chippkg: 2
> >corerev: 48
> >boardid: 0x0777
> >boardvendor: 0x14e4
> >boardrev: P103
> >driverrev: 7.35.180.119
> >ucoderev: 0
> >bus: 0
> >phytype: 11
> >phyrev: 17
> >anarev: 0
> >nvramrev: 00000000
> 
> Thanks for the info. I was looking for the board info. It seems we
> do not have an nvram file for that specific board.
> 
> For SDIO devices I would suggest to use the module parameter
> 'ignore_probe_fail' so we could do post-mortem stuff with the driver
> bound to the device, but for PCIe there are not much debug options.
> Let me work on that. May take a bit longer though.

What about the revert of the firmware change if proper
fix can not be soon available ?

Cheers
Stanislaw

Re: BCM4356 does not initalize after firmware update

[Arend van Spriel]

[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]

On 12/19/2017 1:23 PM, Stanislaw Gruszka wrote:
> On Tue, Dec 19, 2017 at 12:36:36PM +0100, Arend van Spriel wrote:
>> On 12/15/2017 1:20 PM, Stanislaw Gruszka wrote:
>>> On Fri, Dec 15, 2017 at 12:10:34PM +0100, Arend van Spriel wrote:
>>>> # cat /sys/kernel/debug/brcmfmac/0000:03:00.0/revinfo
>>>
>>> vendorid: 0x14e4
>>> deviceid: 0x43ec
>>> radiorev: 0.41.32.105
>>> chipnum: 17238 (4356)
>>> chiprev: 2
>>> chippkg: 2
>>> corerev: 48
>>> boardid: 0x0777
>>> boardvendor: 0x14e4
>>> boardrev: P103
>>> driverrev: 7.35.180.119
>>> ucoderev: 0
>>> bus: 0
>>> phytype: 11
>>> phyrev: 17
>>> anarev: 0
>>> nvramrev: 00000000
>>
>> Thanks for the info. I was looking for the board info. It seems we
>> do not have an nvram file for that specific board.
>>
>> For SDIO devices I would suggest to use the module parameter
>> 'ignore_probe_fail' so we could do post-mortem stuff with the driver
>> bound to the device, but for PCIe there are not much debug options.
>> Let me work on that. May take a bit longer though.
>
> What about the revert of the firmware change if proper
> fix can not be soon available ?

Hi Stanislaw,

I had my colleague run some tests as he has the device, but he is an 
ocean away. So he could get the new firmware running with nvram file. 
For the old firmware the device could boot without nvram, but the scan 
results were showing that the device was not operating optimally. Could 
you try the new firmware with the attached sample nvram file and let me 
know if that works for you?

Regards,
Arend


[-- Attachment #2: bcm94356wlpagbl.txt --]
[-- Type: text/plain, Size: 5075 bytes --]

# Sample variables file for BCM94356 WLBGA iPA, eLNA+switch board with PCIe for production package
# Following fields WILL be written into OTP

# Following fields WILL NOT be written in OTP  
# [NVRAM ONLY]
NVRAMRev=$Rev: 500242 $
sromrev=11
boardrev=0x1101
macaddr=00:90:4c:19:80:01
boardtype=0x0732
boardflags=0x12401201
#enable LNA1 bypass for both 2G & 5G
boardflags2=0x00802000
boardflags3=0x4800018a
#boardnum=57410 
ccode=0
regrev=0
antswitch=0
pdgain5g=4
pdgain2g=4
tworangetssi2g=0
tworangetssi5g=0
paprdis=0
femctrl=10
vendid=0x14e4
devid=0x43ec
manfid=0x2d0
#prodid=0x052e
nocrc=1
otpimagesize=484
xtalfreq=37400
rxgains2gtrelnabypa0=1
rxgains2gtrelnabypa1=1
#2G elna gain from datasheet is 14dB
#2G elna gain changed to 12dB
rxgains2gelnagaina0=3
rxgains2gelnagaina1=3
#triso values for 2G are picked from older nvram. Might need to change.
rxgains2gtrisoa0=6
rxgains2gtrisoa1=6
rxgains5gtrelnabypa0=1
rxgains5gmtrelnabypa0=1
rxgains5ghtrelnabypa0=1
rxgains5gtrelnabypa1=1
rxgains5gmtrelnabypa1=1
rxgains5ghtrelnabypa1=1
#5G elna gain from datasheet is 12dB
rxgains5gelnagaina0=3
rxgains5gmelnagaina0=3
rxgains5ghelnagaina0=3
rxgains5gelnagaina1=3
rxgains5gmelnagaina1=3
rxgains5ghelnagaina1=3
#triso values for 5G are picked from older nvram. Might need to change.
rxgains5gtrisoa0=5
rxgains5gmtrisoa0=6
rxgains5ghtrisoa0=6
rxgains5gtrisoa1=5
rxgains5gmtrisoa1=6
rxgains5ghtrisoa1=6
rxchain=3
txchain=3
aa2g=3
aa5g=3
agbg0=2
agbg1=2
aga0=2
aga1=2
tssipos2g=1
extpagain2g=2
tssipos5g=1
extpagain5g=2
tempthresh=120
tempoffset=255
rawtempsense=0x1ff
#pa2ga0=-98,6012,-652
#pa2ga1=-37,6488,-663
#pa5ga0=-74,5929,-633,-74,5928,-631,-57,5987,-615,-37,6048,-613
#pa5ga1=18,6630,-645,-8,6498,-665,47,6774,-637,26,6741,-651
#pa2ga0=-169,6154,-729
#pa2ga1=-149,6457,-741
#pa2ga0=-134,6229,-696_used 
#pa2ga1=-150,6023,-688_used
pa2ga0=-135,6154,-693
pa2ga1=-133,6240,-702
pa2gccka0=-128,6716,-762
pa2gccka1=-124,6801,-767
#pa5ga0=-163,6233,-728,-162,6270,-730,-170,6227,-730,-169,6213,-729_used
#pa5ga1=-171,6217,-734,-178,6130,-730,-176,6202,-734,-177,6175,-733_used
pa5ga0=-176,6230,-750,-167,6386,-758,-180,6285,-754,-182,6269,-759
pa5ga1=-197,5998,-740,-190,6158,-754,-200,6029,-742,-175,6414,-763
subband5gver=0x4
pdoffsetcckma0=0x0
pdoffsetcckma1=0x0
pdoffset40ma0=0x0000
pdoffset80ma0=0x0000
pdoffset40ma1=0x0000
pdoffset80ma1=0x0000
maxp2ga0=74
maxp5ga0=74,74,74,74
maxp2ga1=74
maxp5ga1=74,74,74,74
cckbw202gpo=0x0000
cckbw20ul2gpo=0x0000
mcsbw202gpo=0xa9855422
mcsbw402gpo=0xa9855422
dot11agofdmhrbw202gpo=0x5542
ofdmlrbw202gpo=0x0022
mcsbw205glpo=0xa9866663
mcsbw405glpo=0xa9866663
mcsbw805glpo=0xbb866665
mcsbw205gmpo=0xd9866663
mcsbw405gmpo=0xa9866663
mcsbw805gmpo=0xcc866665
mcsbw205ghpo=0xdc866663
mcsbw405ghpo=0xaa866663
mcsbw805ghpo=0xdd866665
mcslr5glpo=0x0000
mcslr5gmpo=0x0000
mcslr5ghpo=0x0000
sb20in40hrpo=0x0
sb20in80and160hr5glpo=0x0
sb40and80hr5glpo=0x0
sb20in80and160hr5gmpo=0x0
sb40and80hr5gmpo=0x0
sb20in80and160hr5ghpo=0x0
sb40and80hr5ghpo=0x0
sb20in40lrpo=0x0
sb20in80and160lr5glpo=0x0
sb40and80lr5glpo=0x0
sb20in80and160lr5gmpo=0x0
sb40and80lr5gmpo=0x0
sb20in80and160lr5ghpo=0x0
sb40and80lr5ghpo=0x0
dot11agduphrpo=0x0
dot11agduplrpo=0x0
phycal_tempdelta=25
temps_period=15
temps_hysteresis=15
AvVmid_c0=2,140,2,145,2,145,2,145,2,145
AvVmid_c1=2,140,2,145,2,145,2,145,2,145
AvVmid_c2=0,0,0,0,0,0,0,0,0,0
rssicorrnorm_c0=1,1
rssicorrnorm_c1=1,1
rssicorrnorm5g_c0=3,3,4,2,2,2,1,2,1,1,0,2
rssicorrnorm5g_c1=3,1,3,1,1,2,0,0,1,-1,0,1
epsdelta2g0=0
epsdelta2g1=0
ofdmfilttype=1
swctrlmap_2g=0x00001040,0xC0300000,0x40200000,0x803020,0x0ff
swctrlmap_5g=0x00000202,0x05050000,0x01010000,0x000000,0x047
swctrlmapext_5g=0x00000000,0x00000000,0x00000000,0x000000,0x000
swctrlmapext_2g=0x00000000,0x00000000,0x00000000,0x000000,0x000
ltecxmux=0x77540
btc_mode=1
papdwar=4
cckdigfilttype=4
phy4350_ss_opt=1
#PCIe Header Values
#pciehdr_00=0x380f
#pciehdr_01=0x3800
#pciehdr_02=${boardtype}
#pciehdr_03=${vendid}
#pciehdr_04=0x021c
#pciehdr_05=0x1b7e
#pciehdr_06=0x0a00
#pciehdr_07=0x0000
#pciehdr_08=0x0000
#pciehdr_09=0x0000
#pciehdr_10=0x0000
#pciehdr_11=0x0000
#pciehdr_12=0x00d4
#pciehdr_13=0x253c
#pciehdr_14=0x2164
#pciehdr_15=0x3203
#pciehdr_16=0x3e5f
#pciehdr_17=0x9605
#pciehdr_18=0x9f2f
#pciehdr_19=0x79b6
#pciehdr_20=0x8080
#pciehdr_21=0x0c03
#pciehdr_22=0x4000
#pciehdr_23=0x3240
#pciehdr_24=0x5f00
#pciehdr_25=0x4df4
#pciehdr_26=0x8090
#pciehdr_27=0xee00
#pciehdr_28=0x8630
#pciehdr_29=0x0180
#pciehdr_30=0x002b
#pciehdr_31=0x0000
#pciehdr_32=0x0000
#pciehdr_33=0x0000
#pciehdr_34=0x0000
#pciehdr_35=0x0000
#pciehdr_36=0x0000
#pciehdr_37=0x0000
#pciehdr_38=0x0000
#pciehdr_39=0x0000
#pciehdr_40=0x0000
#pciehdr_41=0x0000
#pciehdr_42=0x8800
#pciehdr_43=0x030a
#pciehdr_44=0x0160
#pciehdr_45=0x0000
#pciehdr_46=0x0000
#pciehdr_47=0x0000
#pciehdr_48=${devid}
#pciehdr_49=0x8000
#pciehdr_50=0x0002
#pciehdr_51=0x0000
#pciehdr_52=0x3ff5
#pciehdr_53=0x1800
#pciehdr_54=0x0000
#pciehdr_55=0x0000
#pciehdr_56=0x0000
#pciehdr_57=0x0000
#pciehdr_58=0x0000
#pciehdr_59=0x0000
#pciehdr_60=0x0000
#pciehdr_61=0x0000
#pciehdr_62=0x0000
#pciehdr_63=0x0000

Re: BCM4356 does not initalize after firmware update

[Stanislaw Gruszka]

Hi

On Wed, Dec 20, 2017 at 09:46:59AM +0100, Arend van Spriel wrote:
> I had my colleague run some tests as he has the device, but he is an ocean
> away. So he could get the new firmware running with nvram file. For the old
> firmware the device could boot without nvram, but the scan results were
> showing that the device was not operating optimally. Could you try the new
> firmware with the attached sample nvram file and let me know if that works
> for you?

Yes. After placing the nvram file to /lib/firmware/brcm/brcmfmac4356-pcie.txt
device now initalize with the new firmware. Is this right fix, IOW should this
file be shiped in linux-firmware ?

Thanks
Stanislaw