* [PATCH] scsi: qla2xxx: use dma_pool_zalloc instead
@ 2021-03-13 2:41 Wang Qing
2021-03-15 19:46 ` Himanshu Madhani
2021-03-19 3:46 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Wang Qing @ 2021-03-13 2:41 UTC (permalink / raw)
To: Nilesh Javali, GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, linux-kernel
Cc: Wang Qing
use dma_pool_zalloc instead of dma_pool_alloc and memset
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
drivers/scsi/qla2xxx/qla_os.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 0743925..ac5e954
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -4238,11 +4238,10 @@ qla2x00_mem_alloc(struct qla_hw_data *ha, uint16_t req_len, uint16_t rsp_len,
/* Get consistent memory allocated for Special Features-CB. */
if (IS_QLA27XX(ha) || IS_QLA28XX(ha)) {
- ha->sf_init_cb = dma_pool_alloc(ha->s_dma_pool, GFP_KERNEL,
+ ha->sf_init_cb = dma_pool_zalloc(ha->s_dma_pool, GFP_KERNEL,
&ha->sf_init_cb_dma);
if (!ha->sf_init_cb)
goto fail_sf_init_cb;
- memset(ha->sf_init_cb, 0, sizeof(struct init_sf_cb));
ql_dbg_pci(ql_dbg_init, ha->pdev, 0x0199,
"sf_init_cb=%p.\n", ha->sf_init_cb);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qla2xxx: use dma_pool_zalloc instead
2021-03-13 2:41 [PATCH] scsi: qla2xxx: use dma_pool_zalloc instead Wang Qing
@ 2021-03-15 19:46 ` Himanshu Madhani
2021-03-19 3:46 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Himanshu Madhani @ 2021-03-15 19:46 UTC (permalink / raw)
To: Wang Qing
Cc: Nilesh Javali, GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin Petersen, linux-scsi, linux-kernel
> On Mar 12, 2021, at 8:41 PM, Wang Qing <wangqing@vivo.com> wrote:
>
> use dma_pool_zalloc instead of dma_pool_alloc and memset
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index 0743925..ac5e954
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -4238,11 +4238,10 @@ qla2x00_mem_alloc(struct qla_hw_data *ha, uint16_t req_len, uint16_t rsp_len,
>
> /* Get consistent memory allocated for Special Features-CB. */
> if (IS_QLA27XX(ha) || IS_QLA28XX(ha)) {
> - ha->sf_init_cb = dma_pool_alloc(ha->s_dma_pool, GFP_KERNEL,
> + ha->sf_init_cb = dma_pool_zalloc(ha->s_dma_pool, GFP_KERNEL,
> &ha->sf_init_cb_dma);
> if (!ha->sf_init_cb)
> goto fail_sf_init_cb;
> - memset(ha->sf_init_cb, 0, sizeof(struct init_sf_cb));
> ql_dbg_pci(ql_dbg_init, ha->pdev, 0x0199,
> "sf_init_cb=%p.\n", ha->sf_init_cb);
> }
> --
> 2.7.4
>
Looks Good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qla2xxx: use dma_pool_zalloc instead
2021-03-13 2:41 [PATCH] scsi: qla2xxx: use dma_pool_zalloc instead Wang Qing
2021-03-15 19:46 ` Himanshu Madhani
@ 2021-03-19 3:46 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-03-19 3:46 UTC (permalink / raw)
To: Nilesh Javali, linux-kernel, James E.J. Bottomley, Wang Qing,
GR-QLogic-Storage-Upstream, linux-scsi
Cc: Martin K . Petersen
On Sat, 13 Mar 2021 10:41:15 +0800, Wang Qing wrote:
> use dma_pool_zalloc instead of dma_pool_alloc and memset
Applied to 5.13/scsi-queue, thanks!
[1/1] scsi: qla2xxx: use dma_pool_zalloc instead
https://git.kernel.org/mkp/scsi/c/720efdd23f96
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-19 3:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-13 2:41 [PATCH] scsi: qla2xxx: use dma_pool_zalloc instead Wang Qing
2021-03-15 19:46 ` Himanshu Madhani
2021-03-19 3:46 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.