* [Ocfs2-devel] [PATCH] ocfs2/dlm: clean unrelated comment
@ 2018-02-23 7:30 ge.changwei at h3c.com
2018-02-23 9:13 ` piaojun
2018-02-23 10:16 ` Joseph Qi
0 siblings, 2 replies; 5+ messages in thread
From: ge.changwei at h3c.com @ 2018-02-23 7:30 UTC (permalink / raw)
To: ocfs2-devel
From: Changwei Ge <ge.changwei@h3c.com>
Obviously, the comment before dlm_do_local_recovery_cleanup() has
nothing to do with it. So remove it.
Signed-off-by: Changwei Ge <ge.changwei@h3c.com>
---
fs/ocfs2/dlm/dlmrecovery.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
index ec8f758..65f0c54 100644
--- a/fs/ocfs2/dlm/dlmrecovery.c
+++ b/fs/ocfs2/dlm/dlmrecovery.c
@@ -2331,13 +2331,6 @@ static void dlm_free_dead_locks(struct dlm_ctxt *dlm,
__dlm_dirty_lockres(dlm, res);
}
-/* if this node is the recovery master, and there are no
- * locks for a given lockres owned by this node that are in
- * either PR or EX mode, zero out the lvb before requesting.
- *
- */
-
-
static void dlm_do_local_recovery_cleanup(struct dlm_ctxt *dlm, u8 dead_node)
{
struct dlm_lock_resource *res;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2/dlm: clean unrelated comment
2018-02-23 7:30 [Ocfs2-devel] [PATCH] ocfs2/dlm: clean unrelated comment ge.changwei at h3c.com
@ 2018-02-23 9:13 ` piaojun
2018-02-23 9:55 ` Changwei Ge
2018-02-23 10:16 ` Joseph Qi
1 sibling, 1 reply; 5+ messages in thread
From: piaojun @ 2018-02-23 9:13 UTC (permalink / raw)
To: ocfs2-devel
Hi changwei,
On 2018/2/23 15:30, ge.changwei at h3c.com wrote:
> From: Changwei Ge <ge.changwei@h3c.com>
This line seems unnecessary, others looks good to me.
thanks,
Jun
>
> Obviously, the comment before dlm_do_local_recovery_cleanup() has
> nothing to do with it. So remove it.
>
> Signed-off-by: Changwei Ge <ge.changwei@h3c.com>
> ---
> fs/ocfs2/dlm/dlmrecovery.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
> index ec8f758..65f0c54 100644
> --- a/fs/ocfs2/dlm/dlmrecovery.c
> +++ b/fs/ocfs2/dlm/dlmrecovery.c
> @@ -2331,13 +2331,6 @@ static void dlm_free_dead_locks(struct dlm_ctxt *dlm,
> __dlm_dirty_lockres(dlm, res);
> }
>
> -/* if this node is the recovery master, and there are no
> - * locks for a given lockres owned by this node that are in
> - * either PR or EX mode, zero out the lvb before requesting.
> - *
> - */
> -
> -
> static void dlm_do_local_recovery_cleanup(struct dlm_ctxt *dlm, u8 dead_node)
> {
> struct dlm_lock_resource *res;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2/dlm: clean unrelated comment
2018-02-23 9:13 ` piaojun
@ 2018-02-23 9:55 ` Changwei Ge
2018-02-24 6:42 ` piaojun
0 siblings, 1 reply; 5+ messages in thread
From: Changwei Ge @ 2018-02-23 9:55 UTC (permalink / raw)
To: ocfs2-devel
Hi Jun,
On 2018/2/23 17:13, piaojun wrote:
> Hi changwei,
>
> On 2018/2/23 15:30, ge.changwei at h3c.com wrote:
>> From: Changwei Ge <ge.changwei@h3c.com>
> This line seems unnecessary, others looks good to me.
I used git send-email, thus this line was added by parameter --from.
I suppose you could ignore it if it seems strange to you:-)
Thanks,
Changwei
>
> thanks,
> Jun
>>
>> Obviously, the comment before dlm_do_local_recovery_cleanup() has
>> nothing to do with it. So remove it.
>>
>> Signed-off-by: Changwei Ge <ge.changwei@h3c.com>
>> ---
>> fs/ocfs2/dlm/dlmrecovery.c | 7 -------
>> 1 file changed, 7 deletions(-)
>>
>> diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
>> index ec8f758..65f0c54 100644
>> --- a/fs/ocfs2/dlm/dlmrecovery.c
>> +++ b/fs/ocfs2/dlm/dlmrecovery.c
>> @@ -2331,13 +2331,6 @@ static void dlm_free_dead_locks(struct dlm_ctxt *dlm,
>> __dlm_dirty_lockres(dlm, res);
>> }
>>
>> -/* if this node is the recovery master, and there are no
>> - * locks for a given lockres owned by this node that are in
>> - * either PR or EX mode, zero out the lvb before requesting.
>> - *
>> - */
>> -
>> -
>> static void dlm_do_local_recovery_cleanup(struct dlm_ctxt *dlm, u8 dead_node)
>> {
>> struct dlm_lock_resource *res;
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2/dlm: clean unrelated comment
2018-02-23 7:30 [Ocfs2-devel] [PATCH] ocfs2/dlm: clean unrelated comment ge.changwei at h3c.com
2018-02-23 9:13 ` piaojun
@ 2018-02-23 10:16 ` Joseph Qi
1 sibling, 0 replies; 5+ messages in thread
From: Joseph Qi @ 2018-02-23 10:16 UTC (permalink / raw)
To: ocfs2-devel
On 18/2/23 15:30, ge.changwei at h3c.com wrote:
> From: Changwei Ge <ge.changwei@h3c.com>
>
> Obviously, the comment before dlm_do_local_recovery_cleanup() has
> nothing to do with it. So remove it.
>
> Signed-off-by: Changwei Ge <ge.changwei@h3c.com>
It seems to say we can no longer trust the lvb in this case. Maybe it
should be placed somewhere to call dlm_revalidate_lvb()?
Anyway, this cleanup looks good to me.
Acked-by: Joseph Qi <jiangqi903@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2/dlm: clean unrelated comment
2018-02-23 9:55 ` Changwei Ge
@ 2018-02-24 6:42 ` piaojun
0 siblings, 0 replies; 5+ messages in thread
From: piaojun @ 2018-02-24 6:42 UTC (permalink / raw)
To: ocfs2-devel
Hi Changwei,
On 2018/2/23 17:55, Changwei Ge wrote:
> Hi Jun,
>
> On 2018/2/23 17:13, piaojun wrote:
>> Hi changwei,
>>
>> On 2018/2/23 15:30, ge.changwei at h3c.com wrote:
>>> From: Changwei Ge <ge.changwei@h3c.com>
>> This line seems unnecessary, others looks good to me.
> I used git send-email, thus this line was added by parameter --from.
> I suppose you could ignore it if it seems strange to you:-)
If this won't affect the patch format, you could add:
Reviewed-by: Jun Piao <piaojun@huawei.com>
thanks,
Jun
>
> Thanks,
> Changwei
>
>>
>> thanks,
>> Jun
>>>
>>> Obviously, the comment before dlm_do_local_recovery_cleanup() has
>>> nothing to do with it. So remove it.
>>>
>>> Signed-off-by: Changwei Ge <ge.changwei@h3c.com>
>>> ---
>>> fs/ocfs2/dlm/dlmrecovery.c | 7 -------
>>> 1 file changed, 7 deletions(-)
>>>
>>> diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
>>> index ec8f758..65f0c54 100644
>>> --- a/fs/ocfs2/dlm/dlmrecovery.c
>>> +++ b/fs/ocfs2/dlm/dlmrecovery.c
>>> @@ -2331,13 +2331,6 @@ static void dlm_free_dead_locks(struct dlm_ctxt *dlm,
>>> __dlm_dirty_lockres(dlm, res);
>>> }
>>>
>>> -/* if this node is the recovery master, and there are no
>>> - * locks for a given lockres owned by this node that are in
>>> - * either PR or EX mode, zero out the lvb before requesting.
>>> - *
>>> - */
>>> -
>>> -
>>> static void dlm_do_local_recovery_cleanup(struct dlm_ctxt *dlm, u8 dead_node)
>>> {
>>> struct dlm_lock_resource *res;
>>>
>>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-24 6:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-23 7:30 [Ocfs2-devel] [PATCH] ocfs2/dlm: clean unrelated comment ge.changwei at h3c.com
2018-02-23 9:13 ` piaojun
2018-02-23 9:55 ` Changwei Ge
2018-02-24 6:42 ` piaojun
2018-02-23 10:16 ` Joseph Qi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.