[PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[Lars Kurth]

x86/Emulated platform devices (QEMU):
- Aded PCI host bridge (as in xen.git:docs/misc/qemu-xen-security)
New: x86/Emulated Storage Image Formats
- Added raw, qcow, qcow2, vhd (as in xen.git:docs/misc/qemu-xen-security)
x86/Emulated graphics (QEMU)
- Fixed typo (stdvga)
- Added xenfb (as in xen.git:docs/misc/qemu-xen-security)
x86/Emulated input (QEMU):
- Added xenfb keyboard/mouse (as in xen.git:docs/misc/qemu-xen-security)

Delete xen.git:docs/misc/qemu-xen-security as now not needed

Signed-off-by: Lars Kurth  <lars.kurth@citrix.com>
---
 SUPPORT.md                  | 15 +++++++++++++--
 docs/misc/qemu-xen-security | 21 ---------------------
 2 files changed, 13 insertions(+), 23 deletions(-)
 delete mode 100644 docs/misc/qemu-xen-security

diff --git a/SUPPORT.md b/SUPPORT.md
index 42ffa9fa4d..abf7ce2554 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -620,6 +620,7 @@ Note that other devices are available but not security supported.
 
 ### x86/Emulated platform devices (QEMU):
 
+    Status, PCI host bridge: Supported
     Status, piix3: Supported
 
 ### x86/Emulated network (QEMU):
@@ -633,10 +634,18 @@ Note that other devices are available but not security supported.
     Status, piix3 ide: Supported
     Status, ahci: Supported
 
+### x86/Emulated Storage Image Formats (QEMU):
+
+    Status, raw: Supported
+    Status, qcow: Supported
+    Status, qcow2: Supported
+    Status, vhd: Supported
+    
 ### x86/Emulated graphics (QEMU):
 
     Status, cirrus-vga: Supported
-    Status, stgvga: Supported
+    Status, stdvga: Supported
+    Status, xenfb: Supported
 
 ### x86/Emulated audio (QEMU):
 
@@ -650,7 +659,9 @@ Note that other devices are available but not security supported.
     Status, usbtablet: Supported
     Status, ps/2 keyboard: Supported
     Status, ps/2 mouse: Supported
-
+    Status, xenfb keyboard: Supported
+    Status, xenfb mouse: Supported
+    
 ### x86/Emulated serial card (QEMU):
 
     Status, UART 16550A: Supported
diff --git a/docs/misc/qemu-xen-security b/docs/misc/qemu-xen-security
deleted file mode 100644
index 496f7eee7a..0000000000
--- a/docs/misc/qemu-xen-security
+++ /dev/null
@@ -1,21 +0,0 @@
-qemu-xen (git://xenbits.xen.org/qemu-xen.git) is only supported for
-security fixes when used together with the Xen hypervisor and only with
-a subset of all the possible QEMU emulators. Specifically:
-
-- network: e1000, rtl8139, virtio-net
-- storage: piix3 ide, ahci, xen_disk
-- backing storage image format: raw, qcow, qcow2, vhd
-- graphics: cirris-vga, stdvga and xenfb
-- audio: sb16, es1370, ac97
-- input: Xen PV keyboard and mouse (part of xenfb), USB and PS/2
-         keyboard and mouse
-- serial cards: UART 16550A
-
-Core components, such as the PCI host bridge and the PIIX3 chipset, are
-supported. All devices of one the above classes, which are not explicitly
-mentioned, are not supported. For example the ne2000 network card is not
-supported. 
-
-If you think that a specific emulated device should be supported, please
-contact the QEMU UPSTREAM maintainer and the Xen Security Team
-(security@xenproject.org).
-- 
2.13.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[Ian Jackson]

Lars Kurth writes ("[PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md"):
> x86/Emulated platform devices (QEMU):
> - Aded PCI host bridge (as in xen.git:docs/misc/qemu-xen-security)
> New: x86/Emulated Storage Image Formats
> - Added raw, qcow, qcow2, vhd (as in xen.git:docs/misc/qemu-xen-security)
> x86/Emulated graphics (QEMU)
> - Fixed typo (stdvga)
> - Added xenfb (as in xen.git:docs/misc/qemu-xen-security)
> x86/Emulated input (QEMU):
> - Added xenfb keyboard/mouse (as in xen.git:docs/misc/qemu-xen-security)
> 
> Delete xen.git:docs/misc/qemu-xen-security as now not needed

LGTM.  Thanks.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

We should wait a bit with committing in case someone wants to object
for some reason...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[Lars Kurth]

On 08/03/2018, 18:44, "Ian Jackson" <ian.jackson@citrix.com> wrote:

    Lars Kurth writes ("[PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md"):
    > x86/Emulated platform devices (QEMU):
    > - Aded PCI host bridge (as in xen.git:docs/misc/qemu-xen-security)
    > New: x86/Emulated Storage Image Formats
    > - Added raw, qcow, qcow2, vhd (as in xen.git:docs/misc/qemu-xen-security)
    > x86/Emulated graphics (QEMU)
    > - Fixed typo (stdvga)
    > - Added xenfb (as in xen.git:docs/misc/qemu-xen-security)
    > x86/Emulated input (QEMU):
    > - Added xenfb keyboard/mouse (as in xen.git:docs/misc/qemu-xen-security)
    > 
    > Delete xen.git:docs/misc/qemu-xen-security as now not needed
    
    LGTM.  Thanks.
    
    Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
    
    We should wait a bit with committing in case someone wants to object
    for some reason...
    
    Ian.
   
@Jan: this should be backported to 4.10 also
Lars

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[Jan Beulich]

>>> On 08.03.18 at 18:37, <lars.kurth@citrix.com> wrote:
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -620,6 +620,7 @@ Note that other devices are available but not security supported.
>  
>  ### x86/Emulated platform devices (QEMU):
>  
> +    Status, PCI host bridge: Supported
>      Status, piix3: Supported

That's way too generic imo: Any chipset will have a host bridge, so
its support is already included in the statement on which chipset
emulation(s) we support. By adding what you add, you could again
raise the expectation that any host bridge implementation in qemu
is supported.

>  ### x86/Emulated network (QEMU):
> @@ -633,10 +634,18 @@ Note that other devices are available but not security supported.
>      Status, piix3 ide: Supported
>      Status, ahci: Supported
>  
> +### x86/Emulated Storage Image Formats (QEMU):
> +
> +    Status, raw: Supported
> +    Status, qcow: Supported
> +    Status, qcow2: Supported
> +    Status, vhd: Supported
> +    
>  ### x86/Emulated graphics (QEMU):
>  
>      Status, cirrus-vga: Supported
> -    Status, stgvga: Supported
> +    Status, stdvga: Supported
> +    Status, xenfb: Supported

Just like xen_disk (correctly) isn't listed in the "x86/Emulated storage
(QEMU)" section, xenfb doesn't belong here imo. It's not an emulated
device, and is already enumerated in "PV Framebuffer (backend)"
(just not with the term "xenfb").

> @@ -650,7 +659,9 @@ Note that other devices are available but not security supported.
>      Status, usbtablet: Supported
>      Status, ps/2 keyboard: Supported
>      Status, ps/2 mouse: Supported
> -
> +    Status, xenfb keyboard: Supported
> +    Status, xenfb mouse: Supported

Similarly for these ones and "PV keyboard (backend)". Perhaps a
"PV mouse (backend)" section should be added.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[Jan Beulich]

>>> On 08.03.18 at 19:07, <lars.kurth@citrix.com> wrote:
> On 08/03/2018, 18:44, "Ian Jackson" <ian.jackson@citrix.com> wrote:
> 
>     Lars Kurth writes ("[PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md"):
>     > x86/Emulated platform devices (QEMU):
>     > - Aded PCI host bridge (as in xen.git:docs/misc/qemu-xen-security)
>     > New: x86/Emulated Storage Image Formats
>     > - Added raw, qcow, qcow2, vhd (as in xen.git:docs/misc/qemu-xen-security)
>     > x86/Emulated graphics (QEMU)
>     > - Fixed typo (stdvga)
>     > - Added xenfb (as in xen.git:docs/misc/qemu-xen-security)
>     > x86/Emulated input (QEMU):
>     > - Added xenfb keyboard/mouse (as in xen.git:docs/misc/qemu-xen-security)
>     > 
>     > Delete xen.git:docs/misc/qemu-xen-security as now not needed
>     
>     LGTM.  Thanks.
>     
>     Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>     
>     We should wait a bit with committing in case someone wants to object
>     for some reason...
>     
>     Ian.
>    
> @Jan: this should be backported to 4.10 also

I'll try to remember that, but let's first get it into master (and as
you've likely seen, I'm not entirely happy with this first version).

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[Lars Kurth]

On 09/03/2018, 11:07, "Jan Beulich" <JBeulich@suse.com> wrote:

    >>> On 08.03.18 at 18:37, <lars.kurth@citrix.com> wrote:
    > --- a/SUPPORT.md
    > +++ b/SUPPORT.md
    > @@ -620,6 +620,7 @@ Note that other devices are available but not security supported.
    >  
    >  ### x86/Emulated platform devices (QEMU):
    >  
    > +    Status, PCI host bridge: Supported
    >      Status, piix3: Supported
    
    That's way too generic imo: Any chipset will have a host bridge, so
    its support is already included in the statement on which chipset
    emulation(s) we support. By adding what you add, you could again
    raise the expectation that any host bridge implementation in qemu
    is supported.

I thought this may be an issue. I would be quite happy to change it, but would need to know how to phrase it.
Suggestions?
    
    >  ### x86/Emulated network (QEMU):
    > @@ -633,10 +634,18 @@ Note that other devices are available but not security supported.
    >      Status, piix3 ide: Supported
    >      Status, ahci: Supported
    >  
    > +### x86/Emulated Storage Image Formats (QEMU):
    > +
    > +    Status, raw: Supported
    > +    Status, qcow: Supported
    > +    Status, qcow2: Supported
    > +    Status, vhd: Supported
    > +    
    >  ### x86/Emulated graphics (QEMU):
    >  
    >      Status, cirrus-vga: Supported
    > -    Status, stgvga: Supported
    > +    Status, stdvga: Supported
    > +    Status, xenfb: Supported
    
    Just like xen_disk (correctly) isn't listed in the "x86/Emulated storage
    (QEMU)" section, xenfb doesn't belong here imo. It's not an emulated
    device, and is already enumerated in "PV Framebuffer (backend)"
    (just not with the term "xenfb").

So, what I read from this, the existing line 

### PV Framebuffer (backend)
    Status, QEMU: Supported

covers the back-end.
    
    > @@ -650,7 +659,9 @@ Note that other devices are available but not security supported.
    >      Status, usbtablet: Supported
    >      Status, ps/2 keyboard: Supported
    >      Status, ps/2 mouse: Supported
    > -
    > +    Status, xenfb keyboard: Supported
    > +    Status, xenfb mouse: Supported
    
    Similarly for these ones and "PV keyboard (backend)". Perhaps a
    "PV mouse (backend)" section should be added.
 
So to clarify, 

### PV keyboard (backend)
    Status, QEMU: Supported
### PV mouse (backend)
    Status, QEMU: Supported

would cover this in your view?

Does this cover all the bases, or did I miss anything? 
In other words, are there any frontend bits for xenfb (framebuffer, keyboard, mouse) that would need to be recorded somewhere

Regards
Lars

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[Lars Kurth]

On 09/03/2018, 11:08, "Jan Beulich" <JBeulich@suse.com> wrote:

    >>> On 08.03.18 at 19:07, <lars.kurth@citrix.com> wrote:

    > @Jan: this should be backported to 4.10 also
    
    I'll try to remember that, but let's first get it into master (and as
    you've likely seen, I'm not entirely happy with this first version).
    
I will remind you when the series is in. I wasn't sure whether there would be any more feedback.
Lars
    

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[George Dunlap]

On 03/09/2018 10:07 AM, Jan Beulich wrote:
>>>> On 08.03.18 at 18:37, <lars.kurth@citrix.com> wrote:
>> --- a/SUPPORT.md
>> +++ b/SUPPORT.md
>> @@ -620,6 +620,7 @@ Note that other devices are available but not security supported.
>>  
>>  ### x86/Emulated platform devices (QEMU):
>>  
>> +    Status, PCI host bridge: Supported
>>      Status, piix3: Supported
> 
> That's way too generic imo: Any chipset will have a host bridge, so
> its support is already included in the statement on which chipset
> emulation(s) we support. By adding what you add, you could again
> raise the expectation that any host bridge implementation in qemu
> is supported.

Yes, when I saw Lars' patch I was trying to remember why those things
weren't already copied over, and was pretty sure there was a good reason.

Are you saying, in effect, that "support for piix3" *implies* support
for the PCI host bridge provided by the piix3 chipset?

If so, "PCI host bridge" was redundant, and may have been put in before
piix3 was specified.

>>  ### x86/Emulated network (QEMU):
>> @@ -633,10 +634,18 @@ Note that other devices are available but not security supported.
>>      Status, piix3 ide: Supported
>>      Status, ahci: Supported
>>  
>> +### x86/Emulated Storage Image Formats (QEMU):
>> +
>> +    Status, raw: Supported
>> +    Status, qcow: Supported
>> +    Status, qcow2: Supported
>> +    Status, vhd: Supported
>> +    
>>  ### x86/Emulated graphics (QEMU):
>>  
>>      Status, cirrus-vga: Supported
>> -    Status, stgvga: Supported
>> +    Status, stdvga: Supported
>> +    Status, xenfb: Supported
> 
> Just like xen_disk (correctly) isn't listed in the "x86/Emulated storage
> (QEMU)" section, xenfb doesn't belong here imo. It's not an emulated
> device, and is already enumerated in "PV Framebuffer (backend)"
> (just not with the term "xenfb").
> 
>> @@ -650,7 +659,9 @@ Note that other devices are available but not security supported.
>>      Status, usbtablet: Supported
>>      Status, ps/2 keyboard: Supported
>>      Status, ps/2 mouse: Supported
>> -
>> +    Status, xenfb keyboard: Supported
>> +    Status, xenfb mouse: Supported
> 
> Similarly for these ones and "PV keyboard (backend)". 

Yes, I remember having this discussion.

> Perhaps a
> "PV mouse (backend)" section should be added.

+1

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[Julien Grall]

Hi Lars,

On 08/03/18 17:37, Lars Kurth wrote:
> x86/Emulated platform devices (QEMU):
> - Aded PCI host bridge (as in xen.git:docs/misc/qemu-xen-security)
> New: x86/Emulated Storage Image Formats
> - Added raw, qcow, qcow2, vhd (as in xen.git:docs/misc/qemu-xen-security)

Is there any reason to be x86/emulate storage only? If I am not 
mistaken, QEMU could also be used as PV block backend for all those 
image formats. That is also working on Arm.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[George Dunlap]

On 03/08/2018 06:07 PM, Lars Kurth wrote:
> 
> On 08/03/2018, 18:44, "Ian Jackson" <ian.jackson@citrix.com> wrote:
> 
>     Lars Kurth writes ("[PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md"):
>     > x86/Emulated platform devices (QEMU):
>     > - Aded PCI host bridge (as in xen.git:docs/misc/qemu-xen-security)
>     > New: x86/Emulated Storage Image Formats
>     > - Added raw, qcow, qcow2, vhd (as in xen.git:docs/misc/qemu-xen-security)
>     > x86/Emulated graphics (QEMU)
>     > - Fixed typo (stdvga)
>     > - Added xenfb (as in xen.git:docs/misc/qemu-xen-security)
>     > x86/Emulated input (QEMU):
>     > - Added xenfb keyboard/mouse (as in xen.git:docs/misc/qemu-xen-security)
>     > 
>     > Delete xen.git:docs/misc/qemu-xen-security as now not needed
>     
>     LGTM.  Thanks.
>     
>     Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>     
>     We should wait a bit with committing in case someone wants to object
>     for some reason...
>     
>     Ian.
>    
> @Jan: this should be backported to 4.10 also

I think we should backport any updates to SUPPORT.md, but I don't think
we should remove qemu-xen-security in 4.10.  That's not the kind of
thing we should really delete in a point release.

Lars, maybe when you re-submit you could make this two patches -- one to
update SUPPORT.md (which would be backported) and one to remove
qemu-xen-security (which would not be)?

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[Lars Kurth]

On 09/03/2018, 11:32, "George Dunlap" <george.dunlap@citrix.com> wrote:

    On 03/08/2018 06:07 PM, Lars Kurth wrote:
    > 
    > On 08/03/2018, 18:44, "Ian Jackson" <ian.jackson@citrix.com> wrote:
    > 
    >     Lars Kurth writes ("[PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md"):
    >     > x86/Emulated platform devices (QEMU):
    >     > - Aded PCI host bridge (as in xen.git:docs/misc/qemu-xen-security)
    >     > New: x86/Emulated Storage Image Formats
    >     > - Added raw, qcow, qcow2, vhd (as in xen.git:docs/misc/qemu-xen-security)
    >     > x86/Emulated graphics (QEMU)
    >     > - Fixed typo (stdvga)
    >     > - Added xenfb (as in xen.git:docs/misc/qemu-xen-security)
    >     > x86/Emulated input (QEMU):
    >     > - Added xenfb keyboard/mouse (as in xen.git:docs/misc/qemu-xen-security)
    >     > 
    >     > Delete xen.git:docs/misc/qemu-xen-security as now not needed
    >     
    >     LGTM.  Thanks.
    >     
    >     Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
    >     
    >     We should wait a bit with committing in case someone wants to object
    >     for some reason...
    >     
    >     Ian.
    >    
    > @Jan: this should be backported to 4.10 also
    
    I think we should backport any updates to SUPPORT.md, but I don't think
    we should remove qemu-xen-security in 4.10.  That's not the kind of
    thing we should really delete in a point release.
    
    Lars, maybe when you re-submit you could make this two patches -- one to
    update SUPPORT.md (which would be backported) and one to remove
    qemu-xen-security (which would not be)?

Sure. I will need you guys to help me put the right terminology in place for SUPPORT.md
I thought the task is more mechanical than it is

Lars
 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[Lars Kurth]

On 09/03/2018, 11:31, "Julien Grall" <julien.grall@arm.com> wrote:

    Hi Lars,
    
    On 08/03/18 17:37, Lars Kurth wrote:
    > x86/Emulated platform devices (QEMU):
    > - Aded PCI host bridge (as in xen.git:docs/misc/qemu-xen-security)
    > New: x86/Emulated Storage Image Formats
    > - Added raw, qcow, qcow2, vhd (as in xen.git:docs/misc/qemu-xen-security)
    
    Is there any reason to be x86/emulate storage only? If I am not 
    mistaken, QEMU could also be used as PV block backend for all those 
    image formats. That is also working on Arm.

The only reason, I did this, was because that is how it was phrased in qemu-xen-security
Lars
  

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[George Dunlap]

On 03/09/2018 10:31 AM, Julien Grall wrote:
> Hi Lars,
> 
> On 08/03/18 17:37, Lars Kurth wrote:
>> x86/Emulated platform devices (QEMU):
>> - Aded PCI host bridge (as in xen.git:docs/misc/qemu-xen-security)
>> New: x86/Emulated Storage Image Formats
>> - Added raw, qcow, qcow2, vhd (as in xen.git:docs/misc/qemu-xen-security)
> 
> Is there any reason to be x86/emulate storage only? If I am not
> mistaken, QEMU could also be used as PV block backend for all those
> image formats. That is also working on Arm.

Yes -- those formats are supported for any thing that uses qemu, either
emulated, or qdisk PV (available for PV guests and ARM guests as well).

But that would almost argue for breaking down the `### Blkback` section
so that we specify what formats are available and supported for each
individual backend.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[George Dunlap]

On 03/09/2018 10:34 AM, Lars Kurth wrote:
> 
> 
> On 09/03/2018, 11:32, "George Dunlap" <george.dunlap@citrix.com> wrote:
> 
>     On 03/08/2018 06:07 PM, Lars Kurth wrote:
>     > 
>     > On 08/03/2018, 18:44, "Ian Jackson" <ian.jackson@citrix.com> wrote:
>     > 
>     >     Lars Kurth writes ("[PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md"):
>     >     > x86/Emulated platform devices (QEMU):
>     >     > - Aded PCI host bridge (as in xen.git:docs/misc/qemu-xen-security)
>     >     > New: x86/Emulated Storage Image Formats
>     >     > - Added raw, qcow, qcow2, vhd (as in xen.git:docs/misc/qemu-xen-security)
>     >     > x86/Emulated graphics (QEMU)
>     >     > - Fixed typo (stdvga)
>     >     > - Added xenfb (as in xen.git:docs/misc/qemu-xen-security)
>     >     > x86/Emulated input (QEMU):
>     >     > - Added xenfb keyboard/mouse (as in xen.git:docs/misc/qemu-xen-security)
>     >     > 
>     >     > Delete xen.git:docs/misc/qemu-xen-security as now not needed
>     >     
>     >     LGTM.  Thanks.
>     >     
>     >     Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>     >     
>     >     We should wait a bit with committing in case someone wants to object
>     >     for some reason...
>     >     
>     >     Ian.
>     >    
>     > @Jan: this should be backported to 4.10 also
>     
>     I think we should backport any updates to SUPPORT.md, but I don't think
>     we should remove qemu-xen-security in 4.10.  That's not the kind of
>     thing we should really delete in a point release.
>     
>     Lars, maybe when you re-submit you could make this two patches -- one to
>     update SUPPORT.md (which would be backported) and one to remove
>     qemu-xen-security (which would not be)?
> 
> Sure. I will need you guys to help me put the right terminology in place for SUPPORT.md
> I thought the task is more mechanical than it is

You didn't learn from the interminable discussions we had revising
SUPPORT.md the first time around? :-)

If you want I can try to take this over -- it sounds like this isn't
quite what you signed up for.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[Lars Kurth]

On 09/03/2018, 11:38, "George Dunlap" <george.dunlap@citrix.com> wrote:

    On 03/09/2018 10:34 AM, Lars Kurth wrote:
    > 
    > On 09/03/2018, 11:32, "George Dunlap" <george.dunlap@citrix.com> wrote:
    > 
    >     On 03/08/2018 06:07 PM, Lars Kurth wrote:
    >     > 
    >     > @Jan: this should be backported to 4.10 also
    >     
    >     I think we should backport any updates to SUPPORT.md, but I don't think
    >     we should remove qemu-xen-security in 4.10.  That's not the kind of
    >     thing we should really delete in a point release.
    >     
    >     Lars, maybe when you re-submit you could make this two patches -- one to
    >     update SUPPORT.md (which would be backported) and one to remove
    >     qemu-xen-security (which would not be)?
    > 
    > Sure. I will need you guys to help me put the right terminology in place for SUPPORT.md
    > I thought the task is more mechanical than it is
    
    You didn't learn from the interminable discussions we had revising
    SUPPORT.md the first time around? :-)

I was on holidays, so didn’t follow it
    
    If you want I can try to take this over -- it sounds like this isn't
    quite what you signed up for.

If you could, that may make things a lot easier. This is obviously much less mechanical than I thought.
Alternatively, you could summarize the thread at the end and I can re-submit.  

Lars
 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[Jan Beulich]

>>> On 09.03.18 at 11:30, <george.dunlap@citrix.com> wrote:
> On 03/09/2018 10:07 AM, Jan Beulich wrote:
>>>>> On 08.03.18 at 18:37, <lars.kurth@citrix.com> wrote:
>>> --- a/SUPPORT.md
>>> +++ b/SUPPORT.md
>>> @@ -620,6 +620,7 @@ Note that other devices are available but not security supported.
>>>  
>>>  ### x86/Emulated platform devices (QEMU):
>>>  
>>> +    Status, PCI host bridge: Supported
>>>      Status, piix3: Supported
>> 
>> That's way too generic imo: Any chipset will have a host bridge, so
>> its support is already included in the statement on which chipset
>> emulation(s) we support. By adding what you add, you could again
>> raise the expectation that any host bridge implementation in qemu
>> is supported.
> 
> Yes, when I saw Lars' patch I was trying to remember why those things
> weren't already copied over, and was pretty sure there was a good reason.
> 
> Are you saying, in effect, that "support for piix3" *implies* support
> for the PCI host bridge provided by the piix3 chipset?

Yes.

> If so, "PCI host bridge" was redundant, and may have been put in before
> piix3 was specified.

Likely.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

[Jan Beulich]

>>> On 09.03.18 at 11:28, <lars.kurth@citrix.com> wrote:
> On 09/03/2018, 11:07, "Jan Beulich" <JBeulich@suse.com> wrote:
> 
>     >>> On 08.03.18 at 18:37, <lars.kurth@citrix.com> wrote:
>     > --- a/SUPPORT.md
>     > +++ b/SUPPORT.md
>     > @@ -620,6 +620,7 @@ Note that other devices are available but not security supported.
>     >  
>     >  ### x86/Emulated platform devices (QEMU):
>     >  
>     > +    Status, PCI host bridge: Supported
>     >      Status, piix3: Supported
>     
>     That's way too generic imo: Any chipset will have a host bridge, so
>     its support is already included in the statement on which chipset
>     emulation(s) we support. By adding what you add, you could again
>     raise the expectation that any host bridge implementation in qemu
>     is supported.
> 
> I thought this may be an issue. I would be quite happy to change it, but 
> would need to know how to phrase it.
> Suggestions?

Just drop this addition of a line.

>     >  ### x86/Emulated graphics (QEMU):
>     >  
>     >      Status, cirrus-vga: Supported
>     > -    Status, stgvga: Supported
>     > +    Status, stdvga: Supported
>     > +    Status, xenfb: Supported
>     
>     Just like xen_disk (correctly) isn't listed in the "x86/Emulated storage
>     (QEMU)" section, xenfb doesn't belong here imo. It's not an emulated
>     device, and is already enumerated in "PV Framebuffer (backend)"
>     (just not with the term "xenfb").
> 
> So, what I read from this, the existing line 
> 
> ### PV Framebuffer (backend)
>     Status, QEMU: Supported
> 
> covers the back-end.

Yes.

>     > @@ -650,7 +659,9 @@ Note that other devices are available but not security supported.
>     >      Status, usbtablet: Supported
>     >      Status, ps/2 keyboard: Supported
>     >      Status, ps/2 mouse: Supported
>     > -
>     > +    Status, xenfb keyboard: Supported
>     > +    Status, xenfb mouse: Supported
>     
>     Similarly for these ones and "PV keyboard (backend)". Perhaps a
>     "PV mouse (backend)" section should be added.
>  
> So to clarify, 
> 
> ### PV keyboard (backend)
>     Status, QEMU: Supported
> ### PV mouse (backend)
>     Status, QEMU: Supported
> 
> would cover this in your view?

Yes.

> Does this cover all the bases, or did I miss anything? 

With s/bases/backends/ - yes, I think so.

> In other words, are there any frontend bits for xenfb (framebuffer, 
> keyboard, mouse) that would need to be recorded somewhere

The frontend are in the guest OSes anyway, and they all have their
own sections (looks like as for the backends there's "keyboard" but
not "mouse"; in both cases not unlikely because they live close
together).

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel