* [Ocfs2-devel] [PATCH] ocfs2: clean up redundant function declarations
@ 2018-04-21 11:41 Jia Guo
2018-04-23 2:36 ` Gang He
2018-04-23 10:51 ` Joseph Qi
0 siblings, 2 replies; 3+ messages in thread
From: Jia Guo @ 2018-04-21 11:41 UTC (permalink / raw)
To: ocfs2-devel
The function ocfs2_extend_allocation has been deleted, clean up its
declaration.
Fixes: 964f14a0d350 ("ocfs2: clean up some dead code")
Signed-off-by: Jia Guo <guojia12@huawei.com>
Reviewed-by: Jun Piao <piaojun@huawei.com>
---
fs/ocfs2/file.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/ocfs2/file.h b/fs/ocfs2/file.h
index 1fdc983..7eb7f03 100644
--- a/fs/ocfs2/file.h
+++ b/fs/ocfs2/file.h
@@ -65,8 +65,6 @@ int ocfs2_extend_no_holes(struct inode *inode, struct buffer_head *di_bh,
u64 new_i_size, u64 zero_to);
int ocfs2_zero_extend(struct inode *inode, struct buffer_head *di_bh,
loff_t zero_to);
-int ocfs2_extend_allocation(struct inode *inode, u32 logical_start,
- u32 clusters_to_add, int mark_unwritten);
int ocfs2_setattr(struct dentry *dentry, struct iattr *attr);
int ocfs2_getattr(const struct path *path, struct kstat *stat,
u32 request_mask, unsigned int flags);
--
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2: clean up redundant function declarations
2018-04-21 11:41 [Ocfs2-devel] [PATCH] ocfs2: clean up redundant function declarations Jia Guo
@ 2018-04-23 2:36 ` Gang He
2018-04-23 10:51 ` Joseph Qi
1 sibling, 0 replies; 3+ messages in thread
From: Gang He @ 2018-04-23 2:36 UTC (permalink / raw)
To: ocfs2-devel
Reviewed-by: Gang He <ghe@suse.com>
Thanks
Gang
>>>
> The function ocfs2_extend_allocation has been deleted, clean up its
> declaration.
>
> Fixes: 964f14a0d350 ("ocfs2: clean up some dead code")
>
> Signed-off-by: Jia Guo <guojia12@huawei.com>
> Reviewed-by: Jun Piao <piaojun@huawei.com>
> ---
> fs/ocfs2/file.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/ocfs2/file.h b/fs/ocfs2/file.h
> index 1fdc983..7eb7f03 100644
> --- a/fs/ocfs2/file.h
> +++ b/fs/ocfs2/file.h
> @@ -65,8 +65,6 @@ int ocfs2_extend_no_holes(struct inode *inode, struct
> buffer_head *di_bh,
> u64 new_i_size, u64 zero_to);
> int ocfs2_zero_extend(struct inode *inode, struct buffer_head *di_bh,
> loff_t zero_to);
> -int ocfs2_extend_allocation(struct inode *inode, u32 logical_start,
> - u32 clusters_to_add, int mark_unwritten);
> int ocfs2_setattr(struct dentry *dentry, struct iattr *attr);
> int ocfs2_getattr(const struct path *path, struct kstat *stat,
> u32 request_mask, unsigned int flags);
> --
>
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2: clean up redundant function declarations
2018-04-21 11:41 [Ocfs2-devel] [PATCH] ocfs2: clean up redundant function declarations Jia Guo
2018-04-23 2:36 ` Gang He
@ 2018-04-23 10:51 ` Joseph Qi
1 sibling, 0 replies; 3+ messages in thread
From: Joseph Qi @ 2018-04-23 10:51 UTC (permalink / raw)
To: ocfs2-devel
On 18/4/21 19:41, Jia Guo wrote:
> The function ocfs2_extend_allocation has been deleted, clean up its
> declaration.
>
I suggest we also change the static function name from
__ocfs2_extend_allocation() to ocfs2_extend_allocation() to be
consistent with the corresponding trace events as well as comments for
ocfs2_lock_allocators().
Thanks,
Joseph
> Fixes: 964f14a0d350 ("ocfs2: clean up some dead code")
>
> Signed-off-by: Jia Guo <guojia12@huawei.com>
> Reviewed-by: Jun Piao <piaojun@huawei.com>> ---
> fs/ocfs2/file.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/ocfs2/file.h b/fs/ocfs2/file.h
> index 1fdc983..7eb7f03 100644
> --- a/fs/ocfs2/file.h
> +++ b/fs/ocfs2/file.h
> @@ -65,8 +65,6 @@ int ocfs2_extend_no_holes(struct inode *inode, struct buffer_head *di_bh,
> u64 new_i_size, u64 zero_to);
> int ocfs2_zero_extend(struct inode *inode, struct buffer_head *di_bh,
> loff_t zero_to);
> -int ocfs2_extend_allocation(struct inode *inode, u32 logical_start,
> - u32 clusters_to_add, int mark_unwritten);
> int ocfs2_setattr(struct dentry *dentry, struct iattr *attr);
> int ocfs2_getattr(const struct path *path, struct kstat *stat,
> u32 request_mask, unsigned int flags);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-23 10:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-21 11:41 [Ocfs2-devel] [PATCH] ocfs2: clean up redundant function declarations Jia Guo
2018-04-23 2:36 ` Gang He
2018-04-23 10:51 ` Joseph Qi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.