[PATCH] usb: always build usb/common/ targets; fixes extcon-axp288 build error

[PATCH] usb: always build usb/common/ targets; fixes extcon-axp288 build error

[Randy Dunlap]

From: Randy Dunlap <rdunlap@infradead.org>

The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB
Makefile does not currently build drivers/usb/common/ (where
USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify
the USB Makefile to always descend into drivers/usb/common/
to build its configured targets.

Fixes these build errors:

ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!
ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined!
ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined!
ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined!

An alternative patch would be to select USB_COMMON in the EXTCON_AXP288
driver Kconfig entry, but this would build more code in
drivers/usb/common/ than is necessary.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: linux-usb@vger.kernel.org
---
 drivers/usb/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- lnx-417-rc1.orig/drivers/usb/Makefile
+++ lnx-417-rc1/drivers/usb/Makefile
@@ -60,7 +60,7 @@ obj-$(CONFIG_USB_CHIPIDEA)	+= chipidea/
 obj-$(CONFIG_USB_RENESAS_USBHS)	+= renesas_usbhs/
 obj-$(CONFIG_USB_GADGET)	+= gadget/
 
-obj-$(CONFIG_USB_COMMON)	+= common/
+obj-y				+= common/
 
 obj-$(CONFIG_USBIP_CORE)	+= usbip/
 

usb: always build usb/common/ targets; fixes extcon-axp288 build error

[Randy Dunlap]

From: Randy Dunlap <rdunlap@infradead.org>

The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB
Makefile does not currently build drivers/usb/common/ (where
USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify
the USB Makefile to always descend into drivers/usb/common/
to build its configured targets.

Fixes these build errors:

ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!
ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined!
ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined!
ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined!

An alternative patch would be to select USB_COMMON in the EXTCON_AXP288
driver Kconfig entry, but this would build more code in
drivers/usb/common/ than is necessary.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: linux-usb@vger.kernel.org
---
 drivers/usb/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--- lnx-417-rc1.orig/drivers/usb/Makefile
+++ lnx-417-rc1/drivers/usb/Makefile
@@ -60,7 +60,7 @@ obj-$(CONFIG_USB_CHIPIDEA)	+= chipidea/
 obj-$(CONFIG_USB_RENESAS_USBHS)	+= renesas_usbhs/
 obj-$(CONFIG_USB_GADGET)	+= gadget/
 
-obj-$(CONFIG_USB_COMMON)	+= common/
+obj-y				+= common/
 
 obj-$(CONFIG_USBIP_CORE)	+= usbip/
 

Re: [PATCH] usb: always build usb/common/ targets; fixes extcon-axp288 build error

[Hans de Goede]

Hi,

On 17-04-18 07:14, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB
> Makefile does not currently build drivers/usb/common/ (where
> USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify
> the USB Makefile to always descend into drivers/usb/common/
> to build its configured targets.
> 
> Fixes these build errors:
> 
> ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!
> ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined!
> ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined!
> ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined!
> 
> An alternative patch would be to select USB_COMMON in the EXTCON_AXP288
> driver Kconfig entry, but this would build more code in
> drivers/usb/common/ than is necessary.

Ah, that variant of fixing this got posted yesterday and I acked that,
but I agree that this version is better.

Greg, what is your take on this fix?

Chanwoo Choi, please wait with merging the fix from yesterday until
we've a decision which fix to use.

Regards,

Hans



> 
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: linux-usb@vger.kernel.org
> ---
>   drivers/usb/Makefile |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- lnx-417-rc1.orig/drivers/usb/Makefile
> +++ lnx-417-rc1/drivers/usb/Makefile
> @@ -60,7 +60,7 @@ obj-$(CONFIG_USB_CHIPIDEA)	+= chipidea/
>   obj-$(CONFIG_USB_RENESAS_USBHS)	+= renesas_usbhs/
>   obj-$(CONFIG_USB_GADGET)	+= gadget/
>   
> -obj-$(CONFIG_USB_COMMON)	+= common/
> +obj-y				+= common/
>   
>   obj-$(CONFIG_USBIP_CORE)	+= usbip/
>   
> 
> 

usb: always build usb/common/ targets; fixes extcon-axp288 build error

[Hans de Goede]

Hi,

On 17-04-18 07:14, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB
> Makefile does not currently build drivers/usb/common/ (where
> USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify
> the USB Makefile to always descend into drivers/usb/common/
> to build its configured targets.
> 
> Fixes these build errors:
> 
> ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!
> ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined!
> ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined!
> ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined!
> 
> An alternative patch would be to select USB_COMMON in the EXTCON_AXP288
> driver Kconfig entry, but this would build more code in
> drivers/usb/common/ than is necessary.

Ah, that variant of fixing this got posted yesterday and I acked that,
but I agree that this version is better.

Greg, what is your take on this fix?

Chanwoo Choi, please wait with merging the fix from yesterday until
we've a decision which fix to use.

Regards,

Hans



> 
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: linux-usb@vger.kernel.org
> ---
>   drivers/usb/Makefile |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- lnx-417-rc1.orig/drivers/usb/Makefile
> +++ lnx-417-rc1/drivers/usb/Makefile
> @@ -60,7 +60,7 @@ obj-$(CONFIG_USB_CHIPIDEA)	+= chipidea/
>   obj-$(CONFIG_USB_RENESAS_USBHS)	+= renesas_usbhs/
>   obj-$(CONFIG_USB_GADGET)	+= gadget/
>   
> -obj-$(CONFIG_USB_COMMON)	+= common/
> +obj-y				+= common/
>   
>   obj-$(CONFIG_USBIP_CORE)	+= usbip/
>   
> 
>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: always build usb/common/ targets; fixes extcon-axp288 build error

[Randy Dunlap]

On 04/17/18 02:01, Hans de Goede wrote:
> Hi,
> 
> On 17-04-18 07:14, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB
>> Makefile does not currently build drivers/usb/common/ (where
>> USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify
>> the USB Makefile to always descend into drivers/usb/common/
>> to build its configured targets.
>>
>> Fixes these build errors:
>>
>> ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!
>> ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined!
>> ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined!
>> ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined!
>>
>> An alternative patch would be to select USB_COMMON in the EXTCON_AXP288
>> driver Kconfig entry, but this would build more code in
>> drivers/usb/common/ than is necessary.
> 
> Ah, that variant of fixing this got posted yesterday and I acked that,
> but I agree that this version is better.

That was my first patch version, but I didn't like it.

However, I missed that patch. If I had seen it, I wouldn't have posted
this patch.


> Greg, what is your take on this fix?
> 
> Chanwoo Choi, please wait with merging the fix from yesterday until
> we've a decision which fix to use.
> 
> Regards,
> 
> Hans
> 
> 
> 
>>
>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
>> Cc: Chanwoo Choi <cw00.choi@samsung.com>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> Cc: linux-usb@vger.kernel.org
>> ---
>>   drivers/usb/Makefile |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- lnx-417-rc1.orig/drivers/usb/Makefile
>> +++ lnx-417-rc1/drivers/usb/Makefile
>> @@ -60,7 +60,7 @@ obj-$(CONFIG_USB_CHIPIDEA)    += chipidea/
>>   obj-$(CONFIG_USB_RENESAS_USBHS)    += renesas_usbhs/
>>   obj-$(CONFIG_USB_GADGET)    += gadget/
>>   -obj-$(CONFIG_USB_COMMON)    += common/
>> +obj-y                += common/
>>     obj-$(CONFIG_USBIP_CORE)    += usbip/
>>  
>>
> 


-- 
~Randy

usb: always build usb/common/ targets; fixes extcon-axp288 build error

[Randy Dunlap]

On 04/17/18 02:01, Hans de Goede wrote:
> Hi,
> 
> On 17-04-18 07:14, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB
>> Makefile does not currently build drivers/usb/common/ (where
>> USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify
>> the USB Makefile to always descend into drivers/usb/common/
>> to build its configured targets.
>>
>> Fixes these build errors:
>>
>> ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!
>> ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined!
>> ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined!
>> ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined!
>>
>> An alternative patch would be to select USB_COMMON in the EXTCON_AXP288
>> driver Kconfig entry, but this would build more code in
>> drivers/usb/common/ than is necessary.
> 
> Ah, that variant of fixing this got posted yesterday and I acked that,
> but I agree that this version is better.

That was my first patch version, but I didn't like it.

However, I missed that patch. If I had seen it, I wouldn't have posted
this patch.


> Greg, what is your take on this fix?
> 
> Chanwoo Choi, please wait with merging the fix from yesterday until
> we've a decision which fix to use.
> 
> Regards,
> 
> Hans
> 
> 
> 
>>
>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
>> Cc: Chanwoo Choi <cw00.choi@samsung.com>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> Cc: linux-usb@vger.kernel.org
>> ---
>>   drivers/usb/Makefile |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- lnx-417-rc1.orig/drivers/usb/Makefile
>> +++ lnx-417-rc1/drivers/usb/Makefile
>> @@ -60,7 +60,7 @@ obj-$(CONFIG_USB_CHIPIDEA)    += chipidea/
>>   obj-$(CONFIG_USB_RENESAS_USBHS)    += renesas_usbhs/
>>   obj-$(CONFIG_USB_GADGET)    += gadget/
>>   -obj-$(CONFIG_USB_COMMON)    += common/
>> +obj-y                += common/
>>     obj-$(CONFIG_USBIP_CORE)    += usbip/
>>  
>>
>

Re: [PATCH] usb: always build usb/common/ targets; fixes extcon-axp288 build error

[Greg Kroah-Hartman]

On Tue, Apr 17, 2018 at 11:01:41AM +0200, Hans de Goede wrote:
> Hi,
> 
> On 17-04-18 07:14, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@infradead.org>
> > 
> > The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB
> > Makefile does not currently build drivers/usb/common/ (where
> > USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify
> > the USB Makefile to always descend into drivers/usb/common/
> > to build its configured targets.
> > 
> > Fixes these build errors:
> > 
> > ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!
> > ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined!
> > ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined!
> > ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined!
> > 
> > An alternative patch would be to select USB_COMMON in the EXTCON_AXP288
> > driver Kconfig entry, but this would build more code in
> > drivers/usb/common/ than is necessary.
> 
> Ah, that variant of fixing this got posted yesterday and I acked that,
> but I agree that this version is better.
> 
> Greg, what is your take on this fix?

I'll take the patch from Arnd for this.

thanks,

greg k-h

usb: always build usb/common/ targets; fixes extcon-axp288 build error

[Greg Kroah-Hartman]

On Tue, Apr 17, 2018 at 11:01:41AM +0200, Hans de Goede wrote:
> Hi,
> 
> On 17-04-18 07:14, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@infradead.org>
> > 
> > The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB
> > Makefile does not currently build drivers/usb/common/ (where
> > USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify
> > the USB Makefile to always descend into drivers/usb/common/
> > to build its configured targets.
> > 
> > Fixes these build errors:
> > 
> > ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!
> > ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined!
> > ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined!
> > ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined!
> > 
> > An alternative patch would be to select USB_COMMON in the EXTCON_AXP288
> > driver Kconfig entry, but this would build more code in
> > drivers/usb/common/ than is necessary.
> 
> Ah, that variant of fixing this got posted yesterday and I acked that,
> but I agree that this version is better.
> 
> Greg, what is your take on this fix?

I'll take the patch from Arnd for this.

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: always build usb/common/ targets; fixes extcon-axp288 build error

[Chanwoo Choi]

On 2018년 04월 17일 18:01, Hans de Goede wrote:
> Hi,
> 
> On 17-04-18 07:14, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB
>> Makefile does not currently build drivers/usb/common/ (where
>> USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify
>> the USB Makefile to always descend into drivers/usb/common/
>> to build its configured targets.
>>
>> Fixes these build errors:
>>
>> ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!
>> ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined!
>> ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined!
>> ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined!
>>
>> An alternative patch would be to select USB_COMMON in the EXTCON_AXP288
>> driver Kconfig entry, but this would build more code in
>> drivers/usb/common/ than is necessary.
> 
> Ah, that variant of fixing this got posted yesterday and I acked that,
> but I agree that this version is better.
> 
> Greg, what is your take on this fix?
> 
> Chanwoo Choi, please wait with merging the fix from yesterday until
> we've a decision which fix to use.

OK. I'll not send pull request for fix patches until deciding them.

> 
> Regards,
> 
> Hans
> 
> 
> 
>>
>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
>> Cc: Chanwoo Choi <cw00.choi@samsung.com>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> Cc: linux-usb@vger.kernel.org
>> ---
>>   drivers/usb/Makefile |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- lnx-417-rc1.orig/drivers/usb/Makefile
>> +++ lnx-417-rc1/drivers/usb/Makefile
>> @@ -60,7 +60,7 @@ obj-$(CONFIG_USB_CHIPIDEA)    += chipidea/
>>   obj-$(CONFIG_USB_RENESAS_USBHS)    += renesas_usbhs/
>>   obj-$(CONFIG_USB_GADGET)    += gadget/
>>   -obj-$(CONFIG_USB_COMMON)    += common/
>> +obj-y                += common/
>>     obj-$(CONFIG_USBIP_CORE)    += usbip/
>>  
>>
> 
> 
> 


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

usb: always build usb/common/ targets; fixes extcon-axp288 build error

[Chanwoo Choi]

On 2018년 04월 17일 18:01, Hans de Goede wrote:
> Hi,
> 
> On 17-04-18 07:14, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB
>> Makefile does not currently build drivers/usb/common/ (where
>> USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify
>> the USB Makefile to always descend into drivers/usb/common/
>> to build its configured targets.
>>
>> Fixes these build errors:
>>
>> ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!
>> ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined!
>> ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined!
>> ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined!
>>
>> An alternative patch would be to select USB_COMMON in the EXTCON_AXP288
>> driver Kconfig entry, but this would build more code in
>> drivers/usb/common/ than is necessary.
> 
> Ah, that variant of fixing this got posted yesterday and I acked that,
> but I agree that this version is better.
> 
> Greg, what is your take on this fix?
> 
> Chanwoo Choi, please wait with merging the fix from yesterday until
> we've a decision which fix to use.

OK. I'll not send pull request for fix patches until deciding them.

> 
> Regards,
> 
> Hans
> 
> 
> 
>>
>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
>> Cc: Chanwoo Choi <cw00.choi@samsung.com>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> Cc: linux-usb@vger.kernel.org
>> ---
>>   drivers/usb/Makefile |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- lnx-417-rc1.orig/drivers/usb/Makefile
>> +++ lnx-417-rc1/drivers/usb/Makefile
>> @@ -60,7 +60,7 @@ obj-$(CONFIG_USB_CHIPIDEA)    += chipidea/
>>   obj-$(CONFIG_USB_RENESAS_USBHS)    += renesas_usbhs/
>>   obj-$(CONFIG_USB_GADGET)    += gadget/
>>   -obj-$(CONFIG_USB_COMMON)    += common/
>> +obj-y                += common/
>>     obj-$(CONFIG_USBIP_CORE)    += usbip/
>>  
>>
> 
> 
>

Re: [PATCH] usb: always build usb/common/ targets; fixes extcon-axp288 build error

[Hans de Goede]

Hi,

On 24-04-18 09:42, Chanwoo Choi wrote:
> On 2018년 04월 17일 18:01, Hans de Goede wrote:
>> Hi,
>>
>> On 17-04-18 07:14, Randy Dunlap wrote:
>>> From: Randy Dunlap <rdunlap@infradead.org>
>>>
>>> The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB
>>> Makefile does not currently build drivers/usb/common/ (where
>>> USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify
>>> the USB Makefile to always descend into drivers/usb/common/
>>> to build its configured targets.
>>>
>>> Fixes these build errors:
>>>
>>> ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!
>>> ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined!
>>> ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined!
>>> ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined!
>>>
>>> An alternative patch would be to select USB_COMMON in the EXTCON_AXP288
>>> driver Kconfig entry, but this would build more code in
>>> drivers/usb/common/ than is necessary.
>>
>> Ah, that variant of fixing this got posted yesterday and I acked that,
>> but I agree that this version is better.
>>
>> Greg, what is your take on this fix?
>>
>> Chanwoo Choi, please wait with merging the fix from yesterday until
>> we've a decision which fix to use.
> 
> OK. I'll not send pull request for fix patches until deciding them.

Greg has picked up another patch to fix this, so you can drop this.

Regards,

Hans

usb: always build usb/common/ targets; fixes extcon-axp288 build error

[Hans de Goede]

Hi,

On 24-04-18 09:42, Chanwoo Choi wrote:
> On 2018년 04월 17일 18:01, Hans de Goede wrote:
>> Hi,
>>
>> On 17-04-18 07:14, Randy Dunlap wrote:
>>> From: Randy Dunlap <rdunlap@infradead.org>
>>>
>>> The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB
>>> Makefile does not currently build drivers/usb/common/ (where
>>> USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify
>>> the USB Makefile to always descend into drivers/usb/common/
>>> to build its configured targets.
>>>
>>> Fixes these build errors:
>>>
>>> ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!
>>> ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined!
>>> ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined!
>>> ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined!
>>>
>>> An alternative patch would be to select USB_COMMON in the EXTCON_AXP288
>>> driver Kconfig entry, but this would build more code in
>>> drivers/usb/common/ than is necessary.
>>
>> Ah, that variant of fixing this got posted yesterday and I acked that,
>> but I agree that this version is better.
>>
>> Greg, what is your take on this fix?
>>
>> Chanwoo Choi, please wait with merging the fix from yesterday until
>> we've a decision which fix to use.
> 
> OK. I'll not send pull request for fix patches until deciding them.

Greg has picked up another patch to fix this, so you can drop this.

Regards,

Hans
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html