From: "Jan Beulich" <JBeulich@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 1/2] SVM: re-work VMCB sync-ing
Date: Mon, 30 Apr 2018 09:50:46 -0600 [thread overview]
Message-ID: <5AE73B5602000078001BFAEF@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <2eb0fe3c-7ff5-e731-d64c-8d04d082acce@oracle.com>
>>> On 30.04.18 at 17:30, <boris.ostrovsky@oracle.com> wrote:
> On 04/30/2018 07:37 AM, Jan Beulich wrote:
>> @@ -1168,6 +1169,9 @@ static void noreturn svm_do_resume(struc
>>
>> hvm_do_resume(v);
>>
>> + if ( v->arch.hvm_svm.vmcb_sync_state == vmcb_needs_vmload )
>> + svm_sync_vmcb(v, vmcb_needs_vmsave);
>
>
> Is it not possible (or advisable) to move the test into svm_sync_vmcb()
> (and drop the ASSERT there)?
It is possible; I'm not sure myself if it's advisable, but I take you asking the
question as you thinking it is, so I'll change it.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-04-30 15:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 10:17 [PATCH v2 0/2] SVM: guest state handling adjustments Jan Beulich
2018-04-30 11:37 ` [PATCH v2 1/2] SVM: re-work VMCB sync-ing Jan Beulich
2018-04-30 15:30 ` Boris Ostrovsky
2018-04-30 15:50 ` Jan Beulich [this message]
2018-04-30 15:56 ` Boris Ostrovsky
2018-04-30 16:01 ` Jan Beulich
2018-04-30 17:07 ` Andrew Cooper
2018-04-30 17:50 ` Boris Ostrovsky
2018-05-02 7:11 ` Jan Beulich
2018-05-02 14:45 ` Boris Ostrovsky
2018-05-03 14:43 ` Jan Beulich
2018-05-03 18:34 ` Boris Ostrovsky
2018-04-30 11:37 ` [PATCH v2 2/2] SVM: introduce a VM entry helper Jan Beulich
2018-04-30 11:51 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AE73B5602000078001BFAEF@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.