All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH v2 2/2] SVM: introduce a VM entry helper
Date: Mon, 30 Apr 2018 12:51:49 +0100	[thread overview]
Message-ID: <c7aeead5-6b01-e18e-8875-dcfd8cf3ce7e@citrix.com> (raw)
In-Reply-To: <5AE7000702000078001BF8A5@prv1-mh.provo.novell.com>

On 30/04/18 12:37, Jan Beulich wrote:
> --- a/xen/arch/x86/hvm/svm/entry.S
> +++ b/xen/arch/x86/hvm/svm/entry.S
> @@ -61,24 +61,14 @@ UNLIKELY_START(ne, nsvm_hap)
>          jmp  .Lsvm_do_resume
>  __UNLIKELY_END(nsvm_hap)
>  
> -        call svm_asid_handle_vmrun
> +        mov  %rsp, %rdi
> +        call svm_vmenter_helper
>  
>          cmpb $0,tb_init_done(%rip)
>  UNLIKELY_START(nz, svm_trace)
>          call svm_trace_vmentry
>  UNLIKELY_END(svm_trace)

This trace call can also be moved up into C, at which point you can fold
svm_trace_vmentry() (which is a 1-liner anyway) into
svm_vmenter_helper() which would be its sole caller.

Otherwise, Reivewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>  
> -        mov  VCPU_svm_vmcb(%rbx),%rcx
> -        mov  UREGS_rax(%rsp),%rax
> -        mov  %rax,VMCB_rax(%rcx)
> -        mov  UREGS_rip(%rsp),%rax
> -        mov  %rax,VMCB_rip(%rcx)
> -        mov  UREGS_rsp(%rsp),%rax
> -        mov  %rax,VMCB_rsp(%rcx)
> -        mov  UREGS_eflags(%rsp),%rax
> -        or   $X86_EFLAGS_MBS,%rax
> -        mov  %rax,VMCB_rflags(%rcx)
> -
>          mov VCPU_arch_msr(%rbx), %rax
>          mov VCPUMSR_spec_ctrl_raw(%rax), %eax
>  
>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

      reply	other threads:[~2018-04-30 11:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 10:17 [PATCH v2 0/2] SVM: guest state handling adjustments Jan Beulich
2018-04-30 11:37 ` [PATCH v2 1/2] SVM: re-work VMCB sync-ing Jan Beulich
2018-04-30 15:30   ` Boris Ostrovsky
2018-04-30 15:50     ` Jan Beulich
2018-04-30 15:56       ` Boris Ostrovsky
2018-04-30 16:01         ` Jan Beulich
2018-04-30 17:07   ` Andrew Cooper
2018-04-30 17:50     ` Boris Ostrovsky
2018-05-02  7:11       ` Jan Beulich
2018-05-02 14:45         ` Boris Ostrovsky
2018-05-03 14:43           ` Jan Beulich
2018-05-03 18:34             ` Boris Ostrovsky
2018-04-30 11:37 ` [PATCH v2 2/2] SVM: introduce a VM entry helper Jan Beulich
2018-04-30 11:51   ` Andrew Cooper [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7aeead5-6b01-e18e-8875-dcfd8cf3ce7e@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.