All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@suse.com>
To: sstabellini@kernel.org
Cc: julien.grall@arm.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 3/6] arm: make it possible to disable the SMMU driver
Date: Mon, 21 May 2018 23:37:27 -0600	[thread overview]
Message-ID: <5B03AC970200007800130854@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1805211326420.4520@sstabellini-ThinkPad-X260>

>>> Stefano Stabellini <sstabellini@kernel.org> 05/21/18 10:35 PM >>>
>On Tue, 24 Apr 2018, Julien Grall wrote:
>> On 04/20/2018 10:39 AM, Jan Beulich wrote:
>> > > > > On 19.04.18 at 17:44, <julien.grall@arm.com> wrote:
>> > > On 18/04/18 23:15, Stefano Stabellini wrote:
>> > > > --- a/xen/drivers/passthrough/Kconfig
>> > > > +++ b/xen/drivers/passthrough/Kconfig
>> > > > @@ -1,3 +1,5 @@
>> > > >       config HAS_PASSTHROUGH
>> > > >        bool
>> > > > +
>> > > > +source "drivers/passthrough/arm/Kconfig"
>> > > 
>> > > Can't we load arm/Kconfig only when arm is selected? This would avoid
>> > > weird option on x86.
>> > 
>> > How would those options appear for x86, given ...
>> > 
>> > > > --- /dev/null
>> > > > +++ b/xen/drivers/passthrough/arm/Kconfig
>> > > > @@ -0,0 +1,7 @@
>> > > > +
>> > > > +config HAS_SMMUv2
>> > > > +    bool "ARM SMMUv2 driver"
>> > > > +    default y
>> > > > +    depends on ARM
>> > 
>> > ... this "depends on"? Of course if more options are going to appear here,
>> > wrapping the whole file in "if ARM" would be useful anyway, even if only
>> > to limit redundancy.
>
>Sorry, I think I am misunderstanding your suggestion. If you are
>suggesting:
>
>#if ARM
>config HAS_SMMUv2
>bool "ARM SMMUv2 driver"
>default y
>depends on ARM
>#endif
>
>then, this won't work because we are not running the kconfig files
>through the preprocessor.

if ARM
config HAS_SMMUv2
bool "ARM SMMUv2 driver"
default y
endif

The "if" basically adds a respective "depends on" for all enclosed options.


Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-05-22  5:37 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 22:15 [PATCH 0/6] arm: more kconfig configurability and small default configs Stefano Stabellini
2018-04-18 22:15 ` [PATCH 1/6] arm: make it possible to disable more kconfig options Stefano Stabellini
2018-04-19 15:36   ` Julien Grall
2018-05-21 19:58     ` Stefano Stabellini
2018-05-22  8:24       ` Julien Grall
2018-05-22 20:15         ` Stefano Stabellini
2018-04-18 22:15 ` [PATCH 2/6] arm: make it possible to enable/disable UART drivers Stefano Stabellini
2018-04-19 15:42   ` Julien Grall
2018-05-21 20:18     ` Stefano Stabellini
2018-05-21 20:20       ` Stefano Stabellini
2018-04-18 22:15 ` [PATCH 3/6] arm: make it possible to disable the SMMU driver Stefano Stabellini
2018-04-19  7:46   ` Jan Beulich
2018-04-19 22:43     ` Stefano Stabellini
2018-04-20  9:41       ` Jan Beulich
2018-04-20 17:03         ` Stefano Stabellini
2018-04-23 18:18       ` Andrii Anisov
2018-04-19 15:44   ` Julien Grall
2018-04-19 15:46     ` Julien Grall
2018-04-20  9:39     ` Jan Beulich
2018-04-24  8:57       ` Julien Grall
2018-05-21 20:35         ` Stefano Stabellini
2018-05-22  5:37           ` Jan Beulich [this message]
2018-04-18 22:15 ` [PATCH 4/6] arm: add a small kconfig for Renesas RCar H3 Stefano Stabellini
2018-04-19  8:06   ` Andrew Cooper
2018-04-19  8:53     ` Juergen Gross
2018-04-19 23:00       ` Stefano Stabellini
2018-04-20  4:39         ` Juergen Gross
2018-04-20 16:39           ` Stefano Stabellini
2018-04-23 18:30   ` Andrii Anisov
2018-04-24  9:01     ` Julien Grall
2018-04-24  9:52       ` Andrii Anisov
2018-04-24 10:06         ` Julien Grall
2018-04-24 11:04           ` Andrii Anisov
2018-04-24 11:16             ` Julien Grall
2018-04-24 14:18               ` Andrii Anisov
2018-04-24 16:20                 ` Julien Grall
2018-05-19  1:15                   ` Stefano Stabellini
2018-04-18 22:15 ` [PATCH 5/6] arm: add a small kconfig for qemu-system-aarch64 Stefano Stabellini
2018-04-18 22:15 ` [PATCH 6/6] xen: add cloc target Stefano Stabellini
2018-04-19  7:54   ` Jan Beulich
2018-04-19 23:22     ` Stefano Stabellini
2018-04-20  9:57       ` Jan Beulich
2018-05-21 23:32         ` Stefano Stabellini
2018-04-19 15:31 ` [PATCH 0/6] arm: more kconfig configurability and small default configs Julien Grall
2018-04-19 17:34   ` Lars Kurth
2018-04-19 22:45     ` Stefano Stabellini
2018-04-23 18:05 ` Andrii Anisov
2018-04-23 18:08 ` Andrii Anisov
2018-05-21 23:45   ` Stefano Stabellini
2018-05-23 17:48     ` Andrii Anisov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B03AC970200007800130854@prv1-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=julien.grall@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.