Re: [PATCH 2/6] arm: make it possible to enable/disable UART drivers

From: Stefano Stabellini <sstabellini@kernel.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Wei Liu <wei.liu2@citrix.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	xen-devel@lists.xen.org, Julien Grall <julien.grall@arm.com>,
	Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH 2/6] arm: make it possible to enable/disable UART drivers
Date: Mon, 21 May 2018 13:20:18 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.10.1805211319500.4520@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <alpine.DEB.2.10.1805211317430.4520@sstabellini-ThinkPad-X260>

On Mon, 21 May 2018, Stefano Stabellini wrote:
> On Thu, 19 Apr 2018, Julien Grall wrote:
> > Hi Stefano,
> > 
> > Please CC "THE REST" maintainers here.
> > 
> > On 18/04/18 23:15, Stefano Stabellini wrote:
> > > All the UART drivers are silent options. Add one line descriptions so
> > > that can be de/selected via menuconfig.
> > > 
> > > Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
> > > ---
> > >   xen/drivers/char/Kconfig | 16 ++++++++--------
> > >   1 file changed, 8 insertions(+), 8 deletions(-)
> > > 
> > > diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
> > > index cc78ec3..b6fcefd 100644
> > > --- a/xen/drivers/char/Kconfig
> > > +++ b/xen/drivers/char/Kconfig
> > > @@ -1,11 +1,11 @@
> > >   config HAS_NS16550
> > > -	bool
> > > +	bool "NS16550 UART driver"
> > 
> > It looks like to me that x86 will require this unconditionally. So that's
> > going to break randconfig.
> 
> Thank you, I'll fix
> 
> 
> > >   	default y
> > >   	help
> > >   	  This selects the 16550-series UART support. For most systems, say Y.
> > >     config HAS_CADENCE_UART
> > > -	bool
> > > +	bool "Xilinx Cadence UART driver"
> > >   	default y
> > >   	depends on ARM_64
> > >   	help
> > > @@ -13,7 +13,7 @@ config HAS_CADENCE_UART
> > >   	  based board, say Y.
> > >     config HAS_MVEBU
> > > -	bool am not entirely sure whether x86 require it by default.
> > > +	bool "Marvell MVEBU UART driver"
> > >   	default y
> > >   	depends on ARM_64
> > >   	help
> > > @@ -21,7 +21,7 @@ config HAS_MVEBU
> > >   	  based board, say Y.
> > >     config HAS_PL011
> > > -	bool
> > > +	bool "ARM PL011 UART driver"
> > >   	default y
> > >   	depends on ARM
> > >   	help
> > > @@ -29,7 +29,7 @@ config HAS_PL011
> > >   	  an Integrator/PP2, Integrator/CP or Versatile platform, say Y.
> > >     config HAS_EXYNOS4210
> > > -	bool
> > > +	bool "Samsung Exynos 4210 UART driver"
> > >   	default y
> > >   	depends on ARM_32
> > >   	help
> > > @@ -37,7 +37,7 @@ config HAS_EXYNOS4210
> > >   	  Exynos based board, say Y.
> > >     config HAS_OMAP
> > > -	bool
> > > +	bool "Texas Instruments OMAP UART driver"
> > >   	default y
> > >   	depends on ARM_32
> > >   	help
> > > @@ -45,7 +45,7 @@ config HAS_OMAP
> > >   	  Instruments based CPU, say Y.
> > >     config HAS_SCIF
> > > -	bool
> > > +	bool "SuperH SCI(F) UART driver"
> > >   	default y
> > >   	depends on ARM
> > >   	help
> > > @@ -53,7 +53,7 @@ config HAS_SCIF
> > >   	  or Renesas R-Car Gen 2/3 based board say Y.
> > >     config HAS_EHCI
> > > -	bool
> > > +	bool "EHCI UART driver"
> > 
> > Well, you are going to break at least Arm because this driver is not meant to
> > be working there.
> > 
> > Furthermore, it looks like to me that x86 will require this unconditionally.
> 
> I'll fix this too

Actually x86 already select both, I just have to make HAS_EHCI depend on
x86.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel