[PATCH v2 0/2] Release process: lesson to learn

[PATCH v2 0/2] Release process: lesson to learn

[Ian Jackson]

From: Ian Jackson <Ian.Jackson@eu.citrix.com>

This is my third attempt to get consensus for this.  We had a
discussion about this in December and again in April.

Technically I think the fact that I have Juergen's ack on the
controversial patch ought to be sufficient, since he is the RM, but I
would prefer to proceed with consensus.

So I have added a new patch to explicitly state that everything in
this directory is guidelines.

Ian Jackson (2):
  docs/process: Add RUBRIC
  docs/process/xen-release-management: Lesson to learn

 docs/process/RUBRIC                        | 15 +++++++++++++++
 docs/process/xen-release-management.pandoc |  5 +++++
 2 files changed, 20 insertions(+)
 create mode 100644 docs/process/RUBRIC

-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH v2 1/2] docs/process: Add RUBRIC

[Ian Jackson]

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 docs/process/RUBRIC | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 docs/process/RUBRIC

diff --git a/docs/process/RUBRIC b/docs/process/RUBRIC
new file mode 100644
index 0000000..78aca80
--- /dev/null
+++ b/docs/process/RUBRIC
@@ -0,0 +1,15 @@
+These process documents are used by those involved in releasing Xen to
+help keep the releases high quality, our release preparation
+well-organised, and to help avoid errors.
+
+They are living documents, and no special approval is needed to modify
+them beyond the usual acks for commit.  They should be updated as and
+when it seems expediant.
+
+Also, these documents are not to be slavishly followed.  Intelligent
+application of the guidelines means understanding, and giving effect
+to, the purpose behind any imprecation.
+
+Especially, the shell runes should not be executed blindly.  They are
+prompts to think about what should be done, and in what order; but
+often, the standard runes are not appropriate.
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH v2 2/2] docs/process/xen-release-management: Lesson to learn

[Ian Jackson]

The 4.10 release preparation was significantly more hairy than ideal.
(We seem to have a good overall outcome despite, rather than because
of, our approach.)

This is the second time (at least) that we have come close to failure
by committing to a release date before the exact code to be released
is known and has been made and tested.

Evidently our docs makes it insufficiently clear not to do that.

CC: Lars Kurth <lars.kurth@citrix.com>
CC: Julien Grall <julien.grall@arm.com>
Acked-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 docs/process/xen-release-management.pandoc | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/docs/process/xen-release-management.pandoc b/docs/process/xen-release-management.pandoc
index 2ff0665..eee5dcf 100644
--- a/docs/process/xen-release-management.pandoc
+++ b/docs/process/xen-release-management.pandoc
@@ -211,6 +211,11 @@ https://wiki.xenproject.org/wiki/Category:Xen_4.9
     Ask them to dry-run their checklist and confirm everything is OK. If not,
     arrange another RC and restart this checklist.
 
+7. Do not commit to a release date until
+
+    * The exact xen.git commit id to be released is known.
+    * That commit id has been satisfactorily tested.
+
 7. Give PR Personnel final go-ahead, and instruct Release Technician to make
 release deliverables (tags and tarballs - will usually be in place the day
 before the release). At this point, PR collateral will be sent to reporters
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 2/2] docs/process/xen-release-management: Lesson to learn

[Juergen Gross]

On 22/05/18 18:45, Ian Jackson wrote:
> The 4.10 release preparation was significantly more hairy than ideal.
> (We seem to have a good overall outcome despite, rather than because
> of, our approach.)
> 
> This is the second time (at least) that we have come close to failure
> by committing to a release date before the exact code to be released
> is known and has been made and tested.
> 
> Evidently our docs makes it insufficiently clear not to do that.
> 
> CC: Lars Kurth <lars.kurth@citrix.com>
> CC: Julien Grall <julien.grall@arm.com>
> Acked-by: Juergen Gross <jgross@suse.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---
>  docs/process/xen-release-management.pandoc | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/docs/process/xen-release-management.pandoc b/docs/process/xen-release-management.pandoc
> index 2ff0665..eee5dcf 100644
> --- a/docs/process/xen-release-management.pandoc
> +++ b/docs/process/xen-release-management.pandoc
> @@ -211,6 +211,11 @@ https://wiki.xenproject.org/wiki/Category:Xen_4.9
>      Ask them to dry-run their checklist and confirm everything is OK. If not,
>      arrange another RC and restart this checklist.
>  
> +7. Do not commit to a release date until
> +
> +    * The exact xen.git commit id to be released is known.
> +    * That commit id has been satisfactorily tested.
> +
>  7. Give PR Personnel final go-ahead, and instruct Release Technician to make

Just seeing it now: this should be "8.".


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 1/2] docs/process: Add RUBRIC

[Juergen Gross]

On 22/05/18 18:45, Ian Jackson wrote:
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 2/2] docs/process/xen-release-management: Lesson to learn

[Jan Beulich]

>>> On 22.05.18 at 18:45, <ian.jackson@eu.citrix.com> wrote:
> The 4.10 release preparation was significantly more hairy than ideal.
> (We seem to have a good overall outcome despite, rather than because
> of, our approach.)
> 
> This is the second time (at least) that we have come close to failure
> by committing to a release date before the exact code to be released
> is known and has been made and tested.
> 
> Evidently our docs makes it insufficiently clear not to do that.
> 
> CC: Lars Kurth <lars.kurth@citrix.com>
> CC: Julien Grall <julien.grall@arm.com>
> Acked-by: Juergen Gross <jgross@suse.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

I don't recall what was controversial here or why, and I certainly don't
mean to void anyone else's objections, but to me this is pretty obvious,
so it can have
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 2/2] docs/process/xen-release-management: Lesson to learn

[Lars Kurth]

On 22/05/2018, 12:45, "Ian Jackson" <ian.jackson@eu.citrix.com> wrote:
    
    CC: Lars Kurth <lars.kurth@citrix.com>
    CC: Julien Grall <julien.grall@arm.com>
    Acked-by: Juergen Gross <jgross@suse.com>
    Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
    ---
     docs/process/xen-release-management.pandoc | 5 +++++
     1 file changed, 5 insertions(+)
    
    diff --git a/docs/process/xen-release-management.pandoc b/docs/process/xen-release-management.pandoc
    index 2ff0665..eee5dcf 100644
    --- a/docs/process/xen-release-management.pandoc
    +++ b/docs/process/xen-release-management.pandoc
    @@ -211,6 +211,11 @@ https://wiki.xenproject.org/wiki/Category:Xen_4.9
         Ask them to dry-run their checklist and confirm everything is OK. If not,
         arrange another RC and restart this checklist.
     
    +7. Do not commit to a release date until
    +
    +    * The exact xen.git commit id to be released is known.
    +    * That commit id has been satisfactorily tested.
    +
     7. Give PR Personnel final go-ahead, and instruct Release Technician to make
     release deliverables (tags and tarballs - will usually be in place the day
     before the release). At this point, PR collateral will be sent to reporters

Acked-by: Lars Kurth <lars.kurth@citrix.com>
    

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 2/2] docs/process/xen-release-management: Lesson to learn

[Ian Jackson]

Juergen Gross writes ("Re: [Xen-devel] [PATCH v2 2/2] docs/process/xen-release-management: Lesson to learn"):
> On 22/05/18 18:45, Ian Jackson wrote:
> > +7. Do not commit to a release date until
> > +
> > +    * The exact xen.git commit id to be released is known.
> > +    * That commit id has been satisfactorily tested.
> > +
> >  7. Give PR Personnel final go-ahead, and instruct Release Technician to make
> 
> Just seeing it now: this should be "8.".

Yes.  (Although when processing to html pandoc will renumber, of
course.)

I have fixed this (and the subsequent 8 => 9) in my tree.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v2 0/2] Release process: lesson to learn

[Ian Jackson]

Ian Jackson writes ("[PATCH v2 0/2] Release process: lesson to learn"):
> This is my third attempt to get consensus for this.  We had a
> discussion about this in December and again in April.

I think I have enough acks now, so I intend to push this staging,
subject to checking with Juergen about the timing.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel