[PATCH] x86: suppress sync when XPTI is disabled for a domain

[PATCH] x86: suppress sync when XPTI is disabled for a domain

[Jan Beulich]

Now that we have a per-domain flag we can and should control sync-ing in
a more fine grained manner: Only domains having XPTI enabled need the
sync to occur.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -3765,7 +3765,7 @@
                         break;
                     rc = mod_l4_entry(va, l4e_from_intpte(req.val), mfn,
                                       cmd == MMU_PT_UPDATE_PRESERVE_AD, v);
-                    if ( !rc && !cpu_has_no_xpti )
+                    if ( !rc && v->domain->arch.pv_domain.xpti )
                     {
                         bool local_in_use = false;
 



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] x86: suppress sync when XPTI is disabled for a domain

[Andrew Cooper]

On 23/05/18 15:24, Jan Beulich wrote:
> Now that we have a per-domain flag we can and should control sync-ing in
> a more fine grained manner: Only domains having XPTI enabled need the
> sync to occur.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] x86: suppress sync when XPTI is disabled for a domain

[Jan Beulich]

>>> On 23.05.18 at 16:24, <JBeulich@suse.com> wrote:
> Now that we have a per-domain flag we can and should control sync-ing in
> a more fine grained manner: Only domains having XPTI enabled need the
> sync to occur.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -3765,7 +3765,7 @@
>                          break;
>                      rc = mod_l4_entry(va, l4e_from_intpte(req.val), mfn,
>                                        cmd == MMU_PT_UPDATE_PRESERVE_AD, v);
> -                    if ( !rc && !cpu_has_no_xpti )
> +                    if ( !rc && v->domain->arch.pv_domain.xpti )

I've meanwhile realized that instead of v->domain this would better be
pt_dom - I take it that this doesn't invalidate your R-b.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] x86: suppress sync when XPTI is disabled for a domain

[Juergen Gross]

On 23/05/18 16:24, Jan Beulich wrote:
> Now that we have a per-domain flag we can and should control sync-ing in
> a more fine grained manner: Only domains having XPTI enabled need the
> sync to occur.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel