All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: nmanthey@amazon.de
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Elizabeth Polgreen <polgreen@amazon.de>,
	george.dunlap@citrix.com
Subject: Re: [goto-label v2] memory: fix label syntax
Date: Tue, 31 Jul 2018 03:18:51 -0600	[thread overview]
Message-ID: <5B60297B02000078001D9505@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <5B60243D0200005904CC0BD5@prv1-mh.provo.novell.com>

>>> On 31.07.18 at 10:56, <nmanthey@amazon.de> wrote:
> When compiling this file with gcc, the compiler happily accepts the
> sequence of a label followed by an attribute. However, this sequence does
> not follow the gcc documentation. Hence, other compilers might stumble
> upon this statement.
> 
> To be able to compile Xen with goto-cc (the compiler of the CPROVER tool
> suite), the missing semicolon is added in this commit.
> 
> Reported-by: Elizabeth Polgreen <polgreen@amazon.de>
> Signed-off-by: Norbert Manthey <nmanthey@amazon.de>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

Btw - you still didn't Cc all relevant maintainers, but I'm sure no one
of them would object to a change like this.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2018-07-31  9:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31  7:18 [goto-label] memory: fix label syntax Norbert Manthey
2018-07-31  7:48 ` Jan Beulich
2018-07-31  8:32   ` Norbert Manthey
2018-07-31  8:42     ` Jan Beulich
2018-07-31  8:56       ` [goto-label v2] " Norbert Manthey
     [not found]         ` <5B601EC50200002B04CC06FC@prv1-mh.provo.novell.com>
     [not found]           ` <5B60243D0200005904CC0BD5@prv1-mh.provo.novell.com>
2018-07-31  9:18             ` Jan Beulich [this message]
2018-07-31  9:24               ` Wei Liu
2018-07-31  9:27                 ` Jan Beulich
2018-07-31  9:29                   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B60297B02000078001D9505@prv1-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=george.dunlap@citrix.com \
    --cc=nmanthey@amazon.de \
    --cc=polgreen@amazon.de \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.