All of lore.kernel.org
 help / color / mirror / Atom feed
From: Norbert Manthey <nmanthey@amazon.de>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Elizabeth Polgreen <polgreen@amazon.de>,
	george.dunlap@citrix.com
Subject: Re: [goto-label] memory: fix label syntax
Date: Tue, 31 Jul 2018 10:32:52 +0200	[thread overview]
Message-ID: <a993a757-edad-6a10-3109-9b18482c874b@amazon.de> (raw)
In-Reply-To: <5B60143D02000078001D940B@prv1-mh.provo.novell.com>

Sorry for putting you in the To field, I'll use Cc in the future.

I agree that the commit message is a little short, and I will iterate on
that. Furthermore, I agree that gcc compatibility would allow to parse
this statement. However, the given sequence is not unique, and the gcc
documentation states that the semicolon is mandatory.

https://gcc.gnu.org/onlinedocs/gcc/Label-Attributes.html

I'll add more details to the commit message.

Best,
Norbert

On 07/31/2018 09:48 AM, Jan Beulich wrote:
>>>> On 31.07.18 at 09:18, <nmanthey@amazon.de> wrote:
>> To be able to compile Xen with gotocc, the label statement has to be
>> followed by a semicolon.
> 
> Assuming that gotocc aims to be gcc compatible, this looks like a
> shortcoming there. As the workaround is simple enough, I'm fine
> with the change, but the description should then say so. Or
> otherwise it should as well clarify the situation.
> 
> Furthermore - please follow patch submission rules: Patches get
> sent _To_ the list, with _all_ maintainers _Cc_-ed.
> 
> Jan
> 
> 
> 
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-07-31  8:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31  7:18 [goto-label] memory: fix label syntax Norbert Manthey
2018-07-31  7:48 ` Jan Beulich
2018-07-31  8:32   ` Norbert Manthey [this message]
2018-07-31  8:42     ` Jan Beulich
2018-07-31  8:56       ` [goto-label v2] " Norbert Manthey
     [not found]         ` <5B601EC50200002B04CC06FC@prv1-mh.provo.novell.com>
     [not found]           ` <5B60243D0200005904CC0BD5@prv1-mh.provo.novell.com>
2018-07-31  9:18             ` Jan Beulich
2018-07-31  9:24               ` Wei Liu
2018-07-31  9:27                 ` Jan Beulich
2018-07-31  9:29                   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a993a757-edad-6a10-3109-9b18482c874b@amazon.de \
    --to=nmanthey@amazon.de \
    --cc=JBeulich@suse.com \
    --cc=george.dunlap@citrix.com \
    --cc=polgreen@amazon.de \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.