All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xen: clean up altp2m op comment
@ 2018-08-01  9:03 Wei Liu
  2018-08-01  9:15 ` George Dunlap
  2018-08-01  9:18 ` Jan Beulich
  0 siblings, 2 replies; 3+ messages in thread
From: Wei Liu @ 2018-08-01  9:03 UTC (permalink / raw)
  To: xen-devel
  Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper,
	Ian Jackson, Tim Deegan, Julien Grall, Jan Beulich

Delete trailing spaces and refer to XSM instead of an internal
function in the public header.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/hvm/hvm.c          | 8 ++++----
 xen/include/public/hvm/params.h | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 5de5440..72c51fa 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -4468,16 +4468,16 @@ static int hvmop_get_param(
 }
 
 /*
- * altp2m operations are envisioned as being used in several different 
+ * altp2m operations are envisioned as being used in several different
  * modes:
- * 
+ *
  * - external: All control and decisions are made by an external agent
  *   running domain 0.
  *
  * - internal: altp2m operations are used exclusively by an in-guest
  *   agent to protect itself from the guest kernel and in-guest
  *   attackers.
- * 
+ *
  * - coordinated: An in-guest agent handles #VE and VMFUNCs locally,
  *   but makes requests of an agent running outside the domain for
  *   bigger changes (such as modifying altp2m entires).
@@ -4491,7 +4491,7 @@ static int hvmop_get_param(
  * to properly enable the 'internal' use case, as well as to avoid
  * fragmentation, all altp2m subops should come under this single
  * HVMOP.
- * 
+ *
  * Note that 'internal' mode (HVM_PARAM_ALTP2M == XEN_ALTP2M_mixed)
  * has not been evaluated for safety from a security perspective.
  * Before using this mode in a security-critical environment, each
diff --git a/xen/include/public/hvm/params.h b/xen/include/public/hvm/params.h
index daa28a8..396977c 100644
--- a/xen/include/public/hvm/params.h
+++ b/xen/include/public/hvm/params.h
@@ -243,7 +243,7 @@
  * Note that 'mixed' mode has not been evaluated for safety from a
  * security perspective.  Before using this mode in a
  * security-critical environment, each subop should be evaluated for
- * safety, with unsafe subops blacklisted in xsm_hvm_altp2mhvm_op().
+ * safety, with unsafe subops blacklisted in XSM.
  */
 #define HVM_PARAM_ALTP2M       35
 #define XEN_ALTP2M_disabled      0

base-commit: 6aaa9fb308171ec58ddf4cf058ad5341f81a65cf
-- 
git-series 0.9.1

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] xen: clean up altp2m op comment
  2018-08-01  9:03 [PATCH] xen: clean up altp2m op comment Wei Liu
@ 2018-08-01  9:15 ` George Dunlap
  2018-08-01  9:18 ` Jan Beulich
  1 sibling, 0 replies; 3+ messages in thread
From: George Dunlap @ 2018-08-01  9:15 UTC (permalink / raw)
  To: Wei Liu, xen-devel
  Cc: Stefano Stabellini, George Dunlap, Andrew Cooper, Ian Jackson,
	Tim Deegan, Julien Grall, Jan Beulich

On 08/01/2018 10:03 AM, Wei Liu wrote:
> Delete trailing spaces and refer to XSM instead of an internal
> function in the public header.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Reviewed-by: George Dunlap <george.dunlap@citrix.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xen: clean up altp2m op comment
  2018-08-01  9:03 [PATCH] xen: clean up altp2m op comment Wei Liu
  2018-08-01  9:15 ` George Dunlap
@ 2018-08-01  9:18 ` Jan Beulich
  1 sibling, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2018-08-01  9:18 UTC (permalink / raw)
  To: Wei Liu
  Cc: Stefano Stabellini, George Dunlap, Andrew Cooper, Ian Jackson,
	Tim Deegan, Julien Grall, xen-devel

>>> On 01.08.18 at 11:03, <wei.liu2@citrix.com> wrote:
> Delete trailing spaces and refer to XSM instead of an internal
> function in the public header.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-08-01  9:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-01  9:03 [PATCH] xen: clean up altp2m op comment Wei Liu
2018-08-01  9:15 ` George Dunlap
2018-08-01  9:18 ` Jan Beulich

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.