All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH libdrm] amdgpu: When couldn't find bo, need to return error.
@ 2018-09-01  4:24 Emily Deng
       [not found] ` <1535775863-27689-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 8+ messages in thread
From: Emily Deng @ 2018-09-01  4:24 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Emily Deng

The startx will have segmant fault if return success.

SWDEV-163962

Change-Id: I56b189fa26efdcd1d96e5100af3f3e0b1208b0c3
Signed-off-by: Emily Deng <Emily.Deng@amd.com>
---
 amdgpu/amdgpu_bo.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c
index f25cacc..7e297fa 100644
--- a/amdgpu/amdgpu_bo.c
+++ b/amdgpu/amdgpu_bo.c
@@ -760,6 +760,7 @@ int amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
 				  uint64_t *offset_in_bo)
 {
 	uint32_t i;
+	int r = 0;
 	struct amdgpu_bo *bo;
 
 	if (cpu == NULL || size == 0)
@@ -787,10 +788,11 @@ int amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
 	} else {
 		*buf_handle = NULL;
 		*offset_in_bo = 0;
+		r = -errno;
 	}
 	pthread_mutex_unlock(&dev->bo_table_mutex);
 
-	return 0;
+	return r;
 }
 
 int amdgpu_create_bo_from_user_mem(amdgpu_device_handle dev,
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH libdrm] amdgpu: When couldn't find bo, need to return error.
       [not found] ` <1535775863-27689-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org>
@ 2018-09-01  8:17   ` Christian König
       [not found]     ` <aabe391a-d6d5-564f-1e0d-b2fb218bdeae-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 8+ messages in thread
From: Christian König @ 2018-09-01  8:17 UTC (permalink / raw)
  To: Emily Deng, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

Am 01.09.2018 um 06:24 schrieb Emily Deng:
> The startx will have segmant fault if return success.
>
> SWDEV-163962
>
> Change-Id: I56b189fa26efdcd1d96e5100af3f3e0b1208b0c3
> Signed-off-by: Emily Deng <Emily.Deng@amd.com>

Jerry already send a much better patch for this.

> ---
>   amdgpu/amdgpu_bo.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c
> index f25cacc..7e297fa 100644
> --- a/amdgpu/amdgpu_bo.c
> +++ b/amdgpu/amdgpu_bo.c
> @@ -760,6 +760,7 @@ int amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
>   				  uint64_t *offset_in_bo)
>   {
>   	uint32_t i;
> +	int r = 0;
>   	struct amdgpu_bo *bo;
>   
>   	if (cpu == NULL || size == 0)
> @@ -787,10 +788,11 @@ int amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
>   	} else {
>   		*buf_handle = NULL;
>   		*offset_in_bo = 0;
> +		r = -errno;

errno doesn't contain any error in this case.

>   	}
>   	pthread_mutex_unlock(&dev->bo_table_mutex);
>   
> -	return 0;
> +	return r;
>   }
>   
>   int amdgpu_create_bo_from_user_mem(amdgpu_device_handle dev,

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [PATCH libdrm] amdgpu: When couldn't find bo, need to return error.
       [not found]     ` <aabe391a-d6d5-564f-1e0d-b2fb218bdeae-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-09-01  8:58       ` Deng, Emily
       [not found]         ` <DM6PR12MB265273E1B06F0AB7A3B32A4D8F0E0-lmeGfMZKVrHiBFXSrFbU1AdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
  0 siblings, 1 reply; 8+ messages in thread
From: Deng, Emily @ 2018-09-01  8:58 UTC (permalink / raw)
  To: Koenig, Christian, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

Ok, then just ignore this patch. But seems didn't saw the patch on branch amd-staging-hybrid-master20180315.

Best wishes
Emily Deng

>-----Original Message-----
>From: Christian König <ckoenig.leichtzumerken@gmail.com>
>Sent: Saturday, September 1, 2018 4:17 PM
>To: Deng, Emily <Emily.Deng@amd.com>; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH libdrm] amdgpu: When couldn't find bo, need to return
>error.
>
>Am 01.09.2018 um 06:24 schrieb Emily Deng:
>> The startx will have segmant fault if return success.
>>
>> SWDEV-163962
>>
>> Change-Id: I56b189fa26efdcd1d96e5100af3f3e0b1208b0c3
>> Signed-off-by: Emily Deng <Emily.Deng@amd.com>
>
>Jerry already send a much better patch for this.
>
>> ---
>>   amdgpu/amdgpu_bo.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c index
>> f25cacc..7e297fa 100644
>> --- a/amdgpu/amdgpu_bo.c
>> +++ b/amdgpu/amdgpu_bo.c
>> @@ -760,6 +760,7 @@ int
>amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
>>   				  uint64_t *offset_in_bo)
>>   {
>>   	uint32_t i;
>> +	int r = 0;
>>   	struct amdgpu_bo *bo;
>>
>>   	if (cpu == NULL || size == 0)
>> @@ -787,10 +788,11 @@ int
>amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
>>   	} else {
>>   		*buf_handle = NULL;
>>   		*offset_in_bo = 0;
>> +		r = -errno;
>
>errno doesn't contain any error in this case.
>
>>   	}
>>   	pthread_mutex_unlock(&dev->bo_table_mutex);
>>
>> -	return 0;
>> +	return r;
>>   }
>>
>>   int amdgpu_create_bo_from_user_mem(amdgpu_device_handle dev,

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH libdrm] amdgpu: When couldn't find bo, need to return error.
       [not found]         ` <DM6PR12MB265273E1B06F0AB7A3B32A4D8F0E0-lmeGfMZKVrHiBFXSrFbU1AdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
@ 2018-09-03  1:42           ` Zhang, Jerry (Junwei)
       [not found]             ` <5B8C9169.4000909-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 8+ messages in thread
From: Zhang, Jerry (Junwei) @ 2018-09-03  1:42 UTC (permalink / raw)
  To: Deng, Emily, Koenig, Christian, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

On 09/01/2018 04:58 PM, Deng, Emily wrote:
> Ok, then just ignore this patch. But seems didn't saw the patch on branch amd-staging-hybrid-master20180315.

Thanks to take care of this as well.

I'm waiting some verification, and now push the patch to internal staging branch
mainline will be pushed later for another verification.

About master branch, needs someone's help with correct permission.

Regards,
Jerry
>
> Best wishes
> Emily Deng
>
>> -----Original Message-----
>> From: Christian König <ckoenig.leichtzumerken@gmail.com>
>> Sent: Saturday, September 1, 2018 4:17 PM
>> To: Deng, Emily <Emily.Deng@amd.com>; amd-gfx@lists.freedesktop.org
>> Subject: Re: [PATCH libdrm] amdgpu: When couldn't find bo, need to return
>> error.
>>
>> Am 01.09.2018 um 06:24 schrieb Emily Deng:
>>> The startx will have segmant fault if return success.
>>>
>>> SWDEV-163962
>>>
>>> Change-Id: I56b189fa26efdcd1d96e5100af3f3e0b1208b0c3
>>> Signed-off-by: Emily Deng <Emily.Deng@amd.com>
>>
>> Jerry already send a much better patch for this.
>>
>>> ---
>>>    amdgpu/amdgpu_bo.c | 4 +++-
>>>    1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c index
>>> f25cacc..7e297fa 100644
>>> --- a/amdgpu/amdgpu_bo.c
>>> +++ b/amdgpu/amdgpu_bo.c
>>> @@ -760,6 +760,7 @@ int
>> amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
>>>    				  uint64_t *offset_in_bo)
>>>    {
>>>    	uint32_t i;
>>> +	int r = 0;
>>>    	struct amdgpu_bo *bo;
>>>
>>>    	if (cpu == NULL || size == 0)
>>> @@ -787,10 +788,11 @@ int
>> amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
>>>    	} else {
>>>    		*buf_handle = NULL;
>>>    		*offset_in_bo = 0;
>>> +		r = -errno;
>>
>> errno doesn't contain any error in this case.
>>
>>>    	}
>>>    	pthread_mutex_unlock(&dev->bo_table_mutex);
>>>
>>> -	return 0;
>>> +	return r;
>>>    }
>>>
>>>    int amdgpu_create_bo_from_user_mem(amdgpu_device_handle dev,
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH libdrm] amdgpu: When couldn't find bo, need to return error.
       [not found]             ` <5B8C9169.4000909-5C7GfCeVMHo@public.gmane.org>
@ 2018-09-03  7:11               ` Christian König
       [not found]                 ` <48942a46-474b-a120-5b61-2fcbaf3eae4b-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 8+ messages in thread
From: Christian König @ 2018-09-03  7:11 UTC (permalink / raw)
  To: Zhang, Jerry (Junwei),
	Deng, Emily, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

> About master branch, needs someone's help with correct permission. 
I've already took care of that on the weekend.

Regards,
Christian.

Am 03.09.2018 um 03:42 schrieb Zhang, Jerry (Junwei):
> On 09/01/2018 04:58 PM, Deng, Emily wrote:
>> Ok, then just ignore this patch. But seems didn't saw the patch on 
>> branch amd-staging-hybrid-master20180315.
>
> Thanks to take care of this as well.
>
> I'm waiting some verification, and now push the patch to internal 
> staging branch
> mainline will be pushed later for another verification.
>
> About master branch, needs someone's help with correct permission.
>
> Regards,
> Jerry
>>
>> Best wishes
>> Emily Deng
>>
>>> -----Original Message-----
>>> From: Christian König <ckoenig.leichtzumerken@gmail.com>
>>> Sent: Saturday, September 1, 2018 4:17 PM
>>> To: Deng, Emily <Emily.Deng@amd.com>; amd-gfx@lists.freedesktop.org
>>> Subject: Re: [PATCH libdrm] amdgpu: When couldn't find bo, need to 
>>> return
>>> error.
>>>
>>> Am 01.09.2018 um 06:24 schrieb Emily Deng:
>>>> The startx will have segmant fault if return success.
>>>>
>>>> SWDEV-163962
>>>>
>>>> Change-Id: I56b189fa26efdcd1d96e5100af3f3e0b1208b0c3
>>>> Signed-off-by: Emily Deng <Emily.Deng@amd.com>
>>>
>>> Jerry already send a much better patch for this.
>>>
>>>> ---
>>>>    amdgpu/amdgpu_bo.c | 4 +++-
>>>>    1 file changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c index
>>>> f25cacc..7e297fa 100644
>>>> --- a/amdgpu/amdgpu_bo.c
>>>> +++ b/amdgpu/amdgpu_bo.c
>>>> @@ -760,6 +760,7 @@ int
>>> amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
>>>>                      uint64_t *offset_in_bo)
>>>>    {
>>>>        uint32_t i;
>>>> +    int r = 0;
>>>>        struct amdgpu_bo *bo;
>>>>
>>>>        if (cpu == NULL || size == 0)
>>>> @@ -787,10 +788,11 @@ int
>>> amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
>>>>        } else {
>>>>            *buf_handle = NULL;
>>>>            *offset_in_bo = 0;
>>>> +        r = -errno;
>>>
>>> errno doesn't contain any error in this case.
>>>
>>>>        }
>>>>        pthread_mutex_unlock(&dev->bo_table_mutex);
>>>>
>>>> -    return 0;
>>>> +    return r;
>>>>    }
>>>>
>>>>    int amdgpu_create_bo_from_user_mem(amdgpu_device_handle dev,
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>>

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH libdrm] amdgpu: When couldn't find bo, need to return error.
       [not found]                 ` <48942a46-474b-a120-5b61-2fcbaf3eae4b-5C7GfCeVMHo@public.gmane.org>
@ 2018-09-03  7:16                   ` Zhang, Jerry (Junwei)
       [not found]                     ` <5B8CDFDF.2030703-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 8+ messages in thread
From: Zhang, Jerry (Junwei) @ 2018-09-03  7:16 UTC (permalink / raw)
  To: Christian König, Deng, Emily,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

On 09/03/2018 03:11 PM, Christian König wrote:
>> About master branch, needs someone's help with correct permission.
> I've already took care of that on the weekend.

Thank you again.
BTW, how to apply that permission?

Regards,
Jerry

>
> Regards,
> Christian.
>
> Am 03.09.2018 um 03:42 schrieb Zhang, Jerry (Junwei):
>> On 09/01/2018 04:58 PM, Deng, Emily wrote:
>>> Ok, then just ignore this patch. But seems didn't saw the patch on branch amd-staging-hybrid-master20180315.
>>
>> Thanks to take care of this as well.
>>
>> I'm waiting some verification, and now push the patch to internal staging branch
>> mainline will be pushed later for another verification.
>>
>> About master branch, needs someone's help with correct permission.
>>
>> Regards,
>> Jerry
>>>
>>> Best wishes
>>> Emily Deng
>>>
>>>> -----Original Message-----
>>>> From: Christian König <ckoenig.leichtzumerken@gmail.com>
>>>> Sent: Saturday, September 1, 2018 4:17 PM
>>>> To: Deng, Emily <Emily.Deng@amd.com>; amd-gfx@lists.freedesktop.org
>>>> Subject: Re: [PATCH libdrm] amdgpu: When couldn't find bo, need to return
>>>> error.
>>>>
>>>> Am 01.09.2018 um 06:24 schrieb Emily Deng:
>>>>> The startx will have segmant fault if return success.
>>>>>
>>>>> SWDEV-163962
>>>>>
>>>>> Change-Id: I56b189fa26efdcd1d96e5100af3f3e0b1208b0c3
>>>>> Signed-off-by: Emily Deng <Emily.Deng@amd.com>
>>>>
>>>> Jerry already send a much better patch for this.
>>>>
>>>>> ---
>>>>>    amdgpu/amdgpu_bo.c | 4 +++-
>>>>>    1 file changed, 3 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c index
>>>>> f25cacc..7e297fa 100644
>>>>> --- a/amdgpu/amdgpu_bo.c
>>>>> +++ b/amdgpu/amdgpu_bo.c
>>>>> @@ -760,6 +760,7 @@ int
>>>> amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
>>>>>                      uint64_t *offset_in_bo)
>>>>>    {
>>>>>        uint32_t i;
>>>>> +    int r = 0;
>>>>>        struct amdgpu_bo *bo;
>>>>>
>>>>>        if (cpu == NULL || size == 0)
>>>>> @@ -787,10 +788,11 @@ int
>>>> amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
>>>>>        } else {
>>>>>            *buf_handle = NULL;
>>>>>            *offset_in_bo = 0;
>>>>> +        r = -errno;
>>>>
>>>> errno doesn't contain any error in this case.
>>>>
>>>>>        }
>>>>>        pthread_mutex_unlock(&dev->bo_table_mutex);
>>>>>
>>>>> -    return 0;
>>>>> +    return r;
>>>>>    }
>>>>>
>>>>>    int amdgpu_create_bo_from_user_mem(amdgpu_device_handle dev,
>>>
>>> _______________________________________________
>>> amd-gfx mailing list
>>> amd-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>>>
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH libdrm] amdgpu: When couldn't find bo, need to return error.
       [not found]                     ` <5B8CDFDF.2030703-5C7GfCeVMHo@public.gmane.org>
@ 2018-09-03  8:44                       ` Christian König
       [not found]                         ` <a55accb0-95d9-c25e-05dd-65a6a736c379-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 8+ messages in thread
From: Christian König @ 2018-09-03  8:44 UTC (permalink / raw)
  To: Zhang, Jerry (Junwei),
	Deng, Emily, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

Am 03.09.2018 um 09:16 schrieb Zhang, Jerry (Junwei):
> On 09/03/2018 03:11 PM, Christian König wrote:
>>> About master branch, needs someone's help with correct permission.
>> I've already took care of that on the weekend.
>
> Thank you again.
> BTW, how to apply that permission?

Previously that was done by opening a bugzilla ticket, but since the 
migration to gitlab that might be outdated now.

A good start is to go to https://gitlab.freedesktop.org and register an 
account, then somebody from the admin team needs to add that account to 
the appropriate groups.

Regards,
Christian.

>
> Regards,
> Jerry
>
>>
>> Regards,
>> Christian.
>>
>> Am 03.09.2018 um 03:42 schrieb Zhang, Jerry (Junwei):
>>> On 09/01/2018 04:58 PM, Deng, Emily wrote:
>>>> Ok, then just ignore this patch. But seems didn't saw the patch on 
>>>> branch amd-staging-hybrid-master20180315.
>>>
>>> Thanks to take care of this as well.
>>>
>>> I'm waiting some verification, and now push the patch to internal 
>>> staging branch
>>> mainline will be pushed later for another verification.
>>>
>>> About master branch, needs someone's help with correct permission.
>>>
>>> Regards,
>>> Jerry
>>>>
>>>> Best wishes
>>>> Emily Deng
>>>>
>>>>> -----Original Message-----
>>>>> From: Christian König <ckoenig.leichtzumerken@gmail.com>
>>>>> Sent: Saturday, September 1, 2018 4:17 PM
>>>>> To: Deng, Emily <Emily.Deng@amd.com>; amd-gfx@lists.freedesktop.org
>>>>> Subject: Re: [PATCH libdrm] amdgpu: When couldn't find bo, need to 
>>>>> return
>>>>> error.
>>>>>
>>>>> Am 01.09.2018 um 06:24 schrieb Emily Deng:
>>>>>> The startx will have segmant fault if return success.
>>>>>>
>>>>>> SWDEV-163962
>>>>>>
>>>>>> Change-Id: I56b189fa26efdcd1d96e5100af3f3e0b1208b0c3
>>>>>> Signed-off-by: Emily Deng <Emily.Deng@amd.com>
>>>>>
>>>>> Jerry already send a much better patch for this.
>>>>>
>>>>>> ---
>>>>>>    amdgpu/amdgpu_bo.c | 4 +++-
>>>>>>    1 file changed, 3 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c index
>>>>>> f25cacc..7e297fa 100644
>>>>>> --- a/amdgpu/amdgpu_bo.c
>>>>>> +++ b/amdgpu/amdgpu_bo.c
>>>>>> @@ -760,6 +760,7 @@ int
>>>>> amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
>>>>>>                      uint64_t *offset_in_bo)
>>>>>>    {
>>>>>>        uint32_t i;
>>>>>> +    int r = 0;
>>>>>>        struct amdgpu_bo *bo;
>>>>>>
>>>>>>        if (cpu == NULL || size == 0)
>>>>>> @@ -787,10 +788,11 @@ int
>>>>> amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
>>>>>>        } else {
>>>>>>            *buf_handle = NULL;
>>>>>>            *offset_in_bo = 0;
>>>>>> +        r = -errno;
>>>>>
>>>>> errno doesn't contain any error in this case.
>>>>>
>>>>>>        }
>>>>>> pthread_mutex_unlock(&dev->bo_table_mutex);
>>>>>>
>>>>>> -    return 0;
>>>>>> +    return r;
>>>>>>    }
>>>>>>
>>>>>>    int amdgpu_create_bo_from_user_mem(amdgpu_device_handle dev,
>>>>
>>>> _______________________________________________
>>>> amd-gfx mailing list
>>>> amd-gfx@lists.freedesktop.org
>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>>>>
>>

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH libdrm] amdgpu: When couldn't find bo, need to return error.
       [not found]                         ` <a55accb0-95d9-c25e-05dd-65a6a736c379-5C7GfCeVMHo@public.gmane.org>
@ 2018-09-03  9:08                           ` Zhang, Jerry (Junwei)
  0 siblings, 0 replies; 8+ messages in thread
From: Zhang, Jerry (Junwei) @ 2018-09-03  9:08 UTC (permalink / raw)
  To: Christian König, Deng, Emily,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

On 09/03/2018 04:44 PM, Christian König wrote:
> Am 03.09.2018 um 09:16 schrieb Zhang, Jerry (Junwei):
>> On 09/03/2018 03:11 PM, Christian König wrote:
>>>> About master branch, needs someone's help with correct permission.
>>> I've already took care of that on the weekend.
>>
>> Thank you again.
>> BTW, how to apply that permission?
>
> Previously that was done by opening a bugzilla ticket, but since the migration to gitlab that might be outdated now.
>
> A good start is to go to https://gitlab.freedesktop.org and register an account, then somebody from the admin team needs to add that account to the appropriate groups.

Thanks, will give a try.

Regards,
Jerry

>
> Regards,
> Christian.
>
>>
>> Regards,
>> Jerry
>>
>>>
>>> Regards,
>>> Christian.
>>>
>>> Am 03.09.2018 um 03:42 schrieb Zhang, Jerry (Junwei):
>>>> On 09/01/2018 04:58 PM, Deng, Emily wrote:
>>>>> Ok, then just ignore this patch. But seems didn't saw the patch on branch amd-staging-hybrid-master20180315.
>>>>
>>>> Thanks to take care of this as well.
>>>>
>>>> I'm waiting some verification, and now push the patch to internal staging branch
>>>> mainline will be pushed later for another verification.
>>>>
>>>> About master branch, needs someone's help with correct permission.
>>>>
>>>> Regards,
>>>> Jerry
>>>>>
>>>>> Best wishes
>>>>> Emily Deng
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Christian König <ckoenig.leichtzumerken@gmail.com>
>>>>>> Sent: Saturday, September 1, 2018 4:17 PM
>>>>>> To: Deng, Emily <Emily.Deng@amd.com>; amd-gfx@lists.freedesktop.org
>>>>>> Subject: Re: [PATCH libdrm] amdgpu: When couldn't find bo, need to return
>>>>>> error.
>>>>>>
>>>>>> Am 01.09.2018 um 06:24 schrieb Emily Deng:
>>>>>>> The startx will have segmant fault if return success.
>>>>>>>
>>>>>>> SWDEV-163962
>>>>>>>
>>>>>>> Change-Id: I56b189fa26efdcd1d96e5100af3f3e0b1208b0c3
>>>>>>> Signed-off-by: Emily Deng <Emily.Deng@amd.com>
>>>>>>
>>>>>> Jerry already send a much better patch for this.
>>>>>>
>>>>>>> ---
>>>>>>>    amdgpu/amdgpu_bo.c | 4 +++-
>>>>>>>    1 file changed, 3 insertions(+), 1 deletion(-)
>>>>>>>
>>>>>>> diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c index
>>>>>>> f25cacc..7e297fa 100644
>>>>>>> --- a/amdgpu/amdgpu_bo.c
>>>>>>> +++ b/amdgpu/amdgpu_bo.c
>>>>>>> @@ -760,6 +760,7 @@ int
>>>>>> amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
>>>>>>>                      uint64_t *offset_in_bo)
>>>>>>>    {
>>>>>>>        uint32_t i;
>>>>>>> +    int r = 0;
>>>>>>>        struct amdgpu_bo *bo;
>>>>>>>
>>>>>>>        if (cpu == NULL || size == 0)
>>>>>>> @@ -787,10 +788,11 @@ int
>>>>>> amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
>>>>>>>        } else {
>>>>>>>            *buf_handle = NULL;
>>>>>>>            *offset_in_bo = 0;
>>>>>>> +        r = -errno;
>>>>>>
>>>>>> errno doesn't contain any error in this case.
>>>>>>
>>>>>>>        }
>>>>>>> pthread_mutex_unlock(&dev->bo_table_mutex);
>>>>>>>
>>>>>>> -    return 0;
>>>>>>> +    return r;
>>>>>>>    }
>>>>>>>
>>>>>>>    int amdgpu_create_bo_from_user_mem(amdgpu_device_handle dev,
>>>>>
>>>>> _______________________________________________
>>>>> amd-gfx mailing list
>>>>> amd-gfx@lists.freedesktop.org
>>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>>>>>
>>>
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-09-03  9:08 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-01  4:24 [PATCH libdrm] amdgpu: When couldn't find bo, need to return error Emily Deng
     [not found] ` <1535775863-27689-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org>
2018-09-01  8:17   ` Christian König
     [not found]     ` <aabe391a-d6d5-564f-1e0d-b2fb218bdeae-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-01  8:58       ` Deng, Emily
     [not found]         ` <DM6PR12MB265273E1B06F0AB7A3B32A4D8F0E0-lmeGfMZKVrHiBFXSrFbU1AdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-09-03  1:42           ` Zhang, Jerry (Junwei)
     [not found]             ` <5B8C9169.4000909-5C7GfCeVMHo@public.gmane.org>
2018-09-03  7:11               ` Christian König
     [not found]                 ` <48942a46-474b-a120-5b61-2fcbaf3eae4b-5C7GfCeVMHo@public.gmane.org>
2018-09-03  7:16                   ` Zhang, Jerry (Junwei)
     [not found]                     ` <5B8CDFDF.2030703-5C7GfCeVMHo@public.gmane.org>
2018-09-03  8:44                       ` Christian König
     [not found]                         ` <a55accb0-95d9-c25e-05dd-65a6a736c379-5C7GfCeVMHo@public.gmane.org>
2018-09-03  9:08                           ` Zhang, Jerry (Junwei)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.