* [char-misc-next] mei: use module_pci_driver
@ 2012-07-17 8:23 Tomas Winkler
2012-07-17 8:23 ` Tomas Winkler
2012-07-17 17:17 ` Greg KH
0 siblings, 2 replies; 9+ messages in thread
From: Tomas Winkler @ 2012-07-17 8:23 UTC (permalink / raw)
To: gregkh; +Cc: arnd, alan, linux-kernel, Tomas Winkler
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
drivers/misc/mei/main.c | 39 +--------------------------------------
1 files changed, 1 insertions(+), 38 deletions(-)
diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
index 0d98c2e..0923302 100644
--- a/drivers/misc/mei/main.c
+++ b/drivers/misc/mei/main.c
@@ -1182,44 +1182,7 @@ static struct pci_driver mei_driver = {
.driver.pm = MEI_PM_OPS,
};
-/**
- * mei_init_module - Driver Registration Routine
- *
- * mei_init_module is the first routine called when the driver is
- * loaded. All it does is to register with the PCI subsystem.
- *
- * returns 0 on success, <0 on failure.
- */
-static int __init mei_init_module(void)
-{
- int ret;
-
- pr_debug("loading.\n");
- /* init pci module */
- ret = pci_register_driver(&mei_driver);
- if (ret < 0)
- pr_err("error registering driver.\n");
-
- return ret;
-}
-
-module_init(mei_init_module);
-
-/**
- * mei_exit_module - Driver Exit Cleanup Routine
- *
- * mei_exit_module is called just before the driver is removed
- * from memory.
- */
-static void __exit mei_exit_module(void)
-{
- pci_unregister_driver(&mei_driver);
-
- pr_debug("unloaded successfully.\n");
-}
-
-module_exit(mei_exit_module);
-
+module_pci_driver(mei_driver);
MODULE_AUTHOR("Intel Corporation");
MODULE_DESCRIPTION("Intel(R) Management Engine Interface");
--
1.7.4.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [char-misc-next] mei: use module_pci_driver
2012-07-17 8:23 [char-misc-next] mei: use module_pci_driver Tomas Winkler
@ 2012-07-17 8:23 ` Tomas Winkler
2012-07-17 12:41 ` Arnd Bergmann
2012-07-17 17:17 ` Greg KH
1 sibling, 1 reply; 9+ messages in thread
From: Tomas Winkler @ 2012-07-17 8:23 UTC (permalink / raw)
To: gregkh; +Cc: arnd, alan, linux-kernel, Tomas Winkler
Change-Id: I960feed4157ad1b178f68f4a0b3968e185ed0b36
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
drivers/misc/mei/main.c | 39 +--------------------------------------
1 files changed, 1 insertions(+), 38 deletions(-)
diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
index 0d98c2e..0923302 100644
--- a/drivers/misc/mei/main.c
+++ b/drivers/misc/mei/main.c
@@ -1182,44 +1182,7 @@ static struct pci_driver mei_driver = {
.driver.pm = MEI_PM_OPS,
};
-/**
- * mei_init_module - Driver Registration Routine
- *
- * mei_init_module is the first routine called when the driver is
- * loaded. All it does is to register with the PCI subsystem.
- *
- * returns 0 on success, <0 on failure.
- */
-static int __init mei_init_module(void)
-{
- int ret;
-
- pr_debug("loading.\n");
- /* init pci module */
- ret = pci_register_driver(&mei_driver);
- if (ret < 0)
- pr_err("error registering driver.\n");
-
- return ret;
-}
-
-module_init(mei_init_module);
-
-/**
- * mei_exit_module - Driver Exit Cleanup Routine
- *
- * mei_exit_module is called just before the driver is removed
- * from memory.
- */
-static void __exit mei_exit_module(void)
-{
- pci_unregister_driver(&mei_driver);
-
- pr_debug("unloaded successfully.\n");
-}
-
-module_exit(mei_exit_module);
-
+module_pci_driver(mei_driver);
MODULE_AUTHOR("Intel Corporation");
MODULE_DESCRIPTION("Intel(R) Management Engine Interface");
--
1.7.4.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [char-misc-next] mei: use module_pci_driver
2012-07-17 8:23 ` Tomas Winkler
@ 2012-07-17 12:41 ` Arnd Bergmann
2012-07-17 13:01 ` Winkler, Tomas
0 siblings, 1 reply; 9+ messages in thread
From: Arnd Bergmann @ 2012-07-17 12:41 UTC (permalink / raw)
To: Tomas Winkler; +Cc: gregkh, alan, linux-kernel
On Tuesday 17 July 2012, Tomas Winkler wrote:
>
> Change-Id: I960feed4157ad1b178f68f4a0b3968e185ed0b36
The change log got mangled. Please make sure the text you have here actually
describes what the patch does and why.
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> drivers/misc/mei/main.c | 39 +--------------------------------------
> 1 files changed, 1 insertions(+), 38 deletions(-)
For the actual changes:
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [char-misc-next] mei: use module_pci_driver
2012-07-17 12:41 ` Arnd Bergmann
@ 2012-07-17 13:01 ` Winkler, Tomas
0 siblings, 0 replies; 9+ messages in thread
From: Winkler, Tomas @ 2012-07-17 13:01 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: gregkh, alan, linux-kernel
>
> On Tuesday 17 July 2012, Tomas Winkler wrote:
> >
> > Change-Id: I960feed4157ad1b178f68f4a0b3968e185ed0b36
>
> The change log got mangled. Please make sure the text you have here
> actually describes what the patch does and why.
>
Hmm, something went wrong with my scripts. Will look at that.
Thanks
Tomas
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [char-misc-next] mei: use module_pci_driver
2012-07-17 8:23 [char-misc-next] mei: use module_pci_driver Tomas Winkler
2012-07-17 8:23 ` Tomas Winkler
@ 2012-07-17 17:17 ` Greg KH
2012-07-17 20:04 ` Winkler, Tomas
1 sibling, 1 reply; 9+ messages in thread
From: Greg KH @ 2012-07-17 17:17 UTC (permalink / raw)
To: Tomas Winkler; +Cc: arnd, alan, linux-kernel
On Tue, Jul 17, 2012 at 11:23:46AM +0300, Tomas Winkler wrote:
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
This patch fails to apply to my tree :(
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [char-misc-next] mei: use module_pci_driver
2012-07-17 17:17 ` Greg KH
@ 2012-07-17 20:04 ` Winkler, Tomas
2012-07-17 20:40 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Winkler, Tomas @ 2012-07-17 20:04 UTC (permalink / raw)
To: Greg KH; +Cc: arnd, alan, linux-kernel
> This patch fails to apply to my tree :(
Right, my mistake I haven't checked it directly with your tree, I need to wait till you merge the upstream in.
No rush, it's just a cleanup patch.
Thanks
Tomas
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [char-misc-next] mei: use module_pci_driver
2012-07-17 20:04 ` Winkler, Tomas
@ 2012-07-17 20:40 ` Greg KH
2012-07-18 7:42 ` Winkler, Tomas
0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2012-07-17 20:40 UTC (permalink / raw)
To: Winkler, Tomas; +Cc: arnd, alan, linux-kernel
On Tue, Jul 17, 2012 at 08:04:06PM +0000, Winkler, Tomas wrote:
>
> > This patch fails to apply to my tree :(
>
> Right, my mistake I haven't checked it directly with your tree, I
> need to wait till you merge the upstream in.
Merge what "upstream"?
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [char-misc-next] mei: use module_pci_driver
2012-07-17 20:40 ` Greg KH
@ 2012-07-18 7:42 ` Winkler, Tomas
2012-07-18 13:24 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Winkler, Tomas @ 2012-07-18 7:42 UTC (permalink / raw)
To: Greg KH; +Cc: arnd, alan, linux-kernel
> > Right, my mistake I haven't checked it directly with your tree, I
> > need to wait till you merge the upstream in.
>
> Merge what "upstream"?
The doesn't apply because the
commit a44cab4aff7e72e7052521121fd8ceca51351534
misc: mei: unregister misc device in pci_remove function
is only in Linus' master branch.
Your branch char-misc-next is still at v3.5-rc2
I believe that in some point you'll merge the whole Linus' master branch into your char-misc-next branch,
right?
Thanks
Tomas
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [char-misc-next] mei: use module_pci_driver
2012-07-18 7:42 ` Winkler, Tomas
@ 2012-07-18 13:24 ` Greg KH
0 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2012-07-18 13:24 UTC (permalink / raw)
To: Winkler, Tomas; +Cc: arnd, alan, linux-kernel
On Wed, Jul 18, 2012 at 07:42:32AM +0000, Winkler, Tomas wrote:
> > > Right, my mistake I haven't checked it directly with your tree, I
> > > need to wait till you merge the upstream in.
> >
> > Merge what "upstream"?
>
> The doesn't apply because the
> commit a44cab4aff7e72e7052521121fd8ceca51351534
> misc: mei: unregister misc device in pci_remove function
>
> is only in Linus' master branch.
>
> Your branch char-misc-next is still at v3.5-rc2
> I believe that in some point you'll merge the whole Linus' master
> branch into your char-misc-next branch, right?
Ah, yes, sorry, I didn't realize we needed the merge. It's now done.
Care to resend your patch (in the proper format as discussed) so that I
can queue it up?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-07-18 13:24 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-17 8:23 [char-misc-next] mei: use module_pci_driver Tomas Winkler
2012-07-17 8:23 ` Tomas Winkler
2012-07-17 12:41 ` Arnd Bergmann
2012-07-17 13:01 ` Winkler, Tomas
2012-07-17 17:17 ` Greg KH
2012-07-17 20:04 ` Winkler, Tomas
2012-07-17 20:40 ` Greg KH
2012-07-18 7:42 ` Winkler, Tomas
2012-07-18 13:24 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.