All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Winkler, Tomas" <tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Jarkko Sakkinen
	<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: "tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
	<tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH 2/4 v2] tpm/tpm_crb: cache cmd_size register value.
Date: Mon, 12 Sep 2016 11:06:17 +0000	[thread overview]
Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B542CDBDD@hasmsx108.ger.corp.intel.com> (raw)
In-Reply-To: <20160912105446.GC15636-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

> 
> On Mon, Sep 12, 2016 at 01:49:16PM +0300, Jarkko Sakkinen wrote:
> > On Mon, Sep 12, 2016 at 02:03:53AM +0300, Tomas Winkler wrote:
> > > Instead of expensive register access on retrieving cmd_size on each
> > > send, save the value during initialization in the private context.
> > > The value doesn't change.
> > >
> > > Signed-off-by: Tomas Winkler <tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > > Tested-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> >
> > $ git am -3
> > ~/Downloads/2-4-v2-tpm-tpm_crb-cache-cmd_size-register-value..patch
> > Applying: tpm/tpm_crb: cache cmd_size register value.
> > fatal: sha1 information is lacking or useless (drivers/char/tpm/tpm_crb.c).
> > error: could not build fake ancestor
> > Patch failed at 0001 tpm/tpm_crb: cache cmd_size register value.
> > The copy of the patch that failed is found in: .git/rebase-apply/patch
> > When you have resolved this problem, run "git am --continue".
> > If you prefer to skip this patch, run "git am --skip" instead.
> > To restore the original branch and stop patching, run "git am --abort".
> > VCS_INFO_get_data_git:225: no such file or directory: .git/rebase-
> apply/msg-clean
> 
> I did this:
> 
> patch -p1 < ~/Downloads/2-4-v2-tpm-tpm_crb-cache-cmd_size-register-
> value..patch
> git commit -a -s --author="Tomas Winkler <tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>"
> 
> It's now pushed. Could you check that it looks OK for you so that I can include
> this to the next pull request?

Looks great. 

Thanks
Tomas

------------------------------------------------------------------------------

  parent reply	other threads:[~2016-09-12 11:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-11 23:03 [PATCH 0/4] tmp/tpm_crb: cleanups Tomas Winkler
     [not found] ` <1473635035-14443-1-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-11 23:03   ` [PATCH 1/4] tmp/tpm_crb: drop include to platform_device Tomas Winkler
     [not found]     ` <1473635035-14443-2-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12  9:29       ` Jarkko Sakkinen
     [not found]         ` <20160912092921.GC5094-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12 10:47           ` Jarkko Sakkinen
2016-09-11 23:03   ` [PATCH 2/4 v2] tpm/tpm_crb: cache cmd_size register value Tomas Winkler
     [not found]     ` <1473635035-14443-3-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12 10:49       ` Jarkko Sakkinen
     [not found]         ` <20160912104916.GB15636-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12 10:54           ` Jarkko Sakkinen
     [not found]             ` <20160912105446.GC15636-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12 11:06               ` Winkler, Tomas [this message]
2016-09-11 23:03   ` [PATCH 3/4] tpm/tpm_crb: drop useless cpu_to_le32 when writing to registers Tomas Winkler
     [not found]     ` <1473635035-14443-4-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12  9:29       ` Jarkko Sakkinen
2016-09-11 23:03   ` [PATCH 4/4] tpm/tpm_crb: fix the over 80 characters checkpatch warring Tomas Winkler
     [not found]     ` <1473635035-14443-5-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12  9:30       ` Jarkko Sakkinen
2016-09-12 11:29   ` [PATCH 0/4] tmp/tpm_crb: cleanups Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B8DA87D05A7694D9FA63FD143655C1B542CDBDD@hasmsx108.ger.corp.intel.com \
    --to=tomas.winkler-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.