All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Tomas Winkler <tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH 4/4] tpm/tpm_crb: fix the over 80 characters checkpatch warring
Date: Mon, 12 Sep 2016 12:30:20 +0300	[thread overview]
Message-ID: <20160912093020.GE5094@intel.com> (raw)
In-Reply-To: <1473635035-14443-5-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On Mon, Sep 12, 2016 at 02:03:55AM +0300, Tomas Winkler wrote:
> Because of the line break in the debug print the chackpatch is
> not silent on 80 characters limitation.
> 
> The easiest fix is to straighten the lines, it's also more readable.
> 
> WARNING: line over 80 characters
> +                       FW_BUG "TPM2 ACPI table does not define a memory
> resource\n");
> 
> Signed-off-by: Tomas Winkler <tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

/Jarkko

> ---
>  drivers/char/tpm/tpm_crb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c
> index 0c9989d0106e..6e9d1bca712f 100644
> --- a/drivers/char/tpm/tpm_crb.c
> +++ b/drivers/char/tpm/tpm_crb.c
> @@ -263,8 +263,7 @@ static int crb_map_io(struct acpi_device *device, struct crb_priv *priv,
>  	acpi_dev_free_resource_list(&resources);
>  
>  	if (resource_type(&io_res) != IORESOURCE_MEM) {
> -		dev_err(dev,
> -			FW_BUG "TPM2 ACPI table does not define a memory resource\n");
> +		dev_err(dev, FW_BUG "TPM2 ACPI table does not define a memory resource\n");
>  		return -EINVAL;
>  	}
>  
> -- 
> 2.7.4
> 

------------------------------------------------------------------------------

  parent reply	other threads:[~2016-09-12  9:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-11 23:03 [PATCH 0/4] tmp/tpm_crb: cleanups Tomas Winkler
     [not found] ` <1473635035-14443-1-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-11 23:03   ` [PATCH 1/4] tmp/tpm_crb: drop include to platform_device Tomas Winkler
     [not found]     ` <1473635035-14443-2-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12  9:29       ` Jarkko Sakkinen
     [not found]         ` <20160912092921.GC5094-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12 10:47           ` Jarkko Sakkinen
2016-09-11 23:03   ` [PATCH 2/4 v2] tpm/tpm_crb: cache cmd_size register value Tomas Winkler
     [not found]     ` <1473635035-14443-3-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12 10:49       ` Jarkko Sakkinen
     [not found]         ` <20160912104916.GB15636-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12 10:54           ` Jarkko Sakkinen
     [not found]             ` <20160912105446.GC15636-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12 11:06               ` Winkler, Tomas
2016-09-11 23:03   ` [PATCH 3/4] tpm/tpm_crb: drop useless cpu_to_le32 when writing to registers Tomas Winkler
     [not found]     ` <1473635035-14443-4-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12  9:29       ` Jarkko Sakkinen
2016-09-11 23:03   ` [PATCH 4/4] tpm/tpm_crb: fix the over 80 characters checkpatch warring Tomas Winkler
     [not found]     ` <1473635035-14443-5-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12  9:30       ` Jarkko Sakkinen [this message]
2016-09-12 11:29   ` [PATCH 0/4] tmp/tpm_crb: cleanups Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160912093020.GE5094@intel.com \
    --to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
    --cc=tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.